Multiboxes

[Mohammed Niaz M.]

Hi All,
Its a struts project.
Im using html:multibox tag and it use to select the multi boxes and delete the selected boxes.

In this im having fields like name,dob,age,height,country..

Im not cleared about how to use the multiboxes, below is the code.

In listA.jsp page
-----------------
<input name="submit3" type="button" value="Delete"
calling "deleteUsers()" /></td>

<logic resent name="OBList">
<% int count = 0; %>
<logic:iterate id="OB" name="OBList" type="com.integrosys.cms.ui.test.bus.OBA" scope="page">
<tr class="<%=count++%2==0?"even":"odd"%>">
<td class="index"><%=count%></td>
<td><%=OB.getName() %></td>
<td><%=OB.getDob() %></td>
<td><%=OB.getAge() %></td>
<td><%=OB.getGender() %></td>
<td><%=OB.getHeight() %></td>
<td><%=OB.getWeight() %></td>

<td><%=AHelper.getCountryName(OB.getCountry()) %></td>
<td style="text-align:center"><select name="select3" onChange="JumpOnSelectactive(this, '<%=OB.getName() %>')">
<option selected="selected" >Please Select</option>
<option value="edit">Edit</option>
<option value="view">View</option>
<!--option value="delete">Delete</option-->
</select>
</td>
<td><html:multibox property="name" value="<%=OB.getName()%" /></td>
</tr>
</logic:iterate>
</logic resent>

Scripting
----------
delete(){
document.forms[0].action="A.do?event=delete&name=";(how to pass the multi name )
document.forms[0].submit();
}

Thanks in Advanced

[Merrill Higginson]

I'm afraid there's a bit of a flaw in your design. The user could check more than one box to delete, but it looks like your Action is only equipped to delete one record at a time. Since it is not possible to submit the same page more than once, you're going to need an action that can delete more than one record at a time.

Once you've created such an action, you can do something like this:

var boxes = document.getElementsByName('name');
var uri = 'myAction.do?event=delete';
var atLeastOneBoxChecked = false;
for (var i=0;i<boxes.length;i++) {
  if (boxes[i].checked) {
    atLeastOneBoxChecked = true;
    uri = uri + "&name=" + boxes[i].value;
  }
}
if (atLeastOneBoxChecked) {
  document.forms[0].action=uri;
  document.forms[0].submit();
}

[ July 04, 2007: Message edited by: Merrill Higginson ]

[Mohammed Niaz M.]

Hi Merrill,
Thanks for your reply and its working but i have to work in Action to perform the deleting more names.
I let you know the process.

[Mohammed Niaz M.]

Hi Merrill,
still im not able to delete more than one name
Javascript:
-----------
var boxes = document.getElementsByName('name');
var uri = 'A.do?event=delete';
var atLeastOneBoxChecked = false;
for (var i=0;i<boxes.length;i++) {
if (boxes[i].checked) {
atLeastOneBoxChecked = true;
uri = uri + "&name=" + boxes[i].value;
deleteNameList[i] = boxes[i].value; //Added
}
}
if (atLeastOneBoxChecked) {
document.forms[0].action=uri+"&deleteNameList"+deleteNameList;
document.forms[0].submit();
}
------------------
<html:multibox property="name" value="<% OB.getName() %>" />
----------------------Whether i pass the value array instead of OB.getName() to bean

In Formbean
----------
i decalred

String[] deleteNameList;

public String[] getDeleteNameList(){
return deleteNameList;
}

public void setDeleteNameList(String[] deleteNameList){

this.deleteNameList = deleteNameList;
}


public String getName() {
return name;
}

public void setName(String name) {
this.name = name;
}


--------------------------------------
In the URL:
http://localhost:7080/training/A.do?event=delete&name=fds&name=hyg&deleteNameListfds,,hyg

The deleteNameList array is passing to bean but i cannt assign the multi-value to name field or deleteNameList

------------------------------------

Thanks In Advanced.

[Merrill Higginson]

The code you've added won't work. It will not create a well-formed URI. Besides, it isn't necessary. Just use the code I gave you as-is and add the following line to your Action:

String[] deletedEvents = request.getParameterValues("name");

Because the URI passes the parameter "name" multiple times in the query string, the getParameterValues() method returns a string array with one element for each value. In the example you gave, deletedEvents would contain {"fds", "hyg"}. You can then iterate through this array and process the delete for each item.

As an alternative to calling the getParameterValues method, you could simply define the name property as a string array in your ActionForm bean.

[Mohammed Niaz M.]

Hi Merrill,
Im using struts based framework but some additional classes are added they are Mapper,Commands,Declared input parameters and output results � controlled scope.
Im using AAction n AForm.

The Action File
----------------

package com.integrosys.cms.ui.test;
 
import com.integrosys.base.techinfra.logger.DefaultLogger;
import com.integrosys.base.uiinfra.common.CommonAction;
import com.integrosys.base.uiinfra.common.ICommand;
import com.integrosys.base.uiinfra.common.IPage;
import com.integrosys.base.uiinfra.common.Page;
import org.apache.struts.action.ActionErrors;
import org.apache.struts.action.ActionForm;
 
import java.util.HashMap;
import java.util.Locale;
 
public class AAction extends CommonAction {
 
    public static final String EVENT_PREPARE_UPDATE = "prepare_update";
public static final String EVENT_PREPARE_CREATE = "prepare_create";

 
public ICommand[] getCommandChain(String event) {
        System.out.println("Inside getCommandChain()");
        ICommand objArray [] = null;
objArray = new ICommand[1];

        if (EVENT_LIST.equals(event)) {       
        objArray[0] = new ListACommand();
    } else if (EVENT_READ.equals(event)) {
    objArray[0] = new ReadACommand();
    } else if (EVENT_PREPARE_UPDATE.equals(event)) {
            objArray = new ICommand[2];
            objArray[0] = new PrepareACommand();
            objArray[1] = new ReadACommand();
        } else if (EVENT_PREPARE_CREATE.equals(event)) {
        objArray[0] = new PrepareACommand();
        } else if (EVENT_CREATE.equals(event)) {
            objArray[0] = new CreateACommand();
        } else if (EVENT_UPDATE.equals(event)) {
            objArray[0] = new UpdateACommand();
        } else if (EVENT_DELETE.equals(event)) {
            objArray[0] = new DeleteACommand();
        }
        DefaultLogger.debug(this, "*******" + event + "================" + objArray);
        
        String[] deleteNameList = request.getParameterValues("deleteNameList");
        
        return (objArray);
    }
 
 public ActionErrors validateInput(ActionForm aForm, Locale locale) {
 
        return AValidator.validateInput((AForm) aForm, locale);
    }
 
protected boolean isValidationRequired(String event) {
    if (EVENT_CREATE.equals(event) ||
    EVENT_UPDATE.equals(event))
    return true;
    return false;
}  
 
public IPage getNextPage(String event, HashMap resultMap, HashMap exceptionMap) {
        Page aPage = new Page();
        aPage.setPageReference(getReference(event));
        return aPage;
    }
 
private String getReference(String event) {
        return event;
    }
 
    public String getDefaultEvent() {
        return EVENT_LIST;
    }
 
    protected String getErrorEvent(String event) {
   
     System.out.println("Inside getErrorEvent()");
    
     if (EVENT_CREATE.equals(event))
    return EVENT_PREPARE_CREATE;
    if (EVENT_UPDATE.equals(event))
    return EVENT_PREPARE_UPDATE;
        return event;
    }
}

AForm
-----

package com.integrosys.cms.ui.test;
 
import com.integrosys.base.uiinfra.common.CommonForm;
 
import java.io.Serializable;
 
public class AForm extends CommonForm implements Serializable {
    private String name;
    private String country;
    private String gender;
    private String dob;
    private String height;
    private String weight;
    private String age;
    
    private String[] deleteNameList;
 
    private static final String AMAPPER = "com.integrosys.cms.ui.test.AMapper";
 
   
    
     public String[] getDeleteNameList(){
    return deleteNameList;
    }
    
    public void setDeleteNameList(String[] deleteNameList){
    
    this.deleteNameList = deleteNameList;
    }
    
    
    public String getName() {
        return name;
    }
 
    public void setName(String name) {
        this.name = name;
    }
 
    public String getDob(){
    return dob;
    }
    
    
    public void setDob(String dob){
    this.dob = dob;
    }
    
    public String getHeight(){
    return height;
    }
    
    public void setHeight(String height){
    this.height = height;
    }
    
    public String getWeight(){
    return weight;
    }
    
    public void setWeight(String weight){
    this.weight =weight;
    }
    
    public String getGender(){
    return gender;
    }
    
    public void setGender(String gender){
    this.gender = gender;
    }
    
    public String getAge(){
    return age;
    }
    
    public void setAge(String age){
    this.age = age;
    }
        
    
    public String getCountry() {
    System.out.println("getCountry()");
        return country;
    }
 
    public void setCountry(String country) {
        this.country = country;
    }
 
    public void reset() {
        country = "SG";
    }
    
    public String[][] getMapper() {
        
    System.out.println("Inside getMAPPER()");
    
    String[][] input = {
            {"form.OBA", AMAPPER},
        };
        return input;
    }    
}

AMapper Class
-------------

package com.integrosys.cms.ui.test;
 
import com.integrosys.base.uiinfra.common.AbstractCommonMapper;
import com.integrosys.base.uiinfra.common.CommonForm;
import com.integrosys.base.uiinfra.exception.MapperException;
import com.integrosys.cms.ui.test.bus.OBA;
 
import java.util.HashMap;
import java.io.*;
 
public class AMapper extends AbstractCommonMapper {
 


    public Object mapFormToOB(CommonForm cForm, HashMap inputs) throws MapperException {
        System.out.println("Inside mapFormToOB()");
    
    AForm aForm = (AForm) cForm;
 
        OBA aObj = new OBA();
        aObj.setName(aForm.getName());
        aObj.setDob(aForm.getDob());
        aObj.setAge(aForm.getAge());
        aObj.setGender(aForm.getGender());
        aObj.setHeight(aForm.getHeight());
        aObj.setWeight(aForm.getWeight());
        aObj.setCountry(aForm.getCountry());
        aObj.setDeleteNameList(aForm.getDeleteNameList());
        
       
        return aObj;
    }
 
    public CommonForm mapOBToForm(CommonForm cForm, Object obj, HashMap inputs) throws MapperException {
        
    System.out.println("Inside mapOBToForm()");
    
    OBA aObj = (OBA) obj;
        AForm aForm = (AForm) cForm;
 
        aForm.setName(aObj.getName());
        aForm.setDob(aObj.getDob());
        aForm.setAge(aObj.getAge());
        aForm.setGender(aObj.getGender());
        aForm.setHeight(aObj.getHeight());
        aForm.setWeight(aObj.getWeight());
        aForm.setCountry(aObj.getCountry());
        aForm.setDeleteNameList(aObj.getDeleteNameList());
        
        return aForm;
    }
 
 
}

DeleteACommand Class
--------------------

package com.integrosys.cms.ui.test;
 
import com.integrosys.base.uiinfra.common.AbstractCommand;
import com.integrosys.base.uiinfra.common.ICommonEventConstant;
import com.integrosys.base.uiinfra.exception.CommandProcessingException;
import com.integrosys.base.uiinfra.exception.CommandValidationException;
import com.integrosys.cms.ui.common.TrxObject;
 
import java.util.HashMap;
 
public class DeleteACommand extends AbstractCommand {
 
    public String[][] getParameterDescriptor() {
        return (new String[][]{
            {AHelper.getKeyName(), "java.lang.String", REQUEST_SCOPE},
        });
    }
 
public String[][] getResultDescriptor() {
        return (new String[][]{
            {"request.trxObject", "com.integrosys.cms.ui.common.TrxObject", REQUEST_SCOPE}
        });
    }
 
public HashMap doExecute(HashMap map) throws CommandProcessingException, CommandValidationException {
 
        HashMap result = new HashMap();
        HashMap exceptionMap = new HashMap();
        HashMap temp = new HashMap();
 
        String name = (String) map.get(AHelper.getKeyName());
 
        TrxObject trxObj = null;
        try {
            trxObj = AHelper.remove(name);
        } catch (Exception e) {
            AHelper.handleException(exceptionMap, e, this);
        }
        result.put("request.trxObject", trxObj);
 
        System.out.println("==Deleting==");
        temp.put(ICommonEventConstant.COMMAND_RESULT_MAP, result);
        temp.put(ICommonEventConstant.COMMAND_EXCEPTION_MAP, exceptionMap);
        return temp;
        
        
    }
}

AHelper Class
--------------

package com.integrosys.cms.ui.test;
 
import com.integrosys.base.techinfra.logger.DefaultLogger;
import com.integrosys.base.uiinfra.common.ICommand;
import com.integrosys.cms.ui.common.TrxObject;
import com.integrosys.cms.ui.test.bus.AException;
import com.integrosys.cms.ui.test.bus.AProxy;
import com.integrosys.cms.ui.test.bus.OBA;
import org.apache.struts.action.ActionError;
 
import java.util.ArrayList;
import java.util.Collection;
import java.util.Date;
import java.util.HashMap;
 
public class AHelper {
 
public static final String getOBName() {
        return "OBA";
    }
 
 public static final String getOBType() {
        return "com.integrosys.cms.ui.test.bus.OBA";
    }
 
public static final String getKeyName() {
        return "name";
    }
 
public static TrxObject add(Object a) throws Exception {
        OBA aObj = (OBA) a;
        return AProxy.getInstance().add(aObj);
    }
 
public static TrxObject remove(String name) throws Exception {
        DefaultLogger.debug(AHelper.class, "Name in remove is " + name);
        return AProxy.getInstance().remove(name);
    }
 
    //CRUD Operation
    public static Collection getAll() throws Exception {
        return AProxy.getInstance().getAll();
    }
 
    //CRUD Operation
    public static OBA get(String name) throws Exception {
        DefaultLogger.debug(AHelper.class, "Name in Getis " + name);
        return AProxy.getInstance().get(name);
    }
 
 
    //CRUD Operation
    public static TrxObject update(Object aObj) throws Exception {
        DefaultLogger.debug(AHelper.class, "Name in update is " + aObj);
        return AProxy.getInstance().update((OBA) aObj);
    }
 
    public static void handleException(HashMap exceptionMap, Exception e, ICommand command) {
        DefaultLogger.error(AHelper.class, e, e);
        if (e instanceof AException) {
            exceptionMap.put("name", new ActionError("name.already.exists"));
        }
    }
    
    public static String getCountryName(String countryID) {
    return AProxy.getCountryName(countryID);
    }
    
       
}

AProxy Class
------------

package com.integrosys.cms.ui.test.bus;
 
import com.integrosys.cms.ui.common.TrxObject;
 
import java.util.ArrayList;
import java.util.Collection;
import java.util.HashMap;
import java.util.Date;
 
public class AProxy {
    HashMap store = new HashMap();
 
    private static AProxy aProxy;
 
    public static AProxy getInstance() {
        if (aProxy == null)
            aProxy = new AProxy();
        return aProxy;
    }
 
    public static final HashMap getCountryList() {
        HashMap hm = new HashMap();
        hm.put("HK", "Hong Kong");
        hm.put("IN", "India");
        hm.put("SG", "Singapore");
hm.put("MY", "Malaysia");

        return hm;
    }
    
  
public static String getCountryName(String countryID) {
return (String)getCountryList().get(countryID);
}    
 
    public TrxObject add(OBA oba) throws AException {
    if (store.get(oba.getName()) != null) {
    throw new AException("Name existed... ");
    }
        store.put(oba.getName(), oba);
        return makeTrxObject(oba.hashCode());
    }
 
    public TrxObject update(OBA oba) throws AException {
        if (get(oba.getName()) != null) {
            store.put(oba.getName(), oba);
            return makeTrxObject(oba.hashCode());
        } else
            throw new AException("nothing to update");
    }
 
    public OBA get(String key) throws AException {
 
        OBA a = (OBA) store.get(key);
        if (a == null)
            throw new AException("Key not found");
        return a;
    }
 
    public TrxObject remove(String key) throws AException {
        if (get(key) != null)
            store.remove(key);
        else
            throw new AException("Key not found");
        return makeTrxObject(key.hashCode());
    }
 
    public Collection getAll() {
        Collection c = store.values();
        ArrayList list = new ArrayList();
        list.addAll(c);
        return list;
    }
    
    private static TrxObject makeTrxObject(int a) {
        TrxObject trxObj = new TrxObject();
        trxObj.setID(a);
        trxObj.setDate(new Date());
        return trxObj;
    }    
}

ListA.jsp
---------

@ page import="java.util.Collection,
                 java.util.Iterator,
                 com.integrosys.cms.ui.test.*, com.integrosys.cms.ui.test.bus.*"
 
 
 taglib uri="/WEB-INF/struts-bean.tld" prefix="bean" 
 taglib uri="/WEB-INF/struts-html.tld" prefix="html" 
 taglib uri="/WEB-INF/struts-logic.tld" prefix="logic"
 
---scriplets---
      Collection OBList = (Collection)request.getAttribute("request.OBAList");
      if (OBList != null && OBList.size() > 0) {
      pageContext.setAttribute("OBList",OBList);
    }
 
---/scriplets-----
script language="JavaScript" type="text/JavaScript"
 
unction deleteUsers(){

alert('Delete');

var boxes = document.getElementsByName("deleteNameList");
deleteNameList = new Array();
alert(boxes.length);

var uri = 'A.do?event=delete';
var atLeastOneBoxChecked = false;
for (var i=0;i<boxes.length;i++) {
  if (boxes[i].checked) { 
     atLeastOneBoxChecked = true;
     uri = uri + "&name=" + boxes[i].value; 
     deleteNameList[i] = boxes[i].value;
  
    alert(boxes[i].checked);
     
}
}
if (atLeastOneBoxChecked) { 

 document.forms[0].action=uri+"&deleteNameList"+deleteNameList;
 document.forms[0].submit();
}
 

 
}

--/script
 
//listing
 
td width="10%" align="left" input name="submit3" type="button" class="btnNormal" value="Delete"  calling fn=deleteUsers()" //td
 
logic:present name="OBList"
    --scriplet--int count = 0;--/scriptlet-- 
   logic:iterate id="OB" name="OBList"  type="com.integrosys.cms.ui.test.bus.OBA" scope="request"
        &ittr class="--scriplet--=count++%2==0?"even":"odd"--/scriplets--"
        td class="index"--scriplet--=count--/scriplet--
            --scriplet--=OB.getName() -/scriplet--
            --scriplet--=OB.getDob() 
            --scriplet--=OB.getAge() 
            --scriplet--=OB.getGender() 
            --scriplet--=OB.getHeight() 
            --scriplet--=OB.getWeight() 
 
            =AHelper.getCountryName(OB.getCountry()) 
             style="text-align:center" select name="select3" onChange="JumpOnSelectactive(this,'=OB.getName() ')"
                option selected="selected" Please Select/option
                option value="edit"Edit/optio
                option value="view"View/option
                              /select
              /td
            td html:multibox property="deleteNameList" //td 
          /tr
/logic:iterate
    /logic:present
logic:notPresent name="OBList"
tr class="even"
td colspan="4"There is no user found./td
/tr
/logic:notPresent

AForm Class
-----------

package com.integrosys.cms.ui.test;
 
import com.integrosys.base.uiinfra.common.CommonForm;
 
import java.io.Serializable;
 
public class AForm extends CommonForm implements Serializable {
    private String name;
    private String country;
    private String gender;
    private String dob;
    private String height;
    private String weight;
    private String age;
    
    private String[] deleteNameList;
 
    private static final String AMAPPER = "com.integrosys.cms.ui.test.AMapper";
 
   
    
     public String[] getDeleteNameList(){
    return deleteNameList;
    }
    
    public void setDeleteNameList(String[] deleteNameList){
    
    this.deleteNameList = deleteNameList;
    }
    
    
    public String getName() {
        return name;
    }
 
    public void setName(String name) {
        this.name = name;
    }
 
    public String getDob(){
    return dob;
    }
    
    
    public void setDob(String dob){
    this.dob = dob;
    }
    
    public String getHeight(){
    return height;
    }
    
    public void setHeight(String height){
    this.height = height;
    }
    
    public String getWeight(){
    return weight;
    }
    
    public void setWeight(String weight){
    this.weight =weight;
    }
    
    public String getGender(){
    return gender;
    }
    
    public void setGender(String gender){
    this.gender = gender;
    }
    
    public String getAge(){
    return age;
    }
    
    public void setAge(String age){
    this.age = age;
    }
        
    
    public String getCountry() {
    System.out.println("getCountry()");
        return country;
    }
 
    public void setCountry(String country) {
        this.country = country;
    }
 
    public void reset() {
        country = "SG";
    }
    
    public String[][] getMapper() {
        
    System.out.println("Inside getMAPPER()");
    
    String[][] input = {
            {"form.OBA", AMAPPER},
        };
        return input;
    }    
}

---------------------------------------------------------------------------

Still im able to delete only one Name.

Can you help out..

Thanks in Advanced
-- Added UBB [ c o d e ] [ / c o d e ] tags to make code easier to read
[ July 06, 2007: Message edited by: Merrill Higginson ]

[Merrill Higginson]

Mohammed,

Let me explain what I posted earlier. I said that your code will not produce a well-formed URL, and that is still the case. A well-formed url has the format:
http://myserver.com?parm1=value1&parm2=value2&parm3=value3.. etc. Your code does not put the required ampersand between parameters, nor the equal sign between parameter name and value. I've shown you what needs to go into the URL and now its up to you to write code that will produce a well-formed URL.

I'm afraid I'm not going to be able to help you integrate this change into this rather cumbersome framework you're working with. I don't understand how it works, and even with the large amount of code you've already posted, you'd still have to post a lot more of it before I'd even begin to understand it.

Aside from that, writing your code for you is not what I'm here for. I'm simply pointing out to you certain principles and truths about Struts and JavaScript, and then it's up to you to apply them. My advice would be to talk to your supervisor or someone at your company who either wrote or is familiar with this framework and get them to help you make it work for deleting multiple rows.

Having said that, below is a simple Action class that would accomplish the task without your framework. It may help you in figuring out how to make it work within your framework.

public class MyAction extends Action {
 
@Override
public ActionForward execute(ActionMapping mapping, ActionForm form,
HttpServletRequest request, HttpServletResponse response)
throws Exception {
String[] names = request.getParameterValues("name");
AHelper helper = new AHelper();
for (int i = 0; i < names.length; i++) {
helper.remove(names[i]);

}
return mapping.findForward("success");
}
}

[ July 06, 2007: Message edited by: Merrill Higginson ]

[Rauhl Roy]

very nice one and good example for new developers