• Post Reply Bookmark Topic Watch Topic
  • New Topic

Code improvement: 2 similar methods

 
Matt Kurz
Ranch Hand
Posts: 40
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Below 2 similar methods which connect per cxf to web service servers. Each method connects to a different one. How can I improve this code?

 
Mohamed Sanaulla
Bartender
Posts: 3166
34
Google App Engine Java Ruby
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Are FirstService and SecondService, FirstItem and SecondItem and FirstServiceResponse and SecondServiceResponse not related to each other? You can create an Interface for Service and Item which these would implement and then in your connectWS1 method you can program to an interface. You should make your method unaware of the type by encapsulating the type information as well.
 
Matt Kurz
Ranch Hand
Posts: 40
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Mohamed Sanaulla wrote:Are FirstService and SecondService, FirstItem and SecondItem and FirstServiceResponse and SecondServiceResponse not related to each other? You can create an Interface for Service and Item which these would implement and then in your connectWS1 method you can program to an interface. You should make your method unaware of the type by encapsulating the type information as well.


I've thought about an interface, too, but it I'am unsure if it's without prblems to modify the automatic generated code of these classes. They were created by wsdl2java. I'am thinking about generics, too. Maybe a generic method would be fine to shorten the code until the for loop.
 
Happiness is not a goal ... it's a by-product of a life well lived - Eleanor Roosevelt. Tiny ad:
the new thread boost feature: great for the advertiser and smooth for the coderanch user
https://coderanch.com/t/674455/Thread-Boost-feature
  • Post Reply Bookmark Topic Watch Topic
  • New Topic
Boost this thread!