Program like ATM where person enters amount in dollars and cents but program uses int for monies

[Christina Bremmerman]

I've been stuck on this aaall night(it's now 8am) this is my last resort, I don't know what else to do to get this lab to work. First of all here is the assignment I am on the last section(Part C)

http://webpages.sou.edu/~sahrk/cs257/labs/lab03/lab03.pdf

Basically the user is the only one dealing in doubles. the class actually has balance as an int and everything else as doubles still
and here is my Account class

//
//  Account.java
//  CS257 Example (adapted from Lewis & Loftus)
//
//  Represents a bank account with basic services such as deposit
//  and withdraw.
//

import java.text.NumberFormat;

public class Account
{
   // instance data

   private final double RATE = 0.035;  // interest rate of 3.5%

   private long acctNumber;
   private int balance;
   private String name;

   //  Sets up the account by defining its owner, account number,
   //  and initial balance.
   public Account (String owner, long account, double initial)
   {
      name = owner;
      acctNumber = account;
      
      if(initial<0)
      {System.out.println("ERROR: attempt to create an account with negative balance of "+initial);initial=0;}
      else balance = initial*10000  
	}

   //  Deposits the specified amount into the account. Returns the
   //  new balance.
   public double deposit (double amount)
   {
     if(amount<0)
      {System.out.println("ERROR: attempt to make a negative deposit of "+amount);}
      else balance = amount*10000 + (double)balance;
      
      return balance;
      
   }

   //  Withdraws the specified amount from the account and applies
   //  the fee. Returns the new balance.
   public double withdraw (double amount, double fee)
   {
     if(amount<0||amount+fee>balance)
     {System.out.println("ERROR: cannot withdraw negative amount or amount exceeding balance of "+balance);}
      else balance = balance - (amount - fee)*10000;

     return balance;
   }

   //  Adds interest to the account and returns the new balance.
   public double addInterest ()
   {
      balance += (balance * RATE*10000);
      return balance;
   }

   //  Returns the current balance of the account.
   public double getBalance () 
	{ 
	return balance; 
	}

   //  Sets the current balance of the account to a new value.
   public void setBalance (double newBalance)
   {  
      if(newBalance<0)
      {System.out.println("ERROR: balance must be positive");}
      else balance = newBalance*10000; 
   }

   //  Returns a one-line description of the account as a string.
   public String toString ()
   {
      NumberFormat fmt = NumberFormat.getCurrencyInstance();

      return (acctNumber + "\t" + name + "\t" + fmt.format(balance/10000)+"\t"+balance);
   }
}

I got frustrated and started over so right now I know that I don't have my multiplication in all the right places, but the big place I'm getting stuck is the initial up in the constructor. How do I use casting so that it won't take away the change?

Any help, hints, tips...I'm pretty desparate right now and it'd be greatly appreciated.
Thank you

[Campbell Ritchie]

You are quite right to use ints for money, and denominate everything in ¢. Most people, as you will have seen, make the mistake of allowing floating-point arithmetic (eg doubles) anywhere near their money. You will have to get rid of the double arithmetic with the 0.035; use * 7 / 200 instead, but that will restrict you to a maximum balance of approx $3000000, before you get overflow.

You appear to be mixing doubles and ints indiscriminately. Don’t you get compiler errors?
Where do you get 10000 from? I always thought there were 100¢ to the $1.

You can make life easier for yourself by using BigDecimal; that way you can have a BigDecimal or a String as an argument for the constructor

 . . .
   public MyAccount(BigDecimal balance)
   {
      if (balance.compareTo(BigDecimal.ZERO) < 0)
      {
          throw new IllegalArgumentException("Negative values not permitted . . . ");
      }
      . . .
   }

/**
 * ...
 *@param input ...Requires input in format "123.45" or similar
 *@throws NumberFormatException if input is not in correct format for number ...
 */
   public MyAccount(String input)
   {
      this(new BigDecimal(input));
   }

   public MyAccount()
   {
      this(BigDecimal.ZERO);
   }

   public MyAccount(long cents)
   {
      this(String.format("%d.%02d", cents / 100, cents % 100);
   }
...

There. I quite enjoyed writing all those overloaded constructors Notice you do not have a constructor taking a floating-point number as a parameter. Your 3½% would be new BigDecimal("0.035"). Note "" to use Strings not doubles.

[Campbell Ritchie]

If you are really desperate to maintain the doubles, try

double d = 123.45;
 . . .
int i = (int) (d * 100d + 0.5); 

The + 0.5 is to try and round out tiny errors, otherwise every now and again you will get $123.45 turning into ¢12344. Even that is not reliable. A double value greater than 21474386.47 will produce an overflow error. You will not get the rounding you expect from negative values.

[Winston Gutkowski]

Christina Bremmerman wrote:I got frustrated and started over so right now I know that I don't have my multiplication in all the right places, but the big place I'm getting stuck is the initial up in the constructor. How do I use casting so that it won't take away the change?

Any help, hints, tips...I'm pretty desparate right now and it'd be greatly appreciated.

Yes.

Stop. Chill out. If you're old enough, have a beer; and get a good night's sleep. And take your 'F' tomorrow like a man (or as close as you can get to it as a girl).

NEXT TIME: Ask for help sooner.

After you've swallowed your 'F', come back to this thread and read the suggestions when you're in a frame of mind to digest them. Right now, you seem to be all over the place and assuming all sorts of things that the Java Gods never intended (the overriding philosophy of the language - despite its detractors - has always been simplicity).

Programming is basically logic, so its best dealt with when you're calm and rational.

Winston

[Jayesh A Lalwani]

Why are you multiplying everything by 10000 instead of 100? Do you want precision beyond cents? Alson, when you convert from a double to a long, you need to downcast it

So for example, if you did something like this

double d = 8.9038;
long l = d;

Compiler will cry because you cannot implicity convert double to long. Implicit conversion here requires loss of precision and Java won;t let you do it. What you need is explicit downcasting

double d = 8.9038;
long l = (long)d;

So, now in this case

double d = 8.9038;
long l = d*1000;

d is a double and 1000 is an int. Java will implicity upcast the 1000 to a double, and then do the multiplication. A double multiplied by a double is another double. So, d*1000 is a double. Since, you cannot implicity downcast a double to a long, you need to explicitly downcast it. So you have to do this

double d = 8.9038;
long l = (long)(d*1000);

Besides that looking at your code, everything looks fine to me except.. addInterest shouldn't multiply by 10000 and getBalance() should divide by. The constructor as it;s written shouldn;t "take away the change"

[Henry Wong]

Winston Gutkowski wrote:Stop. Chill out. If you're old enough, have a beer; and get a good night's sleep. And take your 'F' tomorrow like a man (or as close as you can get to it as a girl).

NEXT TIME: Ask for help sooner.

That's a pretty brutal response Winston...

Having spent a few all-nighters, I never recommend just giving up on the deadline. After all, it happens in real life. You can't give up if you have a business presentation, or a trade show, that you are trying to meet the deadline for. A school assignment deadline isn't much different.

There are some suggestions in this topic that can be used. Try again.

Henry

[Christina Bremmerman]

Thank you all for your replies. I took a break and a nap and I'm about to take another shot at this. I still have about 6 hours to come up with something better than my sleep deprived brain was giving me. It seems in my haze I didn't get enough detail in my initial reply. The 10000s are how far out he wants the number for this lab and I can't add any other variables for the balance I have to strictly use the int balance

Change the data type of the Account class instance variable balance to int. This instance
variable will store the current account balance as some number of 1/100th’s of a cent. For
example, if the current balance is $54.67, then the value of the instance variable balance should
be 546700. Note: you may not create a second instance variable that stores the current balance as
a float or double. The only instance variable that can be used to keep track of the current balance
is the int balance

[Winston Gutkowski]

Henry Wong wrote:That's a pretty brutal response Winston...

Perhaps; and if so, I apologise.
I too have done all-nighters, but if I'm honest about it, the times they actually worked are outnumbered by the ones where I simply wasted the following day by walking around like a zombie.

The number of times I've gone to bed, and woken up a few hours later with a 'Eureka' moment, however....
Sometimes the best way to solve a problem is to give it a rest.

Christina, my final piece of advice: Keep a notebook by your bed.

Winston

[Christina Bremmerman]

Well I had to come back and post this for Winston. It works, and it fits the lab assignment. So I think I avoided the F even though it seems like there should have been an easier way to do this. But my mom came online and gave me similar advice(She said to drink cocoa though, not beer LoL)
Also I do understand the value of sleep, just last week I had a bad loop in my assignment that I spent hours comparing to other loops and trying to alter to no avail, I went to sleep, woke up, added a -1 and it worked.
I just felt like I didn't have enough done to sleep just yet and I ended up just digging myself deeper and deeper

import java.text.NumberFormat;

public class Account
{
   // instance data

   private final double RATE = .035;  // interest rate of 3.5%

   private long acctNumber;
   private int balance;
   private String name;

   //  Sets up the account by defining its owner, account number,
   //  and initial balance.
   public Account (String owner, long account, double initial)
   {
      name = owner;
      acctNumber = account;
      
      if(initial<0)
      {System.out.println("ERROR: attempt to create an account with negative balance of "+initial);initial=0;}
      else balance = (int)(initial*10000);  
	}

   //  Deposits the specified amount into the account. Returns the
   //  new balance.
   public double deposit (double amount)
   {
     if(amount<0)
      {System.out.println("ERROR: attempt to make a negative deposit of "+amount);}
      else balance = (int)(amount*10000) + balance;
 
      return (double)balance/10000;
      
   }

   //  Withdraws the specified amount from the account and applies
   //  the fee. Returns the new balance.
   public double withdraw (double amount, double fee)
   {
     if(amount<0||amount+fee>(double)balance/10000)
     {System.out.println("ERROR: cannot withdraw negative amount or amount exceeding balance of "+balance);}
      else balance = balance - (int)((amount - fee)*10000);

     return (double)balance/10000;
	     }

   //  Adds interest to the account and returns the new balance.
   public double addInterest ()
   {
      balance = (balance + (int)(((double)balance/10000 * (RATE))*10000));
     return (double)balance/10000;
   }

   //  Returns the current balance of the account.
 public double getBalance ()   
    {   
	 balance=balance/10000;
    return balance;   
    }

   //  Sets the current balance of the account to a new value.
   public void setBalance (double newBalance)
   {  
      if(newBalance<0)
      {System.out.println("ERROR: balance must be positive");}
      else balance = (int)(newBalance*10000); 
   }

   //  Returns a one-line description of the account as a string.
   public String toString ()
   {
      NumberFormat fmt = NumberFormat.getCurrencyInstance();

      return (acctNumber + "\t" + name + "\t" + fmt.format((double)balance/10000));
   }
}

[Winston Gutkowski]

Christina Bremmerman wrote:Well I had to come back and post this for Winston. It works, and it fits the lab assignment. So I think I avoided the F...

Hey, what do I know? Sometimes it's good to be proved wrong.

Well done.

Winston

[Ryan Sykes]

I think you have an error here.

   //  Returns the current balance of the account.  
 public double getBalance ()     
    {     
     balance=balance/10000;  
    return balance;     
    }

Balance is an int, as is 10000. The division will give you an integer without any decimal digits, so you won't get any information about the amount in cents. Did you get the same output as Part B?
I think that something like this would have been the correct approach:

public double getBalance () { 
	return (balance / 10000.0); 
}

Dividing by a double would return a result in a value that is still a double. I wrote this small test program:

public class Test {
	public static void main(String[] args) {
		int balance = 532955; // $53.2955
		System.out.println((double) balance / 10000);
		System.out.println((double) (balance / 10000));
		System.out.println((double) (balance / 10000.0));
		System.out.println(balance / 10000);
	}
}

The resulting output was:

53.2955
53.0
53.2955
53

If you look carefully you will understand why the 1st and 3rd conversions gave the correct result. I noticed that you have used something of the form

(double) balance / 10000

in your program, but it is not clear if you truly understood why it worked. It worked because the (double) type cast operates first on balance, which is an int, and this is then subsequently divided by an int. So a double / int results in a double output. I would personally prefer something like the 6th line of code as the use of the parenthesis makes things more clear.

I had a question myself: Which of the following snippets of code is the better way to approach things?

balance = balance - (int) (amount * 10000) - (int) (fee * 10000);
balance = balance - (int) ((amount - fee) * 10000);

I personally think it should be the code on line 1 as it would prevent the occasional alignment of numerical errors in amount and fee that add/subtract out to push the resulting number into being rounded up or down the wrong way. Is that correct or are both lines of code equivalent?

[Campbell Ritchie]

I said earlier, you really want to keep doubles out of money.

int cents = 123456;
System.out.printf("$%d.%02d%n", cents / 100, cents % 100);

That is one way to do it.

[Ryan Sykes]

Thanks Campbell. That is what I was thinking would be the correct way to go about things. I guess in this particular assignment though, they ask that you not change the Account class in terms of the API/public class interface. So you do still have to return a value of type double, but perhaps it would be best to still construct the return value in the manner you wrote above but with type double.

[Campbell Ritchie]

No, you still shouldn’t use floating-point for money. It is a shame that some people who set assignments don’t seem to know that.

[Ryan Sykes]

I agree. It is a poor example that doesn't really illustrate how floating point arithmetic can give rise to inaccurate results.