Excel file is corrupted when i download it

[mallikarjun dontamsetti]

hi, i have generated excel file using Apache POI .it is generated in my root path under excel folder.when user click save as excel the created file should download to user chosen location. it is get downloaded to that perticular path given by user but, when i try to open a message is showing like this file format corrupted ......my code on click of button on jsp is

strDate = strDate.substring(8,10) + strDate.substring(5,7) + strDate.substring(0,4) + "_" + strDate.substring(11,13) + strDate.substring(14,16)  + strDate.substring(17,19);
String path1=application.getRealPath("/")+ "EXCEL/TransactionsReport_"+ UserName +".xls";
response.setContentType ("application/vnd.ms-excel");
 String filename = "TransactionsReport_" + strDate + "_" + UserName + ".xls";
 response.setHeader ("Content-Disposition","attachment; filename="+filename);

 BufferedInputStream in=null;
    ServletOutputStream outs=null;
		byte[] buffer = new byte[1024]; 
		//int bit = 256;
		int i = 0;
    		try {
             in = new BufferedInputStream(new FileInputStream(new File (path1)));  
             outs=response.getOutputStream();
while ((i = in.read(buffer, 0, buffer.length)) != -1) {  
                  outs.write(buffer, 0, i);  
                  }  
                  outs.flush();  

            		} catch (IOException ioe) {
            			ioe.printStackTrace(System.out);
            		}
            	finally{
            		outs.close();
            		in.close();	
                }

but the generated code is giving a corrupted excel file

[mallikarjun dontamsetti]

It is working when i deployed it on web not in local system why?

[Rob Spoor]

You shouldn't use JSP files to display any binary file, including Excel files. Any whitespace between tags (like at the top, between import directives) can already be added to the output. That will cause corruption of binary files. Instead, use a servlet to display the binary file.

[mallikarjun dontamsetti]

thanks

[Rob Spoor]

You're welcome.