problem in setting background image of jpanel

[Punit Jain]

i m not able to set a background image of my JPanel, can anyone tell me how do i set JPanel Background image??
here is my code, in which i m setting the background color of my JPanel but i want to set an image instead:

import javax.swing.*;  

import java.awt.*;  
import java.awt.event.*;  
import java.util.Random;  
  
class Test {  
	public static void main(String args[])
	{ 
		JFrame frame = new JFrame();
		Cpoint point = new Cpoint();
		Cdynamic d = new Cdynamic(point);
		Cair ca= new Cair();
		d.panel.setBackground(Color.ORANGE);
        point.setBackground(new Color(0,0,255));
		JSplitPane sp = new JSplitPane(JSplitPane.VERTICAL_SPLIT, d.panel, point);
		Container c = frame.getContentPane();
	   	c.add(sp, BorderLayout.CENTER);
	   	ca.setPreferredSize(new Dimension(200,0));
	   	c.add(ca, BorderLayout.EAST);
	   	frame.setVisible(true);
		frame.setSize(1280,750);
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
	 } 
}  
class Dynamic extends JPanel  
{  
  JPanel panel;  
  JButton button;  
  JLabel label;  
  Cpoint cp;  
  Dynamic(Cpoint c)  
  {  
      cp = c;  
      System.out.println("Inside Dynamic class");  
    panel = new JPanel();  
    panel.setBackground(Color.yellow);  
    button = new JButton("Fish Die");  
    label = new JLabel("Label to test");  
    panel.add(button);  
    panel.add(label);  
    button.addActionListener(new ActionListener(){  
      public void actionPerformed(ActionEvent ae){  
        cp.fishAlive = false;  
        if(cp.timer != null && cp.timer.isRunning())  
        {  
          cp.timer.stop();  
          cp.repaint();  
        }  
      }  
    });  
  }  
}  
class Cpoint extends JPanel implements ActionListener{  
  Cfish1 ball,ball2,ball3,ball4,ball5,ball6;  
  Cbubble1 bull,bull2,bull3,bull4,bull5,bull6,bull7,bull8,bull9,bull10;  
  int newx, newy, midx,midy,getradius, newwidth, newheight;  
  Timer timer;  
  int count;  
  boolean fishAlive = true;  
  int counter = 0;  
  Cpoint()  
  {  
    timer = new Timer(26, this);  
    timer.start();  
    ball = new Cfish1(500,100, new ImageIcon("g:\\fish\\fish1.jpg").getImage());  
    bull = new Cbubble1(20,400);  
  }  
  public void paintComponent(Graphics g)  
  {  
    super.paintComponent(g);  
    if(fishAlive)  
    {  
      ball.DisplayFish(g);  
      bull.DisplayBubble(g);    
    }  
  }  
    public void actionPerformed(ActionEvent e)  
    {  
      ball.movementFish(this);  
      bull.movement_bubble(this);  
        try  
        {  
        repaint();  
        } catch (Exception ex)  
        {  
          ex.printStackTrace();  
        }  
        System.out.println("timer "+(counter++));  
    }  
}  
class Cfish1 {  
   int x = 2;  
   int y = 5;  
   int dx = 2;  
   int dy = 1;  
   int radius = 9;  
   Image fishImg;
   public Cfish1() {}
   public Cfish1(int x, int y,Image img) 
   {
   fishImg = img;
   this.x = x;
   this.y = y;
   radius = fishImg.getWidth(null)/2;
   }
  public int getRadius() {  
    return radius;  
  }  
  public void movementFish(Cpoint sp)  
  {  
  if(x+dx>sp.getWidth()-radius-4)  
    {  
      x = sp.getWidth()-radius-2;  
      dx = -dx;  
    }  
    else if(x+dx<0+radius)  
    {  
      x = 0+radius;  
      dx = -dx;  
    }  
    else{  
    x+=  dx;  
    }  
    if(y+dy>sp.getHeight()-radius-4)  
    {  
      y = sp.getHeight()-radius-4;  
      dy = -dy;  
    }  
    else if(y+dy<0+radius)  
    {  
      y = 0+radius;  
      dy = -dy;  
    }  
    else{  
    y+= dy;  
    }  
    y+= dy;  
  }  
  public void DisplayFish(Graphics g)
  {
    g.drawImage(fishImg,x,y,null);
  }  
}  
class Cbubble1 {  
  private int bulx=0;  
  private int buly=0;  
  private int buldx=0;  
  private int buldy=-2;  
  private int bulradius = 2;  
  String bName;  
  public Cbubble1(int i, int j)  
  {  
    bulx=i;  
    buly=j;  
  }  
  public void movement_bubble(Cpoint sp)  
  {  
    if(buly+buldy>sp.getHeight()-bulradius-4)  
    {  
      buly = sp.getHeight()-bulradius-4;  
      bulradius++;  
      if(bulradius==6)  
        bulradius=1;  
    }  
    else if(buly+buldy<bulradius)  
    {  
      buly=sp.getHeight();  
    }  
    else{  
    buly+= buldy;  
    }  
  }  
  public void DisplayBubble(Graphics g)  
  {  
    g.setColor(Color.white);  
    g.drawOval(bulx-bulradius, buly-bulradius, bulradius*4,bulradius*4);  
  }  
}  

class Cdynamic extends JPanel  
{  
  JPanel panel;  
  JButton buttonDead, buttonAlive;  
  Cpoint cp;  
  Cdynamic(Cpoint c)  
  {  
    cp = c;  
    System.out.println("Inside Dynamic class");  
    panel = new JPanel();  
    panel.setBackground(Color.yellow);  
    buttonDead = new JButton("Remove Oxygen");
    buttonAlive = new JButton("Add Oxygen");
    panel.add(buttonDead);  
    panel.add(buttonAlive);
      buttonDead.addActionListener(new ActionListener(){  
      public void actionPerformed(ActionEvent ae){   
        cp.fishAlive = false;  
        if(cp.timer != null && cp.timer.isRunning())  
        {  
          cp.timer.stop();  
          cp.repaint();  
        }  
      }  
    });  
    buttonAlive.addActionListener(new ActionListener() {
		@Override
		public void actionPerformed(ActionEvent arg0) {
			cp.fishAlive = true;
				cp.timer.start();
				cp.repaint();
		}
	});
  }  
}  
class Cair extends JPanel  
{   
  public void paintComponent(Graphics g)
  {
	  super.paintComponent(g);
	  g.drawString("Here i will add some air effects", 20, 20);
  }
}  

[Paul Clapham]

Punit Jain wrote:i m not able to set a background image of my JPanel, can anyone tell me how do i set JPanel Background image??

Yes, I'm sure many people can. I used jpanel background image as my Google keywords and that brought up quite a list of those people. Give it a try (searching the web I mean).

[Michael Dunn]

an example is also in the Swing FAQ (main page of Swing forum)

[Punit Jain]

okay i just use the code which is in swing faq, but not working for me...
what wrong i m doing..?

import java.awt.BorderLayout;
import java.awt.Color;
import java.awt.Container;
import java.awt.Dimension;
import java.awt.Graphics;
import java.awt.GridLayout;
import java.awt.Image;
import java.io.ObjectInputStream.GetField;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JSplitPane;
import javax.swing.JTextArea;
public class Ctank {
	public static void main(String args[])
	{ 
		JFrame frame = new JFrame();
		Cpoint point = new Cpoint();
		Cdynamic d = new Cdynamic(point);
		Cair ca= new Cair();
		d.panel.setBackground(Color.ORANGE);
     
		point.add(new BackgroundPanel());            //---------------------Here i m adding

		JSplitPane sp = new JSplitPane(JSplitPane.VERTICAL_SPLIT, d.panel, point);
		Container c = frame.getContentPane();
	   	c.add(sp, BorderLayout.CENTER);
	   	ca.setBackground(Color.PINK);
	   	ca.setPreferredSize(new Dimension(200,0));
	   	c.add(ca, BorderLayout.EAST);
	   	frame.setVisible(true);
		frame.setSize(1280,750);
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
	 }
}
class BackgroundPanel extends JPanel
{
  Image image;
  public BackgroundPanel()
  {
    try
    {
      image = javax.imageio.ImageIO.read(new java.net.URL(getClass().getResource("g:\\fish\\fish1.jpg"), "fish1.jpg"));
    }
    catch (Exception e) {}
  }

  @Override
  protected void paintComponent(Graphics g)
  {
    super.paintComponent(g); 
    if (image != null)
      g.drawImage(image, 0,0,this.getWidth(),this.getHeight(),this);
  }
}

[Michael Dunn]

as I explained in one of your other topics, it has no size - you have to set it.

if you want a background image for Cpoint, then the code in BackgroundPanel
should be part of Cpoint, not adding another panel to it

[Punit Jain]

if you want a background image for Cpoint, then the code in BackgroundPanel
should be part of Cpoint, not adding another panel to it

import java.awt.BorderLayout;
import java.awt.Color;
import java.awt.Container;
import java.awt.Dimension;
import java.awt.Graphics;
import java.awt.GridLayout;
import java.awt.Image;
import java.awt.image.ImageObserver;
import java.io.ObjectInputStream.GetField;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JSplitPane;
import javax.swing.JTextArea;
public class Ctank {
	public static void main(String args[])
	{ 
		JFrame frame = new JFrame();
		Cpoint point = new Cpoint();
		Cdynamic d = new Cdynamic(point);
		Cair ca= new Cair();
		d.panel.setBackground(Color.ORANGE);
		point.add(point, new BackgroundPanel());
		JSplitPane sp = new JSplitPane(JSplitPane.VERTICAL_SPLIT, d.panel, point);
		Container c = frame.getContentPane();
	   	c.add(sp, BorderLayout.CENTER);
	   	ca.setBackground(Color.PINK);
	   	ca.setPreferredSize(new Dimension(200,0));
	   	c.add(ca, BorderLayout.EAST);
	   	frame.setVisible(true);
		frame.setSize(1280,750);
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
	 }
}
class BackgroundPanel
{
  Image image;
  public BackgroundPanel()
  {
    try
    {
      image = javax.imageio.ImageIO.read(new java.net.URL(getClass().getResource("g:\\fish\\fish1.jpg"), "fish1.jpg"));
    }
    catch (Exception e) {}
  }

  protected void paintComponent(Graphics g, Cpoint sp)
  {
    sp.paintComponent(g); 
    if (image != null)
      g.drawImage(image, 10,10,sp.getWidth(),sp.getHeight(),sp);
  }
}

But still not working...

[Paul Clapham]

This code is all wrong:

new java.net.URL(getClass().getResource("g:\\fish\\fish1.jpg"), "fish1.jpg")

First of all getResource() already returns a URL, so wrapping it in a URL seems pointless. And using the URL constructor which gets a relative URL for a resource with the same name also seems pointless. But the real problem is that getResource doesn't take a file path in the first place. If you want to use a file path, a File object is the thing to use. The getResource() method is for finding resources in the classpath. So use a File object.

[Punit Jain]

okay, like this...

image = javax.imageio.ImageIO.read(new java.net.URL(getClass().getResource("fish2.jpg"), "fish"));

and i m getting exception in this line

point.add(point, new BackgroundPanel());

[Rob Spoor]

That looks like you're trying to add point to itself using a new BackgroundPanel as constraints. That's obviously not going to work.

[Punit Jain]

what to do here, can you correct me??

[Michael Dunn]

from your last posted code, this part is so wrong it's not funny

protected void paintComponent(Graphics g, Cpoint sp)
{
  sp.paintComponent(g); 
  if (image != null)
    g.drawImage(image, 10,10,sp.getWidth(),sp.getHeight(),sp);
}

you really need to read Sun/Oracle's painting tutorial,
because you need to discover why the above is wrong.
no point just being told why.

http://docs.oracle.com/javase/tutorial/uiswing/painting/index.html

[Punit Jain]

okay i will..
one more thing i really want to know always, and i believe you can help me in that also,
which is the best way to read javadoc??
because javadoc always provides only classes,methods,constructor etc.
and most of times i don't know how to use most of them even..

[Michael Dunn]

the info (limited) in the javadocs is at the top.

this link is the best for 'How To ...'

http://docs.oracle.com/javase/tutorial/uiswing/TOC.html

[Punit Jain]

okay thank you very much for this..
one more thing these table of contents are for swing,
where do i get this for java core..?

[Darryl Burke]

Punit Jain wrote:okay thank you very much for this..
one more thing these table of contents are for swing,
where do i get this for java core..?

Did you try clicking links on that page to see where you end up?

[Punit Jain]

Did you try clicking links on that page to see where you end up?

no i just looked at the TOC.

[Rob Spoor]

Then please ShowSomeEffort and read the page itself.

[Punit Jain]

okay i corrected my paintComponent, but still it's not working, here it is

public void paintComponent(Graphics g)
	{
		ImageIcon imageicon = new ImageIcon(getClass().getResource(imageFile));
		Image image = imageicon.getImage();
		super.paintComponent(g);

		if (image != null)
			g.drawImage(image, 0, 0, getWidth(), getHeight(), this);

	}

[Rob Spoor]

You should never load any resources in any painting method. paintComponent may be called multiple times per second, and that will slow down painting significantly. You should instead load the image in the constructor and keep a reference to it.