ActionForm not passing values to JSP

Greenhorn

Posts: 18

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Wenas, I have an Action that set the fields of an ActionForm directly, like this:

The ActionForm method looks like this:

After that I checked that the form fields where correctly set.
I expected that in the JSP forwarded, the fields would auto populate with the ActionForm values since names are the same:

...but no, fields are empty. What could be the problem?

Thanks

.NET & JSP developer for <a href="http://www.grupocartuja.com" target="_blank" rel="nofollow"> Grupo Cartuja</a> Currently moving the webpage from ASP to Struts (mostly the Intranet)

Merrill Higginson

Ranch Hand

Posts: 4864

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

In your code:

Is the form1 variable the result of casting the ActionForm instance sent as parameter to the execute method? If not, that's the problem. example:

Merrill
Consultant, Sima Solutions

Mario Romero

Greenhorn

Posts: 18

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

The problem is that I have an ActionForm for each JSP (in this case at least) to make it more "modularized" instead of relaying in a big ActionForm.

I found this wiki http://wiki.apache.org/struts/StrutsMultipleActionForms which talks about the problem and some solutions. I will just make a bigger ActionForm then and bookmark that page for later use when I find myself more confortable with struts.

Btw what I did was just creating a new ActionForm

And think that the next page will magically take that form since it was the same class it wanted. Forgetting all the OOP basics is my speciality.

Thanks again Merrill.
[ August 24, 2007: Message edited by: Mario Romero ]

.NET & JSP developer for <a href="http://www.grupocartuja.com" target="_blank" rel="nofollow"> Grupo Cartuja</a> Currently moving the webpage from ASP to Struts (mostly the Intranet)

Christian Nash

Ranch Hand

Posts: 107

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hey this is what i did....

jsp1.jsp
 
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<%@ taglib uri="/WEB-INF/struts-html.tld" prefix="html" %>
<%@ taglib uri="/WEB-INF/struts-bean.tld" prefix="bean" %>
<html:html>
<HEAD> <%@ page language="java" contentType="text/html; charset=ISO-8859-1" pageEncoding="ISO-8859-1"
%>
<META http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
<META name="GENERATOR" content="IBM WebSphere Studio">
<META http-equiv="Content-Style-Type" content="text/css">
<LINK href="theme/Master.css" rel="stylesheet" type="text/css">
</HEAD>
 
<BODY>
<html:form action="/action1"> 
Jsp1<html:submit value="Click here" />
</html:form>
</BODY>
</html:html>
--------------------------------
Action1.java
 
package demoproject.actions;
 
import java.io.IOException;
import java.util.ArrayList;
 
import javax.servlet.ServletException;
 
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.struts.action.Action;
import org.apache.struts.action.ActionError;
import org.apache.struts.action.ActionErrors;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
 
import demoproject.forms.FormBean1;
 
/**
 * @version 1.0
 * @author
 */
public class Action1 extends Action {
 
public ActionForward perform(
ActionMapping mapping,
ActionForm form,
HttpServletRequest request,
HttpServletResponse response)
throws IOException, ServletException {
 
ActionErrors errors = new ActionErrors();
ActionForward forward = new ActionForward(); // return value
 
try {
FormBean1 bean1 = (FormBean1) form;
ArrayList list = new ArrayList();
list.add("Christian");
list.add("Nash");
bean1.setArraylist(list);
// do something here
 
} catch (Exception e) {
e.printStackTrace();
}
return (mapping.findForward("success"));
}
}
 
--------------------------------------
FormBean1.java
 
package demoproject.forms;
 
import java.util.ArrayList;
 
import javax.servlet.http.HttpServletRequest;
import org.apache.struts.action.ActionErrors;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionMapping;
 
/**
 * Form bean for a Struts application.
 * @version 1.0
 * @author
 */
public class FormBean1 extends ActionForm {
 
ArrayList arraylist = new ArrayList();
public void reset(ActionMapping mapping, HttpServletRequest request) {
 
// Reset field values here.
 
}
 
public ActionErrors validate(
ActionMapping mapping,
HttpServletRequest request) {
 
ActionErrors errors = new ActionErrors();
// Validate the fields in your form, adding
// adding each error to this.errors as found, e.g.
 
// if ((field == null) || (field.length() == 0)) {
// errors.add("field", new org.apache.struts.action.ActionError("error.field.required"));
// }
return errors;
 
}
/**
 * @return
 */
public ArrayList getArraylist() {
return arraylist;
}
 
/**
 * @param list
 */
public void setArraylist(ArrayList list) {
arraylist = list;
}
 
}
--------------------------------------
jsp2.jsp
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<%@ taglib uri="/WEB-INF/struts-html.tld" prefix="html" %>
<%@ taglib uri="/WEB-INF/struts-bean.tld" prefix="bean" %>
<html:html>
<bean :mrgreen: efine id="arraylist" name="formBean1" property="arraylist"
type="java.util.Collection" />
<HEAD>
<%@ page 
language="java"
contentType="text/html; charset=ISO-8859-1"
pageEncoding="ISO-8859-1"
%>
<META http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
<META name="GENERATOR" content="IBM WebSphere Studio">
<META http-equiv="Content-Style-Type" content="text/css">
<LINK href="theme/Master.css" rel="stylesheet" type="text/css">
</HEAD>
 
<BODY>
<html:form action="/action2"> 
Jsp2<html:submit value="Click here" />
</html:form>
</BODY>
</html:html>
 
--------------------------------
Action2.java
 
package demoproject.actions;
 
import java.io.IOException;
import java.util.ArrayList;
import java.util.Iterator;
 
import javax.servlet.ServletException;
 
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.struts.action.Action;
import org.apache.struts.action.ActionError;
import org.apache.struts.action.ActionErrors;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
 
import demoproject.forms.FormBean1;
 
/**
 * @version 1.0
 * @author
 */
public class Action2 extends Action {
 
public ActionForward perform(
ActionMapping mapping,
ActionForm form,
HttpServletRequest request,
HttpServletResponse response)
throws IOException, ServletException {
 
ActionErrors errors = new ActionErrors();
ActionForward forward = new ActionForward(); // return value
 
try {
 
FormBean1 bean1 = (FormBean1) form;
ArrayList list = bean1.getArraylist();
Iterator iter = list.iterator();
while (iter.hasNext())
System.out.println(iter.next() + " in Action2");
} catch (Exception e) {
e.printStackTrace();
 
}
 
return (mapping.findForward("success"));
 
}
}

Hope this helps

- Christian

Hari Dhanakoti

Greenhorn

Posts: 6

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Can we set the form values in request attribute from servlet and display the values of the form bean in JSP?

If setting as attribute can we have any other methods to print the value of the form bean in JSP

Thanks in Advance

Regards Hari

Mario Romero

Greenhorn

Posts: 18

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

mmm thanks Christian, that should made the trick for now.

Hari, to your first question, yes. You can do MyForm.setField(whatever) in the Action, and the form will "transport" the values to the next JSP page which you can show with c:out for example.

2� question, an attribute doesn�t pass through the Form, it goes directly in the request to the JSP. There you can show it with c:out too.
[ August 24, 2007: Message edited by: Mario Romero ]

.NET & JSP developer for <a href="http://www.grupocartuja.com" target="_blank" rel="nofollow"> Grupo Cartuja</a> Currently moving the webpage from ASP to Struts (mostly the Intranet)

Consider Paul's rocket mass heater.