Code Optimizatoin

[Arun vel]

I want to optimize this code..
Can anyone please help..

package com.thread.fileprocessingwithdatabase.exam;

import java.io.BufferedReader;
import java.io.DataInputStream;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.IOException;
import java.io.InputStreamReader;
import java.sql.Connection;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.Scanner;
import java.util.Set;
import java.util.StringTokenizer;

import com.thread.fileprocessingwithdatabase.DBConnection;

class FileReadThread implements Runnable
{
	static String source = "D:\\exercise\\ExerciseFiles";
	static String errorFolder = "D:\\exercise\\Error";
	static ArrayList<String> fileList = new ArrayList<String>();
	static ArrayList<String> al = new ArrayList<String>();
	public void run()
	{
	while(true)
	{
		String line = "";
		StringTokenizer st;
		String split = ",";
		String empid;
		String name;
		String age;
		String sex;
		String city;
		String department;
		String designation;
		String qualification;
		File Folder = new File(source);
		File files[];
		files = Folder.listFiles();
		if(files.length>0)
		{
			for(int i = 0;i<files.length;i++)
			{
				
			 String readFiles= files[i].getName();
			 fileList.add(readFiles);
			 System.out.println("ReadFileList : " + fileList);
			try
			{
			 FileInputStream fis = new FileInputStream(files[i]);
			 DataInputStream dis = new DataInputStream(fis);
			 BufferedReader buffer = new BufferedReader(new InputStreamReader(dis));
			 Scanner scanner = new Scanner(buffer);
			 boolean fileRepeat = false;
			 Set<String> fileSet = new HashSet<String>(fileList); 
			 if(fileSet.size() < fileList.size())
			 {      
				 fileRepeat = true;
				 System.out.println("File came again");
				 if(fileRepeat == true)
				 {
					 files[i].delete();
					 fis.close();
					 dis.close();
					 buffer.close();
				 }
			 }
			 while (scanner.hasNextLine())
			 {
			 line = scanner.nextLine();
			 st = new StringTokenizer(line,split); 
			 try
			 {
			 while(st.hasMoreTokens())
			 {
				empid = st.nextToken();
				name = st.nextToken();
				age = st.nextToken();
				sex = st.nextToken();
				city = st.nextToken();
				department = st.nextToken();
				designation = st.nextToken();
				qualification = st.nextToken();
				  al.add(0,empid);
				  al.add(1,name);
			      al.add(2,age);
			      al.add(3,sex);
				  al.add(4,city);
				  al.add(5,department);
				  al.add(6,designation);
				  al.add(7,qualification);
				System.out.println(name);
			}
			boolean insertStatus=Insertion();
			fis.close();
			dis.close();
			buffer.close();
			if(insertStatus == true)
			{
				try
				{
					 files[i].delete();
				}
				catch(Exception e)
				{
					e.printStackTrace();
				}
			}
			else if(insertStatus == false)
			{
				fis.close();
				dis.close();
				buffer.close();
				try
				{
						 System.out.println("ERROR-FILE");
					     String currentFile1 = files[i].getName();
						 File errorFile = new File(currentFile1);
					     File dir = new File("D:\\exercise\\Error");
				         errorFile.renameTo(dir);
				         files[i].renameTo(dir);
				}
				catch(Exception e)
				{
					e.printStackTrace();
				}
			}
		}
		catch(Exception e)
		{
			System.out.println(e.getMessage());
		}
		}
		}
		catch (FileNotFoundException fn)
		{
			fn.printStackTrace();
			System.out.println(fn.getLocalizedMessage());
		}
		catch (IOException e)
		{
			e.printStackTrace();
		}
			}
			try
			{
				Thread.sleep(15000);
			}
			catch(InterruptedException ie){}
	}
	}
	}
	
	public static boolean Insertion() throws SQLException //++++++INSERTION Method For Employee Record++++++
	{
		    Connection conn = null;
			String EmpID = al.get(0);
			String Name = al.get(1);
			String Age = al.get(2);
			String Sex = al.get(3);
			String City = al.get(4);
			String Department = al.get(5);
			String Designation = al.get(6);
			String Qualification = al.get(7);	
			boolean insertStatus = false;
			try 
				{   
					DBConnection db=new DBConnection();
					conn=db.getSqlConnection();
					Statement st = conn.createStatement();
					String strSQLQuery = "INSERT into employee_details VALUES('"+EmpID+"','"+Name+"','"+Age+"','"+Sex+"','"+City+"','"+Department+"','"+Designation+"','"+Qualification+"')";
					st.executeUpdate(strSQLQuery);
					//System.out.println(strSQLQuery);
					insertStatus = true;
				}
			catch (SQLException s)
				{
				 	insertStatus = false;
					System.out.println("Not inserted,Check the file and move to error directory");
					System.out.println("Not executed!" + s.getMessage());
				}
			finally
				{
					conn.close();
				}
		 return insertStatus;
	}
}

class FileReadThreadForStudent implements Runnable
{
	static String source = "D:\\exercise\\Student";
	static String errorFolder = "D:\\exercise\\StudentError";
	static ArrayList<String> fileList = new ArrayList<String>();
	static ArrayList<String> al = new ArrayList<String>();
	public void run()
	{
	while(true)
	{
		String line = "";
		StringTokenizer st;
		String split = ",";
		String name;
		String age;
		String std;
		
		File Folder = new File(source);
		File files[];
		files = Folder.listFiles();
		if(files.length>0)
		{
			for(int i = 0;i<files.length;i++)
			{
				
			 String readFiles= files[i].getName();
			 fileList.add(readFiles);
			 System.out.println("ReadFileList : " + fileList);
			try
			{
			 FileInputStream fis = new FileInputStream(files[i]);
			 DataInputStream dis = new DataInputStream(fis);
			 BufferedReader buffer = new BufferedReader(new InputStreamReader(dis));
			 Scanner scanner = new Scanner(buffer);
			 boolean fileRepeat = false;
			 Set<String> fileSet = new HashSet<String>(fileList); 
			 if(fileSet.size() < fileList.size())
			 {      
				 fileRepeat = true;
				 System.out.println("File came again");
				 if(fileRepeat == true)
				 {
					 files[i].delete();
					 fis.close();
					 dis.close();
					 buffer.close();
				 }
			 }
			 while (scanner.hasNextLine())
			 {
			 line = scanner.nextLine();
			 st = new StringTokenizer(line,split); 
			 try
			 {
			 while(st.hasMoreTokens())
			 {
				name = st.nextToken();
				age = st.nextToken();
				std = st.nextToken();
				  al.add(0,name);
				  al.add(1,age);
			      al.add(2,std);
				System.out.println(name);
			}
			boolean insertStatus=Insertion();
			fis.close();
			dis.close();
			buffer.close();
			if(insertStatus == true)
			{
				try
				{
					 files[i].delete();
				}
				catch(Exception e)
				{
					e.printStackTrace();
				}
			}
			else if(insertStatus == false)
			{
				fis.close();
				dis.close();
				buffer.close();
				try
				{
						 System.out.println("ERROR-FILE");
					     String currentFile1 = files[i].getName();
						 File errorFile = new File(currentFile1);
					     File dir = new File("D:\\exercise\\StudentError");
				         errorFile.renameTo(dir);
				         files[i].renameTo(dir);
				}
				catch(Exception e)
				{
					e.printStackTrace();
				}
			}
		}
		catch(Exception e)
		{
			System.out.println(e.getMessage());
		}
		}
		}
		catch (FileNotFoundException fn)
		{
			fn.printStackTrace();
			System.out.println(fn.getLocalizedMessage());
		}
		catch (IOException e)
		{
			e.printStackTrace();
		}
			}
			try
			{
				Thread.sleep(15000);
			}
			catch(InterruptedException ie){}
	}
	}
	}
	
	public static boolean Insertion() throws SQLException //++++++INSERTION Method For Student Record++++++
	{
		    Connection conn = null;
			String Name = al.get(0);
			String Age = al.get(1);
			String Std = al.get(2);
			boolean insertStatus = false;
			try 
				{   
					DBConnection db=new DBConnection();
					conn=db.getSqlConnection();
					Statement st = conn.createStatement();
					String strSQLQuery = "INSERT into student_details VALUES('"+Name+"','"+Age+"','"+Std+"')";
					st.executeUpdate(strSQLQuery);
					//System.out.println(strSQLQuery);
					insertStatus = true;
				}
			catch (SQLException s)
				{
				 	insertStatus = false;
					System.out.println("Not inserted,Check the file and move to error directory");
					System.out.println("Not executed!" + s.getMessage());
				}
			finally
				{
					conn.close();
				}
		 return insertStatus;
	}
}

public class SeperateFileRead
{
	public static void main(String args[])
	{
		FileReadThread frt = new FileReadThread();
		Thread mainThread = new Thread(frt);
		mainThread.start();
		FileReadThreadForStudent frtfs = new FileReadThreadForStudent();
		Thread mainThread1 = new Thread(frtfs);
		mainThread1.start();
	}
}

Please suggest me..

[Tim Moores]

Optimize for what?

(I doubt anyone will go through 360 lines of code and make suggestions, by the way, but you never know.)

[Arun vel]

By this code I am doing the same function for two types of records..For that I have repeated the same logic twice in two classes..Other than the numner of parameters passed,there is no other difference between those two classes..
I want to know how use the same funcetionality but with different parameters..
Thus the code will be optimized..
If you see the code correctly,you will find that the same logic is repeated twice in two classes..

[Jeff Verdegan]

Arun kumar.ck wrote:By this code I am doing the same function for two types of records..For that I have repeated the same logic twice in two classes..Other than the numner of parameters passed,there is no other difference between those two classes..
I want to know how use the same funcetionality but with different parameters..
Thus the code will be optimized..
If you see the code correctly,you will find that the same logic is repeated twice in two classes..

So what specific problem are you having doing that?

Again, that's a lot of code to ask anyone to read. I'm certainly not going to read it. Perhaps if you could condense it down to just enough code to show the relevant bits that are giving you trouble...

[Arun vel]

Okay..Now I wil explain what I need to know..
I have created two classes(Thread class) to read two types of records(Textfiles-Both have different number of values)..
Both classes does same process but with two type of files(Textfiles-Both have different number of values)..Both class looks same as one..Both class uses same insertion method to insert the textfile data into the database..
Now I want to know,Instead of doing this can we create only one class(Thread class) to do both the functions..
I cant condense it because there is nothing rather than the same class is repeated twice..

[Jeff Verdegan]

Arun kumar.ck wrote:I have created two classes(Thread class) to read two types of records(Textfiles-Both have different number of values)..
Both classes does same process but with two type of files(Textfiles-Both have different number of values)..Both class looks same as one..Both class uses same insertion method to insert the textfile data into the database..

Okay, so both classes are the same. So get rid of one class and just use the remaining one for both tasks.

Also, you shouldn't extend Thread. You should implement Runnable instead.

I cant condense it because there is nothing rather than the same class is repeated twice..

I guarantee you it's possible to condense it.

[Winston Gutkowski]

Arun kumar.ck wrote:Now I want to know,Instead of doing this can we create only one class(Thread class) to do both the functions.

Yes. The question is: do you want to?

Personally, I think I'd be creating classes (Student? Exercise?) for the objects that you want to read in, and put the code for actually reading them in there.

I cant condense it because there is nothing rather than the same class is repeated twice..

As Jeff said...

Winston

[Koen Aerts]

Jeff Verdegan wrote:Also, you shouldn't extend Thread. You should implement Runnable instead.

Why is that better? The only advantage I see with the "implements" approach is that you can implement multiple interface, but extend from only 1 class. Are there any other benefits over the "implements" approach?

[Tim Moores]

See https://coderanch.com/how-to/java/ExtendingThreadVsImplementingRunnable for some discussion. Using Callable or Future may be even better, depending on what you're trying to achieve.

[Koen Aerts]

Tim Moores wrote:See https://coderanch.com/how-to/java/ExtendingThreadVsImplementingRunnable for some discussion. Using Callable or Future may be even better, depending on what you're trying to achieve.

Thanks; that makes sense. To be honest I've never used Executor and Callable before but it's definitely something to look into next opportunity.

[Jeff Verdegan]

Koen Aerts wrote:

Jeff Verdegan wrote:Also, you shouldn't extend Thread. You should implement Runnable instead.

Why is that better?

Because it more properly reflects your design. We're not creating a specialized type of Thread; we're creating a task to be run in its own thread.

Granted, it is convenient for anonymous inner classes to be able to skip the Runnable layer, and I'm guilty of doing it, but I still consider it bad design that Thread even implements Runnable in the first place.

[Arun vel]

Thanks to all for the suggestions..I have done that..
The problem with me was I know the way to do,but dont know how o do..
Now my application is working fine..
Also I am not that much explainatory..So only I am not able to explain myself..