• Post Reply Bookmark Topic Watch Topic
  • New Topic

Can you help me finding weak points in class design?  RSS feed

 
Ivan Ivanovskis
Greenhorn
Posts: 3
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hello good day to all Java Developers Can you find problems with my class diagram?

http://dox.abv.bg/files/fdw?eid=84554512

Maybe it is hard without knowing the purpose of all that classes but I believe that here people know so much that can help without even looking at the actual code what it is doing.

Cheers
 
Jayesh A Lalwani
Rancher
Posts: 2762
32
Eclipse IDE Spring Tomcat Server
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Yeah we are good. However, not many of us know Bulgarian
 
Ivan Ivanovskis
Greenhorn
Posts: 3
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Jayesh A Lalwani wrote:Yeah we are good. However, not many of us know Bulgarian


Wow, sorry I guess that the link is expired.

This is the picture which I have uploaed:



now will not expire. Thank you
 
Paul Clapham
Sheriff
Posts: 22835
43
Eclipse IDE Firefox Browser MySQL Database
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
No good, we are still being redirected to the hosting company's home page.
 
Campbell Ritchie
Marshal
Posts: 56576
172
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
And welcome to the Ranch

Please post your code in code tags on this website.
 
Ivan Ivanovskis
Greenhorn
Posts: 3
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
 
John Jai
Rancher
Posts: 1776
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Could you please also elaborate on the functionality of this project?
 
Campbell Ritchie
Marshal
Posts: 56576
172
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
The class Item has a getText method and no text field. Why?
Why does NPC appear to extend Item, and have a Map with Items in? Why have you called it NPC?
Why are you returning the Map? Why are you giving those methods HashMap rather than Map as a return type?
Your methods and constructors all appear to be out of order on some diagrams.
Why have you got a Map and are adding Items with only a single parameter; is it a K or a V?
Why are you passing Strings to the isLocked and lock methods?
Why have you called an interface Ixxx? That is a C# convention, not a Java™ convention.
Why is the public interface of Player so large?

That should keep you busy for the next ten minutes.
 
Jayesh A Lalwani
Rancher
Posts: 2762
32
Eclipse IDE Spring Tomcat Server
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Why can;t your NPC do things that the Player can? An NPC should be able to do everything a PC (player character). The only differrence between a NPC and a PC should be that the NPC is controlled by the AI. I would change this to jabe a Character interface and PlayerCharacter and NonPlayerCharacter should implement it. NonPlayerCharacter should provide "hooks" that will allow AI to control it, and the PlayerCharacter should have hooks to have the player control it.
 
Don't get me started about those stupid light bulbs.
  • Post Reply Bookmark Topic Watch Topic
  • New Topic
Boost this thread!