Win a copy of Programmer's Guide to Java SE 8 Oracle Certified Associate (OCA) this week in the OCAJP forum!
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

Can this design be refactored to a better Way?

 
Naresh Shanmugam
Ranch Hand
Posts: 86
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hi,

I have three classes, like Batch, Transaction and Check.

Batch can be identified by using batchId and it has list of transaction
Transaction can be identified by using batchId and tranId, it has list of checks
Check can be identified by using batchId, tranId and checkId.




Is this a better way to design this or is there a better way to redesign these 3 classes, because even though "Transaction" class is part of "Batch" class we have "batchId" attribute in "Transaction" class? Similarly we have "batchId" and "tranId" in "Check" class. Please provide your inputs
 
Sadanandam Kurapati
Ranch Hand
Posts: 78
Eclipse IDE Java Tomcat Server
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hi,

Few questions before we come to any conclusion on design?
  • Does Check object exists without Transaction?
  • Similarly does Transaction object exists without any Batch?


  • If your answers is no, then why do you need batchId in Transaction and Check classes and also tranId in Check class. So if you want to enforce a rule that Check does not exist without Transaction, then you should define a private constructor in Check(so that no once create a check independently and it will be always created using Transaction) and initiate the List<Check> checkList with Transaction constructor, similarly Batch.


     
    Naresh Shanmugam
    Ranch Hand
    Posts: 86
    • Mark post as helpful
    • send pies
    • Quote
    • Report post to moderator
    Transaction object does not exist without batch, Similarly check object does not exist with out transaction.
    We need batchId in Transaction because, a transaction is identified by batchId and tranId together. Though batch has list of transactions, some times when need to send one particular transaction object to other method for some processing, that time we may need batchId too, so we have created batchId in "Transaction" class. Do you think that this is not a proper approach?
     
    Victor M. Pereira
    Ranch Hand
    Posts: 50
    • Mark post as helpful
    • send pies
    • Quote
    • Report post to moderator
    How do you search for these objects?

    Do you search them through transactions or batches?

    Depending on your answer you might or might not remove the two-way into one-way.

    And from this point of view, the check class seems to be an aggregate from transaction, so is there really a need to have batchId and tranId?
    Can there be several checkDate of the batchId in the same day?

    Is there a real need to have a history of checks or would saving the last done check be enough?

    So in reality, I don't have enough information to know if you can do two-way directionality into one-way and do an inline class refactoring.
     
    • Post Reply
    • Bookmark Topic Watch Topic
    • New Topic