database configuration file

[Migrated From Jforum.net]

From a user's point, a single file to configure database access is easier to maintain. DBMS specific settings will be stored using the property files already available, but properties used by all JDBC drivers are stored in another file. The user only have to change this file. Also, I added a property for the database name, which is hardcoded by now.

/WEB-INF/config/database.properties:

# JForum database configuration options

database.driver.name=mysql
#database.driver.name=postgresql

database.connection.host=localhost
#DBMS defaults for the port are: mysql - 3306; postgresql - 5432
database.connection.port=3306
#database.connection.port=5432
database.name=jforum
database.connection.username=root
database.connection.password=root

database.connection.pool.min = 10
database.connection.pool.max = 50
database.connection.pool.timeout = 120

#internals - do not edit
database.driver.config=${config.dir}/database/${database.driver.name}/${database.driver.name}.properties
sql.queries.driver=${config.dir}/database/${database.driver.name}/${database.driver.name}.sql
sql.queries.generic=${config.dir}/database/generic/generic_queries.sql

/WEB-INF/config/database/mysql/mysql.properties

dao.driver=net.jforum.drivers.mysql.DataAccessDriver
database.connection.driver = com.mysql.jdbc.Driver
database.connection.string = jdbc:mysql://${database.connection.host}:${database.connection.port}/${database.name}?user=${database.connection.username}&password=${database.connection.password}&autoReconnect=true&useUnicode=${dbunicode}&characterEncoding=${dbencoding}&autoReconnectForPools=true&useNewIO=true
dbencoding=utf8
dbunicode=true

/WEB-INF/config/database/postresql/postgresql.properties

dao.driver=net.jforum.drivers.postgresql.DataAccessDriver
sql.file=database/postgresql/postgresql.sql
database.connection.driver = org.postgresql.Driver
database.connection.string = jdbc:postgresql://${database.connection.host}:${database.connection.port}/${database.name}?user=${database.connection.username}&password=${database.connection.password}

The database specific section in /WEB-INF/config/SystemGlobals.properties must be removed. A single property will be added instead:

database.config=${config.dir}/database.properties

changes in src/net/jform/ConfigPool.java

...
private ConnectionPool() throws IOException, SQLException {
  SystemGlobals.loadAdditionalDefaults(SystemGlobals.getValue("database.config"));
  SystemGlobals.loadAdditionalDefaults(SystemGlobals.getValue("database.driver.config"));
  String driver = SystemGlobals.getValue("database.connection.driver");
...

[originally posted on jforum.net by squizzz]