Bug fix for deleting posts

[Migrated From Jforum.net]

Hi Rafael,
The 2.0.2 version has a bug on deleting more than 2 posts of 1 topic. It works well if I delete post from the last to the first. But if I delete from the first one. Then it will show a post not found error. According to your post https://coderanch.com/t/574454 , the code lack the check of setFirstPostId() and getMinPostId() in TopicModel.java.
I have fixed it up. Here is my work around.

:arrow: In net/jforum/model/TopicModel.java add two method declaraions

	/**
	 * Sets the ID of the first post of the topic
	 * 
	 * @param topicId Topic ID
	 * @param postId Post ID
	 * @throws Exception
	 */
	public void setFirstPostId(int topicId, int postId) throws Exception;

	/**
	 * Gets the first post id associated to the topic
	 * 
	 * @param topicId The topic id
	 * @throws Exception
	 */
	public int getMinPostId(int topicId) throws Exception;

:arrow: In net/jforum/drivers/generic/TopicModel.java add two method implementations:

	/** 
	 * @see net.jforum.model.TopicModel#setFirstPostId(int, int)
	 */
	public void setFirstPostId(int topicId, int postId) throws Exception 
	{
		PreparedStatement p = JForum.getConnection().prepareStatement(SystemGlobals.getSql("TopicModel.setFirstPostId"));
		p.setInt(1, postId);
		p.setInt(2, topicId);
		p.executeUpdate();
		p.close();
	}

	/** 
	 * @see net.jforum.model.TopicModel#getMinPostId(int)
	 */
	public int getMinPostId(int topicId) throws Exception 
	{
		int id = -1;
		
		PreparedStatement p = JForum.getConnection().prepareStatement(SystemGlobals.getSql("TopicModel.getMinPostId"));
		p.setInt(1, topicId);
		
		ResultSet rs = p.executeQuery();
		if (rs.next()) {
			id = rs.getInt("post_id");
		}
		
		rs.close();
		p.close();
		
		return id;
	}

:arrow: in net/jforum/view/PostAction.java modify the delete() method:

        int maxPostId = tm.getMaxPostId(p.getTopicId());
        if (maxPostId > -1) {
            tm.setLastPostId(p.getTopicId(), maxPostId);
        }
        
        // add the following code
        int minPostId = tm.getMinPostId(p.getTopicId());
        if (minPostId > -1) {
        	  tm.setFirstPostId(p.getTopicId(), minPostId);
        }

:arrow: add two sql script to WEB-INF/classes/config/database/generic_queries.sql

TopicModel.setFirstPostId = UPDATE jforum_topics SET topic_first_post_id = ? WHERE topic_id = ?
TopicModel.getMinPostId = SELECT MIN(post_id) AS post_id FROM jforum_posts WHERE topic_id = ?

That's all. Add this fix to the CVS please.
[originally posted on jforum.net by andowson]

[Migrated From Jforum.net]

Ok.. looks reasonable.
I'll put some new buttons in the end of the page ( as phpbb does ) for topic moving, deleting etc..

Rafael
[originally posted on jforum.net by Rafael Steil]

[Migrated From Jforum.net]

Thanks, I added the code to cvs.

Now, here is a conceptual question: I was thinking of removing the entire topic when the first message was deleted. It has pros and cons. What do you think?

Rafael
[originally posted on jforum.net by Rafael Steil]

[Migrated From Jforum.net]

Hi Rafael,
In my opinion, removing the entire topic when the first message was deleted this function could be assign to the forum administrator. Then he/she could clean up a thread more quickly and easily.

And for normal users, they should be restricted to only delete his posts.

Sometimes, there could be some good idea follow up the first post. For example, at the first, one guy say that how about have a web mail integration with private message in this forum. Then we could send private message through email or just leave it at the forum. In the following up discussion, there could be someone proposes a way to implement it or more improved idea, ex. integrate with SMS, maybe has commercial potential. If the first guy delete his post to keep his idea privately. Then the following posts should be kept. Maybe we cound just delete the text of his posts or just show "Post is deleted" on the original position. And the reader would know that there used to be a (first) post, but later deleted.

So, I suggest you implement them in two seperate button, like a deletePost and deleteTopic. Only admin user can use deleteTopic.
[originally posted on jforum.net by andowson]