cannot delete a post on CVS version

[Migrated From Jforum.net]

Hi Rafael,
I can't delete a post on the CVS vesion. It works fine on version 2.0.2.
I got the following exception:

01:30:46,426 ERROR [ExceptionWriter     ] java.lang.reflect.InvocationTargetException
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:585)
        at net.jforum.Command.process(Unknown Source)
        at net.jforum.JForum.service(Unknown Source)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:214)
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
        at org.apache.catalina.valves.FastCommonAccessLogValve.invoke(FastCommonAccessLogValve.java:481)
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
        at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:300)
        at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:383)
        at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:743)
        at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:675)
        at org.apache.jk.common.SocketConnection.runIt(ChannelSocket.java:866)
        at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
        at java.lang.Thread.run(Thread.java:595)
Caused by: java.lang.NoSuchMethodError: net.jforum.repository.TopicRepository.loadMostRecentTopics()V
        at net.jforum.view.forum.common.TopicsCommon.deleteTopic(Unknown Source)
        at net.jforum.view.forum.PostAction.delete(Unknown Source)
        ... 23 more

[originally posted on jforum.net by andowson]

[Migrated From Jforum.net]

It looks like your jforum is not correctly compiled:

Caused by: java.lang.NoSuchMethodError: net.jforum.repository.TopicRepository.loadMostRecentTopics()V

Rafael
[originally posted on jforum.net by Rafael Steil]

[Migrated From Jforum.net]

I use ant to build jforum. My JDK is Sun J2SE 5.0
The build process is as follows:
1. downloaded all the code into a working directory
2. execute ant under the working directory
3. Stop Tomcat(my setting will delete the stuff under Tomcat's "work" directory also)
4. go to the production webapp's WEB-INF/classes directory
5. delete the net directory including all of its subdirectory
6. copy the newly build net directory back
7. Start Tomcat

I checked the TopicRepository.java in both two versions.
In CVS, it's

	/**
	 * Add recent topics to the cache
	 */
	public static List loadMostRecentTopics() throws Exception
	{
		TopicModel tm = DataAccessDriver.getInstance().newTopicModel();
		int limit = SystemGlobals.getIntValue(ConfigKeys.RECENT_TOPICS);
		
		List l = tm.selectRecentTopics(limit);
		cache.add(FQN, RECENT, new LinkedList(l));
		
		return l;
	}

and in version 2.0.2 was:

	public static void loadMostRecentTopics() throws Exception
	{
		TopicModel tm = DataAccessDriver.getInstance().newTopicModel();
		recentTopicsList = new LinkedList();
		
		int limit = SystemGlobals.getIntValue(ConfigKeys.RECENT_TOPICS);
		List l = tm.selectRecentTopics(limit);
		for (Iterator iter = l.iterator(); iter.hasNext(); ) {
			Topic t = (Topic)iter.next();
			
			recentTopicsList.addLast(t);
		}		
	}

The return type changed from void to List. Is this the hint for the error?
[originally posted on jforum.net by andowson]

[Migrated From Jforum.net]

OK...The problem is removed.
I solve it by first comment out the TopicRepository.loadMostRecentTopics(); in TopicsCommon.java
After recompiling, it works.
Then I remove the comment. Recompiling again.
It still works...
So...the code is OK. It should be my environment's problem.

[originally posted on jforum.net by andowson]

[Migrated From Jforum.net]

I found a real bug now.
In TopicsCommon.java

	public static void deleteTopic(int topicId) throws Exception
	{
		TopicModel tm = DataAccessDriver.getInstance().newTopicModel();
		ForumModel fm = DataAccessDriver.getInstance().newForumModel();
		
		Topic topic = new Topic();
		topic.setId(topicId);
		tm.delete(topic);

		// Updates the Recent Topics if it contains this topic
		TopicRepository.popTopic(topic);
		TopicRepository.loadMostRecentTopics();

		tm.removeSubscriptionByTopic(topicId);
		fm.decrementTotalTopics(topicId, 1);
	}

should be:

	public static void deleteTopic(int topicId, int forumId) throws Exception
	{
		TopicModel tm = DataAccessDriver.getInstance().newTopicModel();
		ForumModel fm = DataAccessDriver.getInstance().newForumModel();
		
		Topic topic = new Topic();
		topic.setId(topicId);
		tm.delete(topic);

		// Updates the Recent Topics if it contains this topic
		TopicRepository.popTopic(topic);
		TopicRepository.loadMostRecentTopics();

		tm.removeSubscriptionByTopic(topicId);
		fm.decrementTotalTopics(forumId, 1);
	}

In PostAction.java

			// Ok, all posts were removed. Time to say goodbye
			TopicsCommon.deleteTopic(p.getTopicId());

should be:

			// Ok, all posts were removed. Time to say goodbye
			TopicsCommon.deleteTopic(p.getTopicId(), p.getForumId());

[originally posted on jforum.net by andowson]

[Migrated From Jforum.net]

Thanks for fixing the code.

Rafael
[originally posted on jforum.net by Rafael Steil]