reason for createZip and createClassesJar being commented out

[Migrated From Jforum.net]

Why are those two targets commented out in build.xml?

also.. good work on SSO.

I will using it to intergrate jforum with my website. I found it easier to work with than mvnforum, which I am using currently.

I also have some extentions I want to propose in the SSO code.

When SSO creates a new user, I would like it to use a good email address and good password. Email would be needed for people to watch topics and such. I would like to send it through a session or request attribute.

I have made following changes:
SystemGlobals.properties:
sso.password.attribute = password
sso.email.attribute = email
sso.default.email = sso@user
sso.default.password = sso

ControllerUtils.java:
private void checkSSO(UserSession userSession).......

HttpSession session = JForum.getRequest().getSession(true);
String password =
(String)session.getAttribute(SystemGlobals.getValue(ConfigKeys.SSO_PASSWORD_ATTRIBUTE));
if ( password == null ) 
    password = SystemGlobals.getValue(ConfigKeys.SSO_DEFAULT_PASSWORD);
String email =
(String)session.getAttribute(SystemGlobals.getValue(ConfigKeys.SSO_EMAIL_ATTRIBUTE));
if ( email == null )  
    email = SystemGlobals.getValue(ConfigKeys.SSO_DEFAULT_EMAIL);;
    if (user == null) {
    // Is a new user for us. Register him
    user = new User();
    user.setUsername(username);
    user.setPassword(password);
    user.setEmail(email);
    user.setActive(1);
					
    udao.addNew(user);

and I added the Keys to ConfigKeys.java file.

I have not tested it yet, but it should work.

How can we included this in jforum?

Regards,
Paul


[originally posted on jforum.net by subpaul]

[Migrated From Jforum.net]

createZip / createJar are commented out because they aren't working correctly (at least weren't).

About the SSO, I think your comments make sense. Could you please add it to JIRA ( http://www.jforum.net/jira )? you can just link to this topic.

Nice to hear you've found SSO support good and easy to use. I havent' tested it with LDAP yet.

Rafael
[originally posted on jforum.net by Rafael Steil]

[Migrated From Jforum.net]

Done..

http://www.jforum.net/jira/browse/JF-309

after testing.. should I attach files here?

Paul

[originally posted on jforum.net by subpaul]