Chinese Attached filename can't be shown

[Migrated From Jforum.net]

I found that Chinese attached filename can't be shown probably. (see the attached jpg)
I have also created an issue (JF-327) in the isue tracking system.

[originally posted on jforum.net by willchoy]

[Migrated From Jforum.net]

How to solve?
[originally posted on jforum.net by Anonymous]

[Migrated From Jforum.net]

Open templates/default/post_form.htm, search for the <form> tag and remove the attribute

accept-charset="${encoding}"

Rafael
[originally posted on jforum.net by Rafael Steil]

[Migrated From Jforum.net]

But I cannot find this attribute
Version of Jforum i used is 2.1.4
[originally posted on jforum.net by Anonymous]

[Migrated From Jforum.net]

hhmm.. right..

I'll take a closer look.

Rafael
[originally posted on jforum.net by Rafael Steil]

[Migrated From Jforum.net]

I got this problem, too.
I've tested it on the 2.1.5 cvs version.
How to fix it?
[originally posted on jforum.net by andowson]

[Migrated From Jforum.net]

OK, I got this problem fixed now.
Modify src/net/jforum/ActionServletRequest.java

else if (("POST").equals(requestType)) {
    isMultipart = ServletFileUpload.isMultipartContent(new ServletRequestContext(superRequest));
    if (isMultipart) {
        String tmpDir = SystemGlobals.getApplicationPath() + "/" + SystemGlobals.getValue(ConfigKeys.TMP_DIR);
        ServletFileUpload upload = new ServletFileUpload(new DiskFileItemFactory(100 * 1024, new File(tmpDir)));
        //  Fixed for Chinese filename                                
        upload.setHeaderEncoding(encoding); // <== add this line
        try {

Now, there's only one little problem remained: How to make the download filename displayed as it originally uploaded not a random coded string like CAX0AC.
[originally posted on jforum.net by andowson]

[Migrated From Jforum.net]

I found a solution from MVNForum's Chinese support board.
:arrow: First, add a method toUtf8String to src/net/jforum/view/forum/PostAction.java

public static String toUtf8String(String s) {
    StringBuffer sb = new StringBuffer();

    for (int i = 0; i < s.length(); i++) {
        char c = s.charAt(i);

        if ((c >= 0) && (c <= 255)) {
            sb.append(c);
        } else {
            byte[] b;

            try {
                b = Character.toString(c).getBytes("utf-8");
            } catch (Exception ex) {
                System.out.println(ex);
                b = new byte[0];
            }

            for (int j = 0; j < b.length; j++) {
                int k = b[j];

                if (k < 0) {
                    k += 256;
                }

                sb.append("%" + Integer.toHexString(k).toUpperCase());
            }
        }
    }

    return sb.toString();
}

:arrow: Secod, modify the downloadAttach() method
Change this line:

this.response.setHeader("Content-Disposition", "attachment; filename=\"" + a.getInfo().getRealFilename() + "\";");

into

this.response.setHeader("Content-Disposition", "attachment; filename=\"" + toUtf8String(a.getInfo().getRealFilename()) + "\";");

:arrow: Finally, recompile the source code and reload the class files.

Notice:
I've tried the other ways to do so, but they all failed.
So, you may skip trying these methods:

this.response.setHeader("Content-Disposition", "attachment; filename=\"" 
+ new String(a.getInfo().getRealFilename().getBytes(SystemGlobals.getValue(ConfigKeys.ENCODING)), "ISO-8859-1") + "\";");

this.response.setHeader("Content-Disposition", "attachment; filename=\"" 
+ java.net.URLEncoder.encode(a.getInfo().getRealFilename(), "UTF-8") + "\";");

OK, that's all.
[originally posted on jforum.net by andowson]

[Migrated From Jforum.net]

toUtf8String() can encode chinese filename for IE,but it don't work in Firefox.
In Firefox chinese filename is '%xx%xx...'
[originally posted on jforum.net by Anonymous]

[Migrated From Jforum.net]

Anonymous wrote:toUtf8String() can encode chinese filename for IE,but it don't work in Firefox.
In Firefox chinese filename is '%xx%xx...'

OK, the Firefox fix is as follows:
Edit src/net/jforum/view/forum/PostAction.java
modify the downloadAttach() method,

this.response.setHeader("Content-Disposition", "attachment; filename=\"" + ViewCommon.toUtf8String(a.getInfo().getRealFilename()) + "\";");
this.response.setContentLength((int)a.getInfo().getFilesize());

as follows:

if (this.request.getHeader("User-Agent").indexOf("Firefox") != -1) {
  this.response.setHeader("Content-Disposition", "attachment; filename=\"" + new String(a.getInfo().getRealFilename().getBytes(SystemGlobals.getValue(ConfigKeys.ENCODING)),
 SystemGlobals.getValue(ConfigKeys.DEFAULT_CONTAINER_ENCODING)) + "\";");
} else {
 this.response.setHeader("Content-Disposition", "attachment; filename=\"" + ViewCommon.toUtf8String(a.getInfo().getRealFilename()) + "\";");
}
this.response.setContentLength((int)a.getInfo().getFilesize());

[originally posted on jforum.net by andowson]