Attachment wrong filename encoding

[Migrated From Jforum.net]

Sorry, if you already fix this in developer version but at 2.1.4 we have problem with attachments filenames which include Polish special characters.

After some time we found soloution and below is patch for this issue:

diff -ur 2.1.4/src/net/jforum/ActionServletRequest.java patched/src/net/jforum/ActionServletRequest.java
--- 2.1.4/src/net/jforum/ActionServletRequest.java	2005-02-04 08:55:32.000000000 +0100
+++ patched/src/net/jforum/ActionServletRequest.java	2006-01-04 14:23:45.000000000 +0100
@@ -282,7 +282,9 @@
 			if (isMultipart) {
 			    String tmpDir = SystemGlobals.getApplicationPath() + "/" + SystemGlobals.getValue(ConfigKeys.TMP_DIR);
 				ServletFileUpload upload = new ServletFileUpload(new DiskFileItemFactory(100 * 1024, new File(tmpDir)));
-
+                // PLDG - filename fix
+                upload.setHeaderEncoding(SystemGlobals.getValue(ConfigKeys.ENCODING));
+
 				try {
 					List items = upload.parseRequest(superRequest);
 					for (Iterator iter = items.iterator(); iter.hasNext(); ) {
diff -ur 2.1.4/src/net/jforum/view/forum/PostAction.java patched/src/net/jforum/view/forum/PostAction.java
--- 2.1.4/src/net/jforum/view/forum/PostAction.java	2005-03-04 10:14:48.000000000 +0100
+++ patched/src/net/jforum/view/forum/PostAction.java	2006-01-05 08:37:03.000000000 +0100
@@ -45,6 +45,7 @@
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.OutputStream;
+import java.net.URLEncoder;
 import java.text.SimpleDateFormat;
 import java.util.Collections;
 import java.util.Date;
@@ -852,9 +858,25 @@
 		FileInputStream fis = new FileInputStream(filename);
 		OutputStream os = response.getOutputStream();
 
-		this.response.setContentType("application/octet-stream");
-		this.response.setHeader("Content-Disposition", "attachment; filename=\"" + a.getInfo().getRealFilename() + "\";");
-		this.response.setContentLength((int)a.getInfo().getFilesize());
+        this.response.setContentType("application/octet-stream");
+
+        /**
+         * PLDG HACK by Woo 
+         * UTF-8 Enconding 
+         */
+        String realName = URLEncoder.encode(a.getInfo().getRealFilename(),"UTF-8");
+        // Checking browser type
+        String browserType = this.request.getHeader("User-Agent");
+        String attachAttr = "attachment; filename*=";
+        // MSIE Hack - does not follows RFC 2184 :\
+        if (browserType != null && browserType.indexOf("MSIE") != -1){
+            attachAttr = attachAttr.replaceAll("\\*","");
+        }
+        
+        this.response.setHeader("Content-Disposition", attachAttr + realName );
+        /** End Of Hack */
+        
+        this.response.setContentLength((int)a.getInfo().getFilesize());
 		
 		byte[] b = new byte[4096];
 		int c = 0;

I'm sorry for not clean patch but we have also other changes in JForum
for tailoring it with out portal ...

Thanks for great soft :-)

Best regards,
�?ukasz Kwiek,
PLDG Develpoment Team member
[originally posted on jforum.net by Woo]

[Migrated From Jforum.net]

Well and there is patch to patch, sorry for that :\
After URLEncoder method the realName string:

String realName = URLEncoder.encode(a.getInfo().getRealFilename(),"UTF-8");

should have replaced all '+' characters to '%20':

        // Replace all URLencoded spaces as '+' to %20 
        realName = realName.replaceAll("\\+","%20");

PS.
Message preview does not work on this site (version?)

Error: AjaxUtils is not defined
Source code: http://www.jforum.net/templates/default/js/post.js
Row: 190

[originally posted on jforum.net by Woo]