Bug in ActionServletRequest

[Migrated From Jforum.net]

Hi all,

We use the apache module to integrate our tomcat running your forum. Unfortunately we were unable to connect to the forum. I don't wont to bore you with details. Here is the reason for the problem:

In ActionServletRequest there is:

if ((("GET").equals(requestType) 
                && ((superRequest.getQueryString() == null))) 
                &&  requestUri.endsWith(SystemGlobals.getValue(ConfigKeys.SERVLET_EXTENSION))) { ...

If used the the apache module

superRequest.getQueryString()

won't result in

null

but in an empty String.
This results not in an exception but only in one boring 404 - Header.

The fix is easy though:

if ((("GET").equals(requestType) 
                && ((superRequest.getQueryString() == null)||(superRequest.getQueryString().trim().length() == 0))) 
				&& requestUri.endsWith(SystemGlobals.getValue(ConfigKeys.SERVLET_EXTENSION))) {...

[originally posted on jforum.net by Eike]