Message posted notification link bug and the solution

[Migrated From Jforum.net]

I have already written once (unfortunately after the forum crash the message is gone), that the notification link does not work if there was more than 15 answers, and I see it is now fixed, but there is still two problems with this link. First problem is that it will always point to the one message before the last one. It is not a problem for most of the posts, but it does not work for the first reply in a new page. It will point to the last reply on one page before that. Here is what i have changed in order to fix it:

first in PostAction

if (!newTopic) 
{
	t.setTotalReplies(t.getTotalReplies() + 1);
	TopicsCommon.notifyUsers(t, topicDao);			
}

instead of

if (!newTopic) 
{
	TopicsCommon.notifyUsers(t, topicDao);			
	t.setTotalReplies(t.getTotalReplies() + 1);
}

the reason for that is that we need to increase the totalReplies before we call the notifyUsers, because we want to notify about the latest post that just came.

secondly it will not work exactly for the 15th (postPerPage) reply . in TopicSpammer there should be

if (topic.getTotalReplies() >= postsPerPage)

instead of

if (topic.getTotalReplies() > postsPerPage)

because if totalReplies is equal to postPerPage, it already goes to the new page. 15th reply is a 16th message in the topic.

best regards,

Marcin
[originally posted on jforum.net by marcinn]

[Migrated From Jforum.net]

Added to the cvs.

Thank you for the help!

Rafael
[originally posted on jforum.net by Rafael Steil]