Problem with path in e-mail notifications

[Migrated From Jforum.net]

It doesn't get the correct value for the starting index of a post if a post has multiple pages. That results in an invalid url being sent to the users.

It would be better to use a StringBuffer, but just as quick fix, this seems to do it.

--- net/jforum/util/mail/ForumSpammer.java     2006-02-27 21:20:52.000000000 -0500
+++ net/jforum/util/mail/ForumSpammer.java        2006-11-21 10:02:23.000000000 -0500
@@ -76,7 +76,7 @@
                String page = "";
                int postsPerPage = SystemGlobals.getIntValue(ConfigKeys.POST_PER_PAGE);
                if (topic.getTotalReplies() > postsPerPage) {
-                       page += (((topic.getTotalReplies() / postsPerPage)) * postsPerPage) + "/";
+                       page += "" + (((topic.getTotalReplies() / postsPerPage)) * postsPerPage) + "/";
                }

                String forumLink = ViewCommon.getForumLink();
--- net/jforum/util/mail/TopicSpammer.java     2006-02-27 22:10:48.000000000 -0500
+++ net/jforum/util/mail/TopicSpammer.java        2006-11-21 10:02:17.000000000 -0500
@@ -75,7 +75,7 @@
                String page = "";
                int postsPerPage = SystemGlobals.getIntValue(ConfigKeys.POST_PER_PAGE);
                if (topic.getTotalReplies() > postsPerPage) {
-                       page += (((topic.getTotalReplies() / postsPerPage)) * postsPerPage) + '/';
+                       page += "" + (((topic.getTotalReplies() / postsPerPage)) * postsPerPage) + '/';
                }

                String forumLink = ViewCommon.getForumLink();

[originally posted on jforum.net by bcc]