topics pagination is incorrect, maybe a bug

[Migrated From Jforum.net]

when I'm testing topics pagination, I get a incorrect result. because cache existing, when I post new topic, the total topics doesn't increase. result in I couldn't browse all topics. I fixed it by addding a piece of code in the end of ForumRepository.java::public static synchronized void updateForumStats(Topic t, User u, Post p).

	public static synchronized void updateForumStats(Topic t, User u, Post p)
	{
		
		String f = Integer.toString(t.getForumId());
		
		if (((Map)cache.get(FQN, RELATION)).containsKey(f)) {
			Forum forum = getForum(t.getForumId());

			SimpleDateFormat df = new SimpleDateFormat(SystemGlobals.getValue(ConfigKeys.DATE_TIME_FORMAT));
		
			LastPostInfo lpi = forum.getLastPostInfo();
			
			if (lpi == null) {
				lpi = new LastPostInfo();
			}
			
			lpi.setPostId(p.getId());
			lpi.setPostDate(df.format(p.getTime()));
			lpi.setPostTimeMillis(p.getTime().getTime());
			lpi.setTopicId(t.getId());
			lpi.setTopicReplies(t.getTotalReplies());
			lpi.setUserId(u.getId());
			lpi.setUsername(u.getUsername());
			
			forum.setLastPostInfo(lpi);
			
			if (t.getTotalReplies() == 0) {
				forum.setTotalTopics(forum.getTotalTopics() + 1);
			}
			else {
				forum.setTotalPosts(forum.getTotalPosts() + 1);
			}
			
			Category c = retrieveCategory(forum.getCategoryId());
			c.reloadForum(forum);
			
			refreshCategory(c);			
		}
		//synchronize topictotal cache if it's new topic
		try {
			if(t.getFirstPostId() == t.getLastPostId()){
				int forumId = t.getForumId();
				int total;
				total = getTotalTopics(forumId)+1;
				cache.add(FQN_TOTAL_TOPICS, Integer.toString(forumId), new Integer(total));
			}
		} catch (Exception e) {
			logger.error(e);
		}
	}

[originally posted on jforum.net by maxchen]

[Migrated From Jforum.net]

btw, I use 2.1.6. otherwise, when deleteing topic, the topics pagination is incorrect,too.
[originally posted on jforum.net by maxchen]

[Migrated From Jforum.net]

About delete topic. I fix it by add a line code to PostAction.java::public void delete() throws Exception.

insert this

ForumRepository.getTotalTopics(p.getForumId(), true);

into PostAction.java 1267 line.


[originally posted on jforum.net by maxchen]