Exception in 2.1.6 when uploaded file size is greater than the maxSize

[Migrated From Jforum.net]

I have been using 2.1.6 comfortably but have not been able to use the avatar feature due to multiple reasons.
First when i uploaded an avatar, there was no size check happening at fileUploadBase.java. So as a debug, i tried to set sizeMax property before upload. Now that is happening, but the SizeLimitExceededException exception that is thrown after the sizemax is hecked, s not handled anywhere, and as a result i get the error page. Should i revert the sizeMax setting that i have done. if yes, when does the size comparison actually happen, so that i can aviod users from uploading megabytes of objects, thus making my app heavy.

thanx in advance!
~pankaj

[originally posted on jforum.net by pankajvermani]

[Migrated From Jforum.net]

I guess you're getting a NullPointerException, right? To fix that, create a directory named "tmp" in the root directory of your context and give it full write permissions

Rafael
[originally posted on jforum.net by Rafael Steil]

[Migrated From Jforum.net]

Hi Rafael,

Its not the tmp folder issue. I have both tmp and upload created with the adequate persmissions. What i saw was that there is a code in class FileUploadBase:

if (sizeMax >= 0 && requestSize > sizeMax) {
            throw new SizeLimitExceededException(
                "the request was rejected because "
                + "its size exceeds allowed range");
        }

However this sizeMax is not set (and is -1), so there's no size limit being checked. When i set this explicitly, the exception could not be handled gracefully, and i obviously received the error page.

I finally figured out the solution at my end. Now i'm checking the filesize not at this point but at AttachmentCommon, by doing a fileItem.get() and then checking the bytes. Dont knwo how graceful a solutiont hat is, but the application is behaving fine.

Regards
[originally posted on jforum.net by pankajvermani]

[Migrated From Jforum.net]

Could you please post the changed code here?

Thank you

Rafael
[originally posted on jforum.net by Rafael Steil]

[Migrated From Jforum.net]

in UserCommon, following code has been added:

	        		String fileName = MD5.crypt(Integer.toString(u.getId()));
		FileItem item = (FileItem)JForumExecutionContext.getRequest().getObjectParameter("avatar");
		UploadUtils uploadUtils = new UploadUtils(item);
		
		//Pankaj:Check file format and file size. in case of errors, throw exception
		//test if the file is image format
        if (item.get() != null && item.get().length > 0) {
            if (item.get().length < 12 || !ImageProcessor.isSupportedFile(item.get())) {
				throw new BadExtensionException(I18n.getMessage("User.avatarFormatUnknown", 
						new String[] { uploadUtils.getExtension() }));
            } 
        }
        
        //file size
        if (item.get() != null && item.get().length > 0) {
            if (item.get().length > SystemGlobals.getIntValue(ConfigKeys.AVATAR_MAX_SIZE_IN_KB)*1024) {
				throw new BadExtensionException(I18n.getMessage("User.avatarSizeExceeded", 
						new String[] { uploadUtils.getExtension() }));
            } 
        }

this is after I included a few util files (the ImageProcessor as mentioned) which figure out if the extension for the avatar is a valid one. The same extention check has been added to AttachmentCommon as well inside the loop for each FileItem to be uploaded.
[originally posted on jforum.net by pankajvermani]