smileys not rendering after 2.1.8 upgrade

[Migrated From Jforum.net]

I'm using a very slightly customized version. I upgraded from 2.1.7b3 to 2.1.8 and now the smileys render as

<img border="0">

The emoticons apear fine when composing a new message, but do not appear in the preview or when the message is posted.

Any thoughts on are appreciated?
[originally posted on jforum.net by skipwalker]

[Migrated From Jforum.net]

I found the solution to my problem. I put a bunch of system outs in the PostCommon and SafeHtml to trace where the img src was being removed. It turns out it was being removed by SafeHtml.ensureAllAttributesAreSafe().

The code was considering the "src" attribute in the img tag for the smilie unsafe as it is a relative link rather than a fully qualified url. This was apparently due to the fact that the configuration preference "html.links.allow.relative" is false by default.

# Allow or not relative links in the messages. If set to true, 
# links starting with / are allowed, otherwise it should start
# with the values defined in the key html.links.allow.protocols
html.links.allow.relative = false

Setting this value to true in SystemGlobals.properties solved my problem.


[originally posted on jforum.net by skipwalker]