GenericUserDAO selectAll() method

[Migrated From Jforum.net]

i don't know if this is on purpose
but when you call GenericUserDAO.selectAll(int startFrom, int count)
this function will generate a List of users but not all the field will be initialized!

and that is because the query you used (in generic_qeuries.sql) is

UserModel.selectAll = SELECT user_email, user_id, user_posts, user_regdate, username, deleted, user_karma, user_from, \
	user_website, user_viewemail FROM jforum_users ORDER BY user_id

so actual most member fields of User class will left uninitialized (such as icq , avatar, aim , yim and many more...)
maybe you should change your query so it will select everything about the user?
[originally posted on jforum.net by pavel_twr]

[Migrated From Jforum.net]

and i just noticed that the next method

	protected List processSelectAll(ResultSet rs) throws SQLException
	{
		List list = new ArrayList();

		while (rs.next()) {
			User u = new User();

			u.setEmail(rs.getString("user_email"));
			u.setId(rs.getInt("user_id"));
			u.setTotalPosts(rs.getInt("user_posts"));
			u.setRegistrationDate(new Date(rs.getTimestamp("user_regdate").getTime()));
			u.setUsername(rs.getString("username"));
			u.setDeleted(rs.getInt("deleted"));
			KarmaStatus karma = new KarmaStatus();
			karma.setKarmaPoints(rs.getInt("user_karma"));
			u.setKarma(karma);
			u.setFrom(rs.getString("user_from"));
			u.setWebSite(rs.getString("user_website"));
			u.setViewEmailEnabled(rs.getInt("user_viewemail") == 1);

			list.add(u);
		}

		return list;
	}

which is called to process the data retrieved with the above query,
is completely ignores the other field mentioned before.
so even if the query changed , no effect will be taken.
[originally posted on jforum.net by pavel_twr]

[Migrated From Jforum.net]

That's because we don't need all user field in the respective screens.

But for all purposes, JForum3 will have the full user information.

Rafael
[originally posted on jforum.net by Rafael Steil]