Private message count not filled in when using SSO

[Migrated From Jforum.net]

When logging in using SSO the jforum code uses

User GenericUserDAO.selectByName(String username)

instead of

User GenericUserDAO.selectById(int userId)

to get the User object. (called from SSOUtils.userExists, ControllerUtils.refreshSession)

selectByName does not fill in the private message count

u.setPrivateMessagesCount(rs.getInt("private_messages"));

and therefore the text 'New Private Messages: (X)' does not show up in the forum header.

(note that it also doesn't get the user groups, is that bad?)

Can this be fixed?
[originally posted on jforum.net by jrouwe]

[Migrated From Jforum.net]

I've hacked GenericUserDAO:

	public User selectByName(String username)
	{
		PreparedStatement p = null;
		ResultSet rs = null;
		try {
			// Jorrit: Patched query to only select id from users table
			p = JForumExecutionContext.getConnection().prepareStatement("SELECT user_id FROM jforum_users WHERE LOWER(username) = LOWER(?)");
			p.setString(1, username);

			rs = p.executeQuery();

			if (rs.next()) {
				// Jorrit: Patched to redirect to selectById
				int id = rs.getInt("user_id");
				return selectById(id);
			}

			return null;
		}
		catch (SQLException e) {
			throw new DatabaseException(e);
		}
		finally {
			DbUtils.close(rs, p);
		}
	}

(see added comments)

This fixes the bug. It would be nice if this was fixed in a general release too.

(note that I hacked the SQL string straight into the code, but it needs to be changed in the generic_queries.sql file)
[originally posted on jforum.net by jrouwe]