Bad operand types for binary operator?

[Brian Mart]

Hi,
I am working on a program to make a program in which the user plays craps. I know there are more problems, as this is a work in progress, but first I need to complete public static boolean play before I can move forward. When I try to compile, I get an error message that says "bad operand types forbinary '||' first type: int; second type: boolean" while the compiler highlights "|| result ==11" what does this error message mean and can someone point me in the right direction of how to fix it? Or is it a simple fix that I am missing? Any help is GREATLY appreciated. I have banging my head on the wall over this one for a couple hours now.

import java.util.*;

public class Craps
{/*
  static Scanner console = new Scanner(System.in);
 public static void main(String [] args)
 {
   double input;  
   Scanner console = new Scanner(System.in);
   Scanner scan = new Scanner(System.in);
   System.out.print("Do you want to play craps? Y/N: ");
   String playResponse = scan.next();  
     if (playResponse == N || n)
        {
          System.exit(0);
        }
      else if (playResponse == Y || y)
      {
          System.out.print("Would you like to see the rules? Y/N: ");
           rulesResponse = scan.next();
               if (rulesResponse == Y || y)
               {
                 rules method = new rules
                 public void rules();
                 System.out.print(rules());
                }
               else if (rulesResponse == N || n)
               {
                 System.out.print("");
                }
               else if (rulesResponse != Y || y || N || n)
               {
                 System.out.print("Invalid input");
                }
      if (playResponse != N || n || y || Y)
          System.out.println("Invalid response");
          
    }
   }
}
   
 public static void rules()
  {
      System.out.println("The rules are as follows: two die are thrown and the sum of their two faces"); 
      System.out.println("areadded up, giving a number from 2 to 12. If the number is 7 or 11, the"); 
      System.out.println("thrower wins. If the number is either 2, 3, or 12, the thrower loses. If it"); 
      System.out.println("is neither of these numbers (i.e., it is either 4, 5, 6, 8, 9, or 10),"); 
      System.out.println("this number becomesthe point. The thrower continues to throw the dice"); 
      System.out.println("until either his point comesup or the number 7 comes up. If the point"); 
      System.out.println("comes up, the thrower wins. If a 7 comes up, the thrower loses."); 
      System.out.println("(One says he "'crapped out'"). If the thrower wins, he plays again."); 
      System.out.println("If he loses, he gives up the dice to the next player."); 
      System.out.println("(Hence, the term "'crapped out'" or lose the throw.)")  
  }
  */
 
 
 public static boolean play()
 {
   Die dieOne = new Die();	
   Die dieTwo = new Die();
   int result = rollDie(dieOne,dieTwo);
    
     if (result == 2 || result == 3 || result == 12)
       {
         System.out.println("Sorry, you lost");
         return false;
        }
     else if (result = 7 || result == 11) //compiler highlights problem on this line
       {
         System.out.println("Congratulations, you won!");
         return true;
        }
     else if (result == 4 || result ==  5 || result == 6 || result == 8 || result == 9 || result == 10)
       {
         point = result;
         System.out.println("Your point is "+point+".");
       }
   
    for(rolls = 0; result != 7 || point; rolls++)
      {
        result = rollDie(dieOne,dieTwo);  
        System.outputln("Your die came to "+result+".");  
      }  
    if (result == point)
       {
         System.outputln("Congratulations! The die came to a "+point+ " and you won "+rolls+" games."); 
         return true;
        }
    else if (result == 7)       
       {
         System.outputln("The die came to a 7 and you lost after .");  
         return false;
        }
  }
    
 private static int rollDie(Die one,Die two)
 {
       int total=0;
       oneDie.roll();
       int first = oneDie.getNumber();
       twoDie.roll();
       int second = twoDie.getNumber();
       
       total = first+second;
       return total;
   }
}

Once again, I cannot give enough thanks for any help.

[Anayonkar Shivalkar]

Hello Brian Mart,

Welcome to CodeRanch!

So, below is the problematic line:

else if (result = 7 || result == 11) //compiler highlights problem on this line  

Here, you can easily see what is wrong here.

Hint : operator '||' requires both operands to be boolean. What is your first operand?

I hope this helps.

[Brian Mart]

Thanks Anayonkar, but aren't both of my operands "result"? I am new to Java so I am not entirely sure. If my operands are "result" why does the first one on that same line work just fine and the error message only appears on the second instance of result? Also, according to my instructions, result needs to be an int. So confused...

[Anayonkar Shivalkar]

Ok.

Here's another hint : what's the difference between '==' and '='?

P.S. I'm giving you hints because it would be nice if you yourself understood what is wrong - instead of getting a ready-made answer. I hope you don't mind

[Stanley Mungai]

You are comparing Different things if result =7|| result==4, One side of || contains an integer and the other side a boolean. Both sides need to be either....Got it now?

[Campbell Ritchie]

Stanley Mungai wrote: . . . Both sides need to be either....Got it now?

No, both sides must be “boolean”. It will work with a small b or a capital B because of un-boxing (since Java5 in 2004). The details are in the Java Language Specification, but they are slightly different for the | operator, which can take ints as operands.

Anyway, as has already been mentioned, the real error was confusing == and =.

[Brian Mart]

Thanks, it was just a simple oversight but the compiler message just confused me.