Another JTable Cell Editor / Renderer question.

[David Garratt]

I have a complex JTable which is totally dynamic in as much as the number and type of columns are determined at runtime. Also I have the first 3 columns fixed with only the variable columns scrolling. Needless to say the code is a little complex and for this reason I'm not posting any code at the moment. Everything is working as intended apart from one annoying issue. I have the ability to define the editor for a column as being a JComboBox with the list of possible values also dynamically loaded from a table. The renderer is working ok and the table model seems to work fine as the selected value from the combo box is stored correctly. I can set random values within a single column and they are all rendered correctly after being set from the popup list.

The only problem I have is that the combo box put's a marker in it's list (default value) according to the last value selected by the combo box - in any cell within the column, rather than the actual cell it's been activated on. If you look at pic2 you will see that there is a tick next to the 1st value in the list even though the cell previously contained 001 - Pass.

If I select 001 - Pass in this cell and then move onto the next row the ticked item will be 001 - Pass even if the cell contained a different value.

I have experimented "to death" with "setSelectedItem(value)" at the bottom of my cell renderer but I'm not having any joy. My combo box contained a list of objects where the object contains a key/description pair and has a toString() method to make the cell renderer display the values nicely.

I appreciate it's difficult to answer without seeing the code, but I'm reluctant to post too much out of context stuff. A nice example using a JTable combo box renderer/editor would be great but I've not found one and the only close examples use plain string lists for the combo box values.

Clues / Comments most welcome

Thanks in advance

Dave

[Michael Dunn]

> I have a complex JTable...

just create a 1-column table for a JComboBox (hard code the contents),
add your renderer/editor code, add the table/scrollpane to a frame, make
sure it compiles/runs/displays the problem, and post that code.

often, in renderers/editors, if there is an 'if', there needs to be an 'else'

[Darryl Burke]

The only problem I have is that the combo box put's a marker in it's list (default value) according to the last value selected by the combo box - in any cell within the column, rather than the actual cell it's been activated on. If you look at pic2 you will see that there is a tick next to the 1st value in the list even though the cell previously contained 001 - Pass.

If I select 001 - Pass in this cell and then move onto the next row the ticked item will be 001 - Pass even if the cell contained a different value.

Form that I would conclude that the selected item isn't being set in getTableCellEditorComponent(...)

[David Garratt]

I will try and create a standalone simple example - thanks for everyones help.

Dave

[David Garratt]

I have created a small app which has the basic problem described. I have put the source in an attached zip, but it's not permitted to upload a zip. Is there a alternative - I was trying not to paste all the code if possible.

Thanks

Dave

[Michael Dunn]

if it's a small app it would be < 50 lines, so post the code (inside code tags, so it retains formatting)

[David Garratt]

Unfortunately being a JTable with renderers and cell editors etc I'm not able to get it down to that size.

But if anyone is willing to take I look I can email a small zip with the source.

My email is [e-mail]

Thanks

Dave

[David Garratt]

I have posted a pic of the cut down demo app below. There are 2 specific problems which are driving me nuts.

1) The combo box in the right hand column. When I click on one the combo drop downs the popup window appears as normal and I can choose the new value at leisure. However when I repeat the process on the next combo it appears and disappears in a flash as if it's processing some click event is still in a queue. You can click and hold the mouse to access it, but the 1st time and 2nd time you access the combo's its not acting the same.

2) My combo box (model) is populated with a object rather than a string. The object is very simple and contains 2 public strings called "key" and "description" - I do this because I only want to store the key in the database and use the description to make the selection a little more user friendly. My object has a toString() method so that the combo box displays each item in the format "key - description" - All that works ok. What does not work it that the selected item in the combo does not reflect the current item in the cell. I'm trying to create an instance of my object with key and description matching the item in the list - but no joy.

The later problem is not helped by most examples I've seen in the internet using simple literal strings for the combo box values rather than objects.

As per above post I can email the zip of my source to anyone who is willing to help.

Many thanks

Dave

[Michael Dunn]

> I have posted a pic of the cut down demo app below. There are 2 specific problems which are driving me nuts.

both problems relate to just 1 of the columns:
- cut the table down to just that column
- hard-code 2 or 3 items for the combo's
- add your renderer/editor
- post the code here (cannot possibly be overly long)

[David Garratt]

Here goes then :-

testFrame.java = Frame to display table
tableModel.java = Dummy model to return data (celEditorListItem's)
cellRenderer.java = Renderer for Combo Box containing (cellEditorListItems)
cellEditorListItem.java = Simple class containing a key and a description
cellEditorList.java = Cell Editor for Combo Box populated with cellEditorListItems


testFrame.java

import java.awt.Color;
import java.awt.EventQueue;
import java.util.LinkedList;

import javax.swing.JDesktopPane;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JTable;
import javax.swing.border.EmptyBorder;
import javax.swing.JScrollPane;


public class testFrame extends JFrame
{

	private static final long serialVersionUID = 1L;
	private JPanel contentPane;
	private JTable table;

	/**
	 * Launch the application.
	 */
	public static void main(String[] args)
	{
		EventQueue.invokeLater(new Runnable()
		{
			public void run()
			{
				try
				{
					testFrame frame = new testFrame();
					frame.setVisible(true);
				} catch (Exception e)
				{
					e.printStackTrace();
				}
			}
		});
	}

	/**
	 * Create the frame.
	 */
	public testFrame()
	{
		setTitle("Test Table");
		setResizable(false);
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		setBounds(100, 100, 811, 480);
		contentPane = new JPanel();
		contentPane.setBorder(new EmptyBorder(5, 5, 5, 5));
		setContentPane(contentPane);
		contentPane.setLayout(null);
		
		JDesktopPane desktopPane = new JDesktopPane();
		desktopPane.setBackground(Color.WHITE);
		desktopPane.setBounds(0, 0, 805, 458);
		contentPane.add(desktopPane);
		

		
		LinkedList<cellEditorListItem> list = new LinkedList<cellEditorListItem>();
		list.add(new cellEditorListItem("000","Max"));
		list.add(new cellEditorListItem("001","High"));
		list.add(new cellEditorListItem("002","Medium"));
		list.add(new cellEditorListItem("003","Low"));
		list.add(new cellEditorListItem("004","Off"));
		
		tableModel tablemodel = new tableModel(list);
		
		JScrollPane scrollPane = new JScrollPane();
		scrollPane.setBounds(22, 24, 749, 403);
		desktopPane.add(scrollPane);
		table = new JTable();
		scrollPane.setViewportView(table);
		table.setModel(tablemodel);

		table.setDefaultRenderer(Object.class, new cellRenderer());
		
		table.setAutoResizeMode(JTable.AUTO_RESIZE_OFF);

		
		table.getColumnModel().getColumn(0).setCellEditor(new cellEditorList(list));
		
		table.getColumnModel().getColumn(0).setPreferredWidth(210);
		table.setBackground(Color.LIGHT_GRAY);
	}
}

tableModel.java

import java.util.LinkedList;

import javax.swing.table.AbstractTableModel;


public class tableModel extends AbstractTableModel
{
	private static final long serialVersionUID = 1L;

	String[] colNames = {"combo"};
	@SuppressWarnings("rawtypes")
	Class[] colClass = {cellEditorListItem.class};
	Object[] row1data = {"001" };
	Object[] row2data = {"003" };
	LinkedList<cellEditorListItem> list;
	
	public tableModel(LinkedList<cellEditorListItem> lst)
	{
		list = lst;
	}
	
	@Override
	public int getColumnCount()
	{
		// TODO Auto-generated method stub
		return colNames.length;
	}

	@Override
	public int getRowCount()
	{
		// TODO Auto-generated method stub
		return 2;
	}

	@Override
	public Object getValueAt(int row, int col)
	{
		Object result = null;;
		if (row==0)
		{
			result=row1data[col];
		}
		if (row==1)
		{
			result=row2data[col];
		}
		
		if (getColumnClass(col)== cellEditorListItem.class)
		{
			for (int x=0;x<list.size();x++)
			{
				if (list.get(x).key.equals(result.toString()))
				{
					cellEditorListItem y = new cellEditorListItem(result.toString(),list.get(x).description);
					result = y;
					break;
				}
			}
		}

		return result;
	}
	
	@Override
	public void setValueAt(Object value, int row, int col)
	{

		if (row==0)
		{
			row1data[col]=value;
		}
		if (row==1)
		{
			row2data[col]=value;
		}	
	}

	@Override
	public Class><?> getColumnClass(int columnIndex)
	{
		return colClass[columnIndex];
	}
	
	public boolean isCellEditable(int rowIndex, int columnIndex)
	{
		return true;
	}
	
	public String getColumnName(int col)
	{

		return colNames[col];
	}

}

cellRenderer.java

import java.awt.Component;
import java.text.NumberFormat;
import java.util.Locale;

import javax.swing.JComboBox;
import javax.swing.JTable;
import javax.swing.table.DefaultTableCellRenderer;

public class cellRenderer extends DefaultTableCellRenderer
{

	private Locale locale = Locale.getDefault();
	private cellEditorListItem cmbo;
	public cellRenderer()
	{
		NumberFormat.getNumberInstance(locale);
	}

	private static final long serialVersionUID = 1L;

	public Component getTableCellRendererComponent(JTable table, Object obj, boolean isSelected, boolean hasFocus, int row, int column)
	{
		Component cell = super.getTableCellRendererComponent(table, obj, isSelected, hasFocus, row, column);
		
		table.setRowHeight(25);
		

		if (obj.getClass().equals(cellEditorListItem.class))
		{
			try
			{
				cmbo = ((cellEditorListItem) obj);

			} catch (Exception ex)
			{
				return null;
			}
		}		
		
		
		if (cell instanceof JComboBox)
		{
			((JComboBox) cell).setSelectedItem(cmbo);
		}		

		return cell;
	}

}

cellEditorListItem.java

public class cellEditorListItem
{
	public String key="";
	public String description = "";
	
	public cellEditorListItem(String k,String d)
	{
		key = k;
		description = d;
	}
	
	public String toString()
	{
		return key + " - "+description;
	}
}

cellEditorList.java

import java.awt.Color;
import java.awt.Component;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.util.LinkedList;

import javax.swing.AbstractCellEditor;
import javax.swing.DefaultComboBoxModel;
import javax.swing.JComboBox;
import javax.swing.JComponent;
import javax.swing.JTable;
import javax.swing.table.TableCellEditor;

public class cellEditorList extends AbstractCellEditor implements TableCellEditor
{

	private static final long serialVersionUID = 1L;
	private JComponent editor = new JComboBox();
	private DefaultComboBoxModel comboBoxModel;
	
    public cellEditorList() {  
    	editor = new JComboBox();  
    	((JComboBox) editor).setBackground( Color.white);  
    	((JComboBox) editor).addActionListener(new ActionListener() {
			public void actionPerformed(ActionEvent e) {
				stopCellEditing();
			}
		});
    } 
	
	public cellEditorList(LinkedList<cellEditorListItem> list)
	{
		super();
		
		comboBoxModel = new DefaultComboBoxModel();
		
		for (int x=0;x<list.size();x++)
		{
			comboBoxModel.addElement((cellEditorListItem) list.get(x));
		}
		
		((JComboBox) editor).setModel(comboBoxModel);
	}
	
	@Override
	public Object getCellEditorValue()
	{
		return ((JComboBox)editor).getSelectedItem();
	}

	@Override
	public Component getTableCellEditorComponent(JTable table, Object value, boolean isSelected, int rowIndex, int vColIndex)
	{
		
		((JComboBox) editor).setSelectedItem(value);

		return editor;
	}

}

>

[David Garratt]

Additional info.

I am running on a Mac (OSX Lion)

java version "1.6.0_33"
Java(TM) SE Runtime Environment (build 1.6.0_33-b03-424-11M3720)
Java HotSpot(TM) 64-Bit Server VM (build 20.8-b03-424, mixed mode)

[David Garratt]

Just wondered - has anyone felt brave enough to take a look at this for me ?

I'm stumped.

Thanks

Dave

[Michael Dunn]

in tableModel's getValueAt(), add the indicated line

System.out.println(result);//<--------------
return result;

the printout is endless - if you can fix that, it might solve your problem

[David Garratt]

I think I have eliminated the repeated called to getValue - although not entirely sure why it makes a difference, by commenting out the following line from the testFrame.java

However this does not seem to correct either of the 2 reported problems.

		JScrollPane scrollPane = new JScrollPane();
		scrollPane.setBounds(22, 24, 749, 403);
		desktopPane.add(scrollPane);
		table = new JTable();
		scrollPane.setViewportView(table);
		table.setModel(tablemodel);

		//table.setDefaultRenderer(Object.class, new cellRenderer());
		
		table.setAutoResizeMode(JTable.AUTO_RESIZE_OFF);
		
		table.getColumnModel().getColumn(0).setCellEditor(new cellEditorList(list));
		
		table.getColumnModel().getColumn(0).setPreferredWidth(210);
		table.setBackground(Color.LIGHT_GRAY);

[Ranganathan Kaliyur Mannar]

The problem is not with your renderer. In fact, the renderer is redundant in your case. As you have toString() implemented, it will be called by the defaul renderer in the table.

The problem is that, you add 'cellEditorListItem' objects to the combo first - as the options. Then, in the getValueAt(), you again create new objects of 'cellEditorListItem' - these may be equal to the human eye. but it is not equal in the Java world. So, when the editor sees that its option is not equal to the value in the table, it just shows the first value.
So, you should first create the list of options and share them between the table model and the combo box. The getValueAt should return an existing object based on your comparison - there is no need to create the objects repeatedly. In fact, this is a waste as the getValueAt will be called many times whenever the table paints itself. Overriding equals can be considered, but in any case, creating objects repeatedly within getValueAt is not good.

In normal cases, String objects would be used. As 2 strings of the same value anyway point to the same object, it will work fine. Or, it may be enum values which would again refer to the same object.
You should do the same with your dynamic stuff.

PS: Having combo box as editors is actually easy. I would suggest extending the DefaulCellEditor and you can call invoke the super class constructor by passing the JComboBox instance and rest should work.

[David Garratt]

I think I understand what your saying. However this snippet of code is not really representative of my full application as it creates a table dynamically and I don't know if a column will be represented as a combo box or checkbox or textfield until I interrogate the contents of another "definition" table on the fly. Fundamentally the problem is as I understand it that two objects created independently won't be equal. Somehow I'm going to have to find a way to create a common list of objects between the model and the combo on the fly.

I definitely need a good nights sleep to get my head around this one.

Thanks very much for you help so far.

Dave

[Ranganathan Kaliyur Mannar]

Thats right. You need to find a way to create the list of objects and pass it around.

You're welcome.