Spring 3 and Hibernate 4 Configuration Question

[David Ratliff]

Hello,

I am working on migrating an older project to use Spring 3 and Hibernate 4. We did use the HibernateTemplate to access the database.
Since HibernateTemplate is deprecated, I using the Session Factory directly and Hibernate Transaction Manager.
I have gone through numerous examples and everything looks good to me. But I keep getting and error when I call my method that get's the current session.

Here is the error, I don't have an stack trace that relates to this error but I can provide what it does dump.

org.hibernate.HibernateException: No Session found for current thread

 

3:52:08,210 [tomcat-http--3] ERROR SearchDAOImpl - ERROR  :  Session actions are null - retrieveHibernateSearch SQL =  select b  from Book as b, BookInfo as i, Cin as c  where b.bookNum = i.bookNum  and b.cinID = c.cinID  and c.LName like ?  and c.FName like ?  and b.custodyStatus = ?   (retrieveHibernateSearch)
org.hibernate.HibernateException: No Session found for current thread
13:52:08,210 [tomcat-http--3] ERROR SearchDAOImpl - ERROR  :  Booking Summary Type is empty or null....(retrieveNameSearchResultsType)
13:52:08,210 [tomcat-http--3] DEBUG SearchDAOImpl - Search results is null 
13:52:08,210 [tomcat-http--3] ERROR JailRosterImpl - ERROR:  search results, getSearchResults is null...(searchByName)
13:52:08,211 [tomcat-http--3] ERROR NameSearchEndpoint - ERROR  :  Search response is null..(retrieveNameSearchResponse)
13:52:08,211 [tomcat-http--3] ERROR NameSearchEndpoint - ERROR  :  Search response came back null..(NameSearchResponse)
13:52:08,211 [tomcat-http--3] DEBUG SimpleSoapExceptionResolver - Resolving exception from endpoint [public org.hennepinsheriff.jailroster.ws.SearchResponse org.hennepinsheriff.jailroster.ws.NameSearchEndpoint.searchResponse(org.hennepinsheriff.jailroster.ws.NameSearchRequest)]: java.lang.IllegalArgumentException: 'jaxbElement' must not be null
13:52:08,217 [tomcat-http--3] DEBUG SoapMessageDispatcher - Endpoint invocation resulted in exception - responding with Fault
java.lang.IllegalArgumentException: 'jaxbElement' must not be null
	at org.springframework.util.Assert.notNull(Assert.java:112)
	at org.springframework.ws.server.endpoint.adapter.method.jaxb.AbstractJaxb2PayloadMethodProcessor.marshalToResponsePayload(AbstractJaxb2PayloadMethodProcessor.java:86)
	at org.springframework.ws.server.endpoint.adapter.method.jaxb.XmlRootElementPayloadMethodProcessor.handleReturnValue(XmlRootElementPayloadMethodProcessor.java:66)
	at org.springframework.ws.server.endpoint.adapter.DefaultMethodEndpointAdapter.handleMethodReturnValue(DefaultMethodEndpointAdapter.java:284)
	at org.springframework.ws.server.endpoint.adapter.DefaultMethodEndpointAdapter.invokeInternal(DefaultMethodEndpointAdapter.java:237)
	at org.springframework.ws.server.endpoint.adapter.AbstractMethodEndpointAdapter.invoke(AbstractMethodEndpointAdapter.java:53)
	at org.springframework.ws.server.MessageDispatcher.dispatch(MessageDispatcher.java:231)
	at org.springframework.ws.server.MessageDispatcher.receive(MessageDispatcher.java:172)
	at org.springframework.ws.transport.support.WebServiceMessageReceiverObjectSupport.handleConnection(WebServiceMessageReceiverObjectSupport.java:88)
	at org.springframework.ws.transport.http.WebServiceMessageReceiverHandlerAdapter.handle(WebServiceMessageReceiverHandlerAdapter.java:59)
	at org.springframework.ws.transport.http.MessageDispatcherServlet.doService(MessageDispatcherServlet.java:221)
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:882)
	at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:789)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:641)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:225)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:169)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:168)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98)
	at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:927)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
	at com.springsource.insight.collection.tcserver.request.HttpRequestOperationCollectionValve.traceNextValve(HttpRequestOperationCollectionValve.java:116)
	at com.springsource.insight.collection.tcserver.request.HttpRequestOperationCollectionValve.invoke(HttpRequestOperationCollectionValve.java:98)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407)
	at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:999)
	at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:565)
	at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:307)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
	at java.lang.Thread.run(Thread.java:679)
13:52:08,219 [tomcat-http--3] DEBUG sent - Sent response [SaajSoapMessage {http://schemas.xmlsoap.org/soap/envelope/}Fault] for request [SaajSoapMessage {http://hennepinsheriff.org/JailRoster/NameSearch}NameSearchRequest]
13:52:08,563 [tomcat-http--3] DEBUG MessageDispatcherServlet - Successfully completed request

My applicationConfiguration.xml

 <bean id="sessionFactory" class="org.springframework.orm.hibernate4.LocalSessionFactoryBean">
  		<property name="dataSource" ref="jailRosterDataSource" /> 
  		<property name="annotatedClasses">
			<list>
				<value>org.companyname.jailroster.business.Address</value>
				<value>org.companyname.jailroster.business.Arr</value>
				<value>org.companyname.jailroster.business.Book</value>
				<value>org.companyname.jailroster.business.BookInfo</value>
				<value>org.companyname.jailroster.business.BookXref</value>
				<value>org.companyname.jailroster.business.Chg</value>
				<value>org.companyname.jailroster.business.Cin</value>
				<value>org.companyname.jailroster.business.Ctl</value>
				<value>org.companyname.jailroster.business.HenBook</value>
			</list>
		</property>
        <property name="hibernateProperties">
			<props>			
				<prop key="hibernate.dialect">org.hibernate.dialect.SybaseDialect</prop>
				<prop key="hibernate.show_sql">true</prop>
			</props>
		</property>
	</bean>
	<bean id="transactionManager" class="org.springframework.orm.hibernate4.HibernateTransactionManager">
		<property name="sessionFactory" ref="sessionFactory" />
	</bean>
 
	<tx:annotation-driven transaction-manager="transactionManager" />
	<bean id="jailRosterDataSource" class="com.mchange.v2.c3p0.ComboPooledDataSource" destroy-method="close">
		<property name="driverClass" value="net.sourceforge.jtds.jdbc.Driver"/>
		<property name="jdbcUrl" value="jdbc:jtds:sybase://dbname/ojms" />	
		<property name="user" value="user1" />
		<property name="password" value="userpwd1" />
		<property name="maxPoolSize" value="10" />
		<property name="maxStatements" value="0" />
		<property name="minPoolSize" value="5" />
	</bean>
   
	<bean id="searchDAOImpl" class="org.companyname.jailroster.dao.SearchDAOImpl"/>
 	<bean id="jailRosterImpl" class="org.companyname.jailroster.business.JailRosterImpl"/>
	<bean id="custodyStatusSearchEndpoint" class="org.companyname.jailroster.ws.CustodyStatusSearchEndpoint"/>
	<bean id="chargeDetailEndpoint" class="org.companyname.jailroster.ws.ChargeDetailEndpoint"/>
	<bean id="nameSearchEndpoint" class="org.companyname.jailroster.ws.NameSearchEndpoint"/>

my Controller:

//@Transactional
public class JailRosterImpl implements JailRoster {
	final Logger log = LogManager.getLogger(JailRosterImpl.class);

	@Autowired
	private SearchDAOImpl searchDAOImpl;
	public void setSearchDAOImpl(SearchDAOImpl searchDAOImpl) {
		if (log.isDebugEnabled()) {
			log.debug("SearchDAO is Set - JailRoster");
		}
		this.searchDAOImpl = searchDAOImpl;
	}
	public SearchDAOImpl getSearchDAOImpl() {
		if (log.isDebugEnabled()) {
			log.debug("Get SearchDAO - JailRoster");
		}
		return this.searchDAOImpl;
	}
	

	public SearchResponse searchByName(PersonNameType personNameType, Date searchFromDate){
	
	...
	
	}
}

my DAO:

@Repository
//@Transactional
public class SearchDAOImpl implements SearchDAO {
	final Logger log = LogManager.getLogger(SearchDAOImpl.class);
	
	@Autowired
	private SessionFactory sessionFactory;
	public SessionFactory getSessionFactory() {
		return this.sessionFactory;
	}
	public void setSessionFactory(SessionFactory sessionFactory) {
		this.sessionFactory = sessionFactory;
	}
	
	
	@Autowired
	private HibernateTransactionManager transactionManager;
	public HibernateTransactionManager getTransactionManager() {
		return transactionManager;
	}
	public void setTransactionManager(HibernateTransactionManager transactionManager) {
		this.transactionManager = transactionManager;
	}
	
	public SearchResultsType nameSearch(PersonNameType personNameRequest, Date searchFromDate){
	
	...
	
	}	
}

I have commented out the @Transactional because when I leave it in, c3p0 fails and my service won't even start. I know it is some configuration that I am missing or have understood incorrectly.

Please let me know if you need more information. Any help is greatly appreciated.

Thank you,

Dave

[Mark Spritzler]

First you say you posted a Controller, but it doesn't look like a Controller, it looks like a Service.

Also, Hibernate requires that you have a transaction. so you have to have @Transactional somewhere

Also, you inject the transactionManager into your DAO? Why, your DAO doesn't need it.

Your xml configuration looks correct for transactionManager, sessionFactory and dataSource.

Why is C3PO pool throwing an exception? I would concern myself about that.

Please post your code for public SearchResultsType nameSearch(PersonNameType personNameRequest, Date searchFromDate){

How are you using the sessionFactory injected into your Repository? It should start with sessionFactory.getCurrentSession().

Thanks

Mark

[Bill Gorder]

I use JPA myself but if you don't have a transaction you would have to open it manually

Session session = sessionFactory.openSession();
//some more stuff here
session.close()

nice article on it here
http://blog.springsource.org/2012/04/06/migrating-to-spring-3-1-and-hibernate-4-1/

If you need CGLIB is it on the classpath?

[Bill Gorder]

Edit - nvm I missed the <tx:annotation-driven transaction-manager="transactionManager" /> in your config I thought it was missing.