java code problem

[abrar alvi]

public class Game {

    Player p1;
    Player p2;
    Player p3;

    void startGame() {
        System.out.println("STARTING GAME");

        p1 = new Player();
        p2 = new Player();
        p3 = new Player();

        int p1guess = 0;
        int p2guess = 0;
        int p3guess = 0;

        boolean p1right = false;
        boolean p2right = false;
        boolean p3right = false;
        int realno = (int) (Math.random() * 10);
        System.out.println("I AM THINKING OF A NUMBER FROM 0 TO 9");
        while (true) {
            System.out.println("NUMBER TO GUESS IS: " + realno);
            p1.guess();
            p2.guess();
            p3.guess();

            p1guess = p1.number;
            System.out.println("P1 IS GUESSING NUMBER AS: " + p1guess);
            if (p1guess == realno) {
                p1right = true;
            }
            p2guess = p2.number;
            System.out.println("P2 IS GUESSING NUMBER AS: " + p2guess);
            if (p2guess == realno) {
                p2right = true;
            }
            p3guess = p3.number;
            System.out.println("P3 IS GUESSING NUMBER AS: " + p3guess);
            if (p3guess == realno) {
                p1right = true;
            }
            if (p1right || p2right || p3right) {
                System.out.println("WE HAVE A WINNER");
                System.out.print("THE WINNER IS  ");
                if (p1right && p2right) {
                    System.out.println("P1  AND P2");
                } else if (p1right && p3right) {
                    System.out.println("P1 AND P3");
                } else if (p2right && p3right) {
                    System.out.println("P2 AND P3");
                } else if (p1right) {
                    System.out.print("P1");
                } else if (p2right) {
                    System.out.print("P2");
                } else if (p3right) {
                    System.out.print("P3");
                }


                break;
            } else {
                System.out.println("try again");
            }
        }
    }
}

the problem here is if two or three players are right in guessing i am not able to display the correct System.out.println statement...

please help

[harshvardhan ojha]

try something like

if (p1right || p2right || p3right) {
System.out.println("WE HAVE A WINNER");
System.out.print("THE WINNER IS ");
StringBuffer result = new StringBuffer();
if(p1right)
result.append("P1 ");
if(p2right)
result.append("P2 ");
if(p3right)
result.append("P3 ");
System.out.println(result);
}

[Gaurangkumar Khalasi]

You have not given sufficient information to give your question's answer such as you have to show the output and class Player.

abrar alvi wrote:the problem here is if two or three players are right in guessing i am not able to display the correct System.out.println statement...

But as per the given information, i can say that "for three players", you have not set condition...
e.g.

               if (p1right || p2right || p3right) {
                System.out.println("WE HAVE A WINNER");
                System.out.print("THE WINNER IS  ");
                if (p1right && p2right && p3right) { //You have not check this...
                    System.out.println("P1  AND P2 AND P3");
                }else if (p1right && p2right) {
                    System.out.println("P1  AND P2");
                } else if (p1right && p3right) {
                    System.out.println("P1 AND P3");
                } else if (p2right && p3right) {
                    System.out.println("P2 AND P3");
                } else if (p1right) {
                    System.out.print("P1");
                } else if (p2right) {
                    System.out.print("P2");
                } else if (p3right) {
                    System.out.print("P3");
                }
              }

@harshvardhan ojha
He has shown a nice way rather than defined in your code to get the result...You can use it. Just defined the StringBuffer result = new StringBuffer(); outside the while loop.

[abrar alvi]

You have not given sufficient information to give your question's answer such as you have to show the output and class Player.

if (p1right || p2right || p3right) {
                System.out.println("WE HAVE A WINNER");
                System.out.print("THE WINNER IS  ");
                if (p1right && p2right && p2right) {
                    System.out.println("P1  AND P2 AND P3   ");
                } else if (p1right && p2right) {
                    System.out.println("P1  AND P2    ");
                } else if (p1right && p3right) {
                    System.out.println("P1 AND P3    ");
                } else if (p2right && p3right) {
                    System.out.println("P2 AND P3     ");
                } else if (p1right) {
                    System.out.print("P1     ");
                } else if (p2right) {
                    System.out.print("P2      ");
                } else if (p3right) {
                    System.out.print("P3    ");
                }


                break;
            } else {
                System.out.println("try again");
            }
        }
    }

This is the output which i get even after adding the && condition for all three players :

STARTING GAME
I AM THINKING OF A NUMBER FROM 0 TO 9
NUMBER TO GUESS IS: 4
P1 IS GUESSING NUMBER AS: 5
P2 IS GUESSING NUMBER AS: 0
P3 IS GUESSING NUMBER AS: 2
try again
NUMBER TO GUESS IS: 4
P1 IS GUESSING NUMBER AS: 6
P2 IS GUESSING NUMBER AS: 7
P3 IS GUESSING NUMBER AS: 5
try again
NUMBER TO GUESS IS: 4
P1 IS GUESSING NUMBER AS: 4
P2 IS GUESSING NUMBER AS: 4
P3 IS GUESSING NUMBER AS: 6
WE HAVE A WINNER
THE WINNER IS P1 AND P2 AND P3 // this is not correct

(before i even got only one player as winner for 2 players guessing the correct number)



Here is the player class:

public class Player {
    int number=0;
    public void guess(){
 number= (int)(Math.random()*10);
        
    }
}

PLEASE HELP...

[Gaurangkumar Khalasi]

Try out with the following:

            if (p3guess == realno) {
                p1right = true; //Here is a mistake...change it to p3right=true;...
            }

[Campbell Ritchie]

Why are you using three similar variables rather than an array? Why have you got the three booleans separate from the players, rather than as fields of the player class?

[abrar alvi]

Thank You
Gaurangkumar Khalasi...

[abrar alvi]

Hi Campbell Ritchie,

I will try with your suggestion.

[Gaurangkumar Khalasi]

abrar alvi wrote:Thank You
Gaurangkumar Khalasi...

You are welcome

[Steven Schwab]

Although data encapsulation is a great concept, I think the poster is suffering primarily from a lack of debugging skills.

@abrar alvi, try to think logically about what the code that you posted is doing:
1. You know that it is printing out "P1 AND P2 AND P3 " for the values 4, 4, and 6.
2. You know that each statement is wrapped in its own if condition.

Therefore, the if condition around "P1 AND P2 AND P3 " MUST be getting evaluated to true with the values 4, 4, and 6. Look at that condition and you will find your error.

Note that if the if condition looks correct, your next step would be to trace back to where each of the individual variables in the if condition are being set. This would have answered your first question in this topic, by finding that p3right was not being set.

[abrar alvi]

@Steven Schwab... thank you.