Accessing child TextView inside ListView

[Astha Sharma]

Hi I want to make an application which contain a ListView and children TextViews inside the list. On clicking different TextViews, application performs in different open different intents. But it is opening same intents on all the time. Following is the code-

public class MainActivity extends Activity implements OnItemClickListener{
	private Context context= this;
	public static PatientInfo pi=null;
	public static TextView name, dob, phone, address;
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        Log.d("1","0");
        setContentView(R.layout.activity_main);
        Log.d("1","1");
        List<PatientInfo> pil = new ArrayList<PatientInfo>();
        pil.add(new PatientInfo(...arguments removed...));
        pil.add(new PatientInfo(...arguments removed...));
        pil.add(new PatientInfo(...arguments removed...));
        pil.add(new PatientInfo(...arguments removed...));
        Log.d("2","2");
        ListView lv = (ListView) findViewById(R.id.lv1);
        lv.setOnItemClickListener(new OnItemClickListener(){
        	public void onItemClick(AdapterView<?> l, View v, int pos, long arg3) {
        		// TODO Auto-generated method stub
        		
        		Log.d("1","19");
            	pi=(PatientInfo) l.getItemAtPosition(pos);
            	Log.d("1","10");
            	String t1= pi.name;
            	String t2=pi.dob;
            	final String t3=pi.phn;
            	String t4=pi.photo;
            	String t5=pi.address;
            	Log.d("id","id="+l.getId());
            	
            	Log.d("id","id "+v.getId()+" "+R.id.tv3);
            	TextView tv=(TextView)v.findViewById(R.id.tv3);
            	Log.d("tv",tv.toString());
        		if(tv != null)  
                {  
        			Log.d("tv","not null");
        			tv.setOnClickListener(new OnClickListener(){  
                          public void onClick(View v) {  
                        	  Intent i=new Intent(Intent.ACTION_DIAL);
                      		i.setData(Uri.parse("tel:"+t3));
                      		context.startActivity(i);
                          }  
                     });  
                } 
            		Log.d("1",t4);
                	Intent i=new Intent(context,Info.class);
                	Bundle b=new Bundle();
                	b.putString("t1", t1);
                	b.putString("t2", t2);
                	b.putString("t3", t3);
                	b.putString("t4", t4);
                	b.putString("t5", t5);
                	Log.d("1","12");
                	i.putExtras(b);
                	startActivity(i); 	  
        	}
        });
        Log.d("1","3");
        MyContactList myContactListAdapter = new MyContactList(pil,context);
        lv.setAdapter(myContactListAdapter);
        Log.d("1","4");
       }  
	@Override
	public void onItemClick(AdapterView<?> arg0, View arg1, int arg2, long arg3) {
		// TODO Auto-generated method stub	
	} 
}
class PatientInfo
{
    	String name="";
    	String dob;
    	String phn;
    	String photo;
    	String address;
    	PatientInfo(String name,String dob,String phn,String photo,String address)
    	{
    		Log.d("1","5");
    		this.name=name;
    		this.dob=dob;
    		this.phn=phn;
    		this.photo=photo;
    		this.address=address;
    	}   	
}
class MyContactList extends BaseAdapter
 {
	 List<PatientInfo> pi;
	 Context context;
	public MyContactList(List<PatientInfo> pi, Context context) {
		// TODO Auto-generated constructor stub
		this.pi=pi;
		this.context=context;
		Log.d("1","6");
		Log.d("Size","Size of array"+pi.size());
	}
	@Override
	public int getCount() {
		// TODO Auto-generated method stub
		return pi.size();
	}

	@Override
	public Object getItem(int pos) {
		// TODO Auto-generated method stub
		return pi.get(pos);
	}

	@Override
	public long getItemId(int pos) {
		// TODO Auto-generated method stub
		return pos;
	}
	@Override
	public View getView(final int position, View convertView, ViewGroup parent) {
		// TODO Auto-generated method stub
		final PatientInfo objPI= (PatientInfo) getItem(position);
		Log.d("1","7");
		if(convertView==null)
		{
		LayoutInflater inflater = (LayoutInflater)context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        convertView = inflater.inflate(R.layout.list,null);
		}
		MainActivity.name = (TextView) convertView.findViewById(R.id.tv1);
		MainActivity.dob = (TextView) convertView.findViewById(R.id.tv2);
		MainActivity.phone = (TextView) convertView.findViewById(R.id.tv3);
		//MainActivity.address = (TextView) convertView.findViewById(R.id.tv4);
        if(objPI.name.equalsIgnoreCase(""))
               	Log.d("1","null"+objPI.name);
         else
            	Log.d("1","8"+objPI.name);
        MainActivity.name.setText(objPI.name);
        MainActivity.dob.setText(objPI.dob);
        MainActivity.phone.setText(objPI.phn);
        Log.d("1","9");
        return (convertView);
	}
}	     

Please tell me what mistake am I doing and help me out.

[Ameet Sagar]

you are not using the ViewHolder class for holding the views.

Try creating the custom view holder class like

class PatientInfoViewHolder
{
	TextView tv1;
	TextView tv2;
	TextView tv2;
}

and add in get view method use following code

if (convertView == null) 
{
        LayoutInflater inflater = (LayoutInflater)context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);  
        convertView = inflater.inflate(R.layout.list,null);  
       holder = new PatientInfoViewHolder();
       holder.tv1 = (TextView) convertView.findViewById(R.id.tv1);  
        holder.tv2 = (TextView) convertView.findViewById(R.id.tv2);  
        holder.tv3 = (TextView) convertView.findViewById(R.id.tv3);
        convertView.setTag(holder);
}
else 
{
	holder = (PatientInfoViewHolder) convertView.getTag();
}
return convertView;

on line 23 you are using

pi=(PatientInfo) l.getItemAtPosition(pos);  

Your should change it to

 pi=(PatientInfo) pil.get(pos);  

now you can use the pi object to create the intent and nevigate to another screen.