After and before Advice Dosent Fire in spring

[jatan bhavsar]

I have made simple application which does the insert ,update and delete and works successfully now i would like to use AOP in the same application but couldnt achieve that.
Advice dosent fire in the web application as well it works properly from the stand alone application.I have add the code for the xml file here.Please help so i can continue learning with the spring..

	<bean id="viewResolver" class="org.springframework.web.servlet.view.InternalResourceViewResolver" 
         	p:prefix="WEB-INF/jsp/" p:suffix=".jsp" />
         	
    	<bean name="/usersList.htm" class="web.UserController"	p:userDAO-ref="userDAO"  />
		<bean name="/userForm.htm" class="web.UserController" p:userDAO-ref="userDAO"/>
		<bean name="/EditUser.htm" class="web.UserController" p:userDAO-ref="userDAO" />
		<bean name="/deleteUser.htm" class="web.UserController" p:userDAO-ref="userDAO" />
		<bean name="/editUser.htm" class="web.UserController" p:userDAO-ref="userDAO" />
		<bean name="/addUser.htm" class="web.UserController" p:userDAO-ref="userDAO" />
   	
		<bean id="myDataSource" class="org.apache.commons.dbcp.BasicDataSource">
			<property name="driverClassName" value="oracle.jdbc.OracleDriver"></property>
			<property name="url" value="jdbc:Oracle:thin:@127.0.0.1:1521:XE"></property>
			<property name="username" value="abc"></property>
			<property name="password" value="abc"></property>
			
	   </bean>
	<bean id="mySessionFactory" class="org.springframework.orm.hibernate3.LocalSessionFactoryBean">
		<property name="dataSource" ref="myDataSource"></property>
		<property name="mappingResources">
			<list>
				<value>employee.hbm.xml</value>
				<value>city.hbm.xml</value>
				<value>state.hbm.xml</value>
				<value>country.hbm.xml</value>
			</list>
		</property>
		<property name="hibernateProperties">
			<props>
				<prop key="hibernate.dialect">org.hibernate.dialect.OracleDialect</prop>
				<prop key="hibernate.show_sql">false</prop>
			</props>
		</property>
	</bean>
	<bean id="transactionManager" class="org.springframework.orm.hibernate3.HibernateTransactionManager">         
		<property name="sessionFactory">     
			<ref bean="mySessionFactory"/>   
		</property>    
	</bean> 
		
	<bean id="userDAO"  class="dao.UserDAOImpl">
			<property name="sessionFactory" ref="mySessionFactory" />
	</bean>
	
	
	<!-- [color=darkred]AOP implementation [/color]-->	

  <bean id="businesslogicbean" class="org.springframework.aop.framework.ProxyFactoryBean">
       <property name="proxyInterfaces" value="dao.UserDAO" />
        <property name="target">
            <ref local="userDAO" />
        </property>
        <property name="interceptorNames">
            <list>
            	<value>theTracingBeforeAdvisor</value>
                <value>theTracingAfterAdvisor</value>
            </list>
        </property>
    </bean>
    <bean id="theTracingBeforeAdvice" class="Interceptors.BeforeAdviceExample" />
 	<bean id="theTracingAfterAdvice" class="Interceptors.AfterFinalyAdviceExample" />
 
  
 
      <!-- Advisor pointcut definition for before advice -->
    <bean id="theTracingAfterAdvisor" class="org.springframework.aop.support.RegexpMethodPointcutAdvisor">
        <property name="advice">
            	<ref local="theTracingAfterAdvice" />
        </property>
        <property name="pattern">
            <value>.*</value>
        </property>
    </bean>
 	<bean id="theTracingBeforeAdvisor" class="org.springframework.aop.support.RegexpMethodPointcutAdvisor">
        <property name="advice">
            	<ref local="theTracingBeforeAdvice" />
        </property>
        <property name="pattern">
            <value>.*</value>
        </property>
    </bean>
    						
 

UserController:

public class UserController extends MultiActionController {

	private UserDAOImpl userDAO;
	
	public UserDAOImpl getUserDAO() {
		return userDAO;
	}
	public void setUserDAO(UserDAOImpl userDAO) {
		this.userDAO = userDAO;
	}
             public ModelAndView editUser(HttpServletRequest request,HttpServletResponse response,User user) throws Exception {
		System.out.println("command object:::::"+request.getParameter("id"));
		
		if(request.getParameter("id")!=null)
	 	   {
			int id=Integer.parseInt(request.getParameter("id"));
	 	   	 user = userDAO.editUser(id);
	 	   }
	 	   
	 	ModelAndView mv = new ModelAndView();
	 	getStateComboFill(request,mv,user);
		getCityComboFill(request,mv,user);
		List country = userDAO.getCountryList();
		mv.addObject("countrylist", country);
		
		getStateComboFill(request,mv,user);
		getCityComboFill(request,mv,user);
		
		//mv.addObject("countrylist", country);
		//mv.addObject("User",user);
		mv.addObject("User",user);
		mv.setViewName("EditUser");
		return mv;
	 	//return new ModelAndView("EditUser","User",user);
	}
}

On the edit method Advice will fire.

My DAO Class:

public class UserDAOImpl implements UserDAO {

	private SessionFactory sessionFactory;  
	public void setSessionFactory(SessionFactory sessionFactory) 
	    {
		   System.out.println("Set session Factory:::::::::::::"+sessionFactory);
		   this.sessionFactory = sessionFactory;  
		}
             public User editUser(int id) 
                 {
	     Session session = sessionFactory.openSession();			
	     session.beginTransaction();
	     System.out.println("Id in edit user:::"+id);
	     Query query = session.createQuery("from User where empno = :id");
	     query.setParameter("id",id);
	     User user = (User)query.uniqueResult();
	     session.close();
	     return user;
	}
}

Interface is UserDAO which contains the prototype for the methods.. and Advice class is as follow:

public class AfterFinalyAdviceExample implements AfterReturningAdvice
{
    public void afterReturning(Object object,Method method, Object[] args, Object target)throws Throwable
    {
    	
        System.out.println("Hello world! by:::::::::::::::::::::::::::::::::::::::: " + this.getClass().getName());
    }
}

It dosent work in the web application but when i execute it from the stand alone application like:

public class Testmain {
    public static void main(String[] args) {
        // Read the configuration file
        ApplicationContext ctx = new FileSystemXmlApplicationContext("E:/workspace1.5/SpringHibernate/WebContent/WEB-INF/dispatcher-servlet.xml");
 
        // Instantiate an object
        UserDAO proxyInterfaces = (UserDAO) ctx.getBean("businesslogicbean");
 
        // Execute the public method of the bean
        proxyInterfaces.editUser(19);
    }
} 

IT works fine so i am not aware how can i get the "businesslogicbean" (proxyinterface) to execute the Advice it works perfect in stand alone code which i added here.Can somebody guide me how can i solve the problem.
Any alternate solution.

Regards
Jatan

[Bill Gorder]

You are learning from an old example. In newer versions of Spring your controllers should be the annotation based controllers (@Controller) and should not extend any Spring classes. Also the AOP paradigm has shifted and is now much easier than what you are trying to do here. Spring has introduced an AOP configuration namespace for XML and there is also the option of using AspectJ's annotation configuration. Either of these approaches are far easier to work with and less verbose. If I were you I would search for a more up to date example to learn from.

Thanks,

[Jordan Josh]

Hi Bill,

Thank you for your kind reply but i am not using annotation in my application.. I will be thankful to you if you can guide me without annotation .

Regards
Jatan

[Bill Gorder]

Well for an over simplified example with XML.

If you hit the controller the service will execute and the before advice will run resulting in the following output:

INFO : com.sample.app.advice.BeforeAdvice - Advice before the service
INFO : com.sample.app.service.SampleServiceImpl - Hello World!

I assume you are using STS, if you are create a new project from the spring-mvc project template that will generate the structure and the jsp and controller and most of the config. I started with this so you could easily reproduce it. I did change the spring version to 3.1.2

Now here is what I put in my root context

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	xmlns:aop="http://www.springframework.org/schema/aop"
	xsi:schemaLocation="http://www.springframework.org/schema/aop http://www.springframework.org/schema/aop/spring-aop-3.1.xsd
		http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.1.xsd">
	
	<!-- Root Context: defines shared resources visible to all other web components -->
	
	<aop:config>
		<aop:aspect ref="beforeAdvice">
			<aop:pointcut id="servicePointcut" expression="execution(* com.sample.app.service.SampleService.sayHello(..))"/>
			<aop:before method="doBefore" pointcut-ref="servicePointcut"/>
		</aop:aspect>
	</aop:config>
	
	<bean id="beforeAdvice" class="com.sample.app.advice.BeforeAdvice"/>
	
	<bean id="sampleService" class="com.sample.app.service.SampleServiceImpl"/>
	
</beans>

servlet-context

<?xml version="1.0" encoding="UTF-8"?>
<beans:beans xmlns="http://www.springframework.org/schema/mvc"
	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	xmlns:beans="http://www.springframework.org/schema/beans"
	xmlns:context="http://www.springframework.org/schema/context"
	xmlns:aop="http://www.springframework.org/schema/aop"
	xsi:schemaLocation="http://www.springframework.org/schema/aop http://www.springframework.org/schema/aop/spring-aop-3.1.xsd
		http://www.springframework.org/schema/mvc http://www.springframework.org/schema/mvc/spring-mvc-3.1.xsd
		http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.1.xsd
		http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-3.1.xsd">

	<!-- DispatcherServlet Context: defines this servlet's request-processing infrastructure -->
	<context:component-scan base-package="com.sample.app" />
	
	<!-- Enables the Spring MVC @Controller programming model -->
	<annotation-driven />

	<!-- Handles HTTP GET requests for /resources/** by efficiently serving up static resources in the ${webappRoot}/resources directory -->
	<resources mapping="/resources/**" location="/resources/" />

	<!-- Resolves views selected for rendering by @Controllers to .jsp resources in the /WEB-INF/views directory -->
	<beans:bean class="org.springframework.web.servlet.view.InternalResourceViewResolver">
		<beans:property name="prefix" value="/WEB-INF/views/" />
		<beans:property name="suffix" value=".jsp" />
	</beans:bean>
	
</beans:beans>

My Service interface and implementation

public interface SampleService {

	void sayHello();
}

public class SampleServiceImpl implements SampleService {

	private static final Logger logger = LoggerFactory
			.getLogger(SampleServiceImpl.class);

	public void sayHello() {
		logger.info("Hello World!");
	}
}

My advice

public class BeforeAdvice {

	private static final Logger logger = LoggerFactory
			.getLogger(BeforeAdvice.class);

	public void doBefore() {
		logger.info("Advice before the service");
	}
}

Controller

@Controller
public class HomeController {

	private static final Logger logger = LoggerFactory
			.getLogger(HomeController.class);

	@Autowired
	private SampleService sampleService;

	/**
	 * Simply selects the home view to render by returning its name.
	 */
	@RequestMapping(value = "/", method = RequestMethod.GET)
	public String home(Locale locale, Model model) {
		logger.info("Welcome home! the client locale is " + locale.toString());

		Date date = new Date();
		DateFormat dateFormat = DateFormat.getDateTimeInstance(DateFormat.LONG,
				DateFormat.LONG, locale);

		String formattedDate = dateFormat.format(date);

		model.addAttribute("serverTime", formattedDate);
		sampleService.sayHello();
		return "home";
	}
}

[Campbell Ritchie]

Moving to AOP forum.