While,if-else statements

[jihwan kim]

Hello all!

This is my first post, so please excuse me if my formatting for submission is wrong

I've been working on an assignment that deals with inputting data for an employee time card, then printing out a paycheck. This is suppose to be a loop program where the data input and printing of paychecks doesnt stop until the firstName of DONE is used as a sentinel for stopping the program.

The data input has to be exactly:
first name
last name
Soc sec officeType (city||suburb) unionType (union||non-union) #regularHours payrate #dependents overtime
Ex:
John
Doe
123456789 c n 80 9.55 3 5.5



My question is if I am setting up everything right, and what I could improve on.
Another problem that I am having is that when i compile this program using BlueJ (what I use in school), but working on Notepad++, it doesnt let me input anything, and nothing shows up on my screeen. I tried testing the "DONE" sentinel in the early stages of my program, and it didnt seem to work at all.
I have a lot more questions, but ive asked enough for this post.
Any help is much appreciated!

import java.util.Scanner;
public class assignmentThree {
    public static void main(String[] args) {
        Scanner kbd = new Scanner (System.in);
        int regHour = 0, numDependent; //initialized to 0 because of trial & error with compiling, dont know if its neccessary. 
        double overTime, payRate;
        String firstName, lastName, officeType, unionType, socSec;
       
        firstName = kbd.nextLine();
        while (!(firstName.equals("DONE"))) {
            
            //Enter first and last name
            lastName = kbd.nextLine();
            socSec = kbd.next();
            officeType = kbd.next();
            unionType = kbd.next();
            payRate = kbd.nextDouble();
            numDependent = kbd.nextInt();
            overTime = kbd.nextDouble();
            //System.out.printf("%s %s %s %d %.2f %d %.1f \n", socSec, officeType, unionType, regHour, payRate, numDependent, overTime);
            //^ was trying this method but dont know how to make it so that iam not inputting everything one by one, then getting the output.
        double regPay, overtimePay, grossPay, fedTax, socsecDed, cityTax = 0, unionDues = 0, netPay;
        
        regPay = (regHour * payRate);
        overtimePay = (1.5) * payRate * overTime;
        grossPay = (regPay) + (overtimePay);
        fedTax = (.14) * (grossPay - (13 * numDependent));
        socsecDed = (.052 * grossPay);
        if(officeType.equals("c")) {
            cityTax = (.04) * grossPay;
            }
        else if(officeType.equals("s")) {
            cityTax = (0) * grossPay;
            }
        if(unionType.equals("u")) {
            unionDues = (.0475) * grossPay;
            }
        else if(unionType.equals("n")) {
            unionDues = (0) * grossPay;
            }
        netPay = (grossPay)-(fedTax)-(socsecDed)-(cityTax)-(unionDues);
   
        System.out.println("Please pay name :   " + firstName + lastName);  
        System.out.println("Social Security number: " +socSec);
        System.out.println("regular pay: " +regPay);
        System.out.println("overtime pay: " +overtimePay);
        System.out.println("gross pay: " +grossPay);
        System.out.println("federal tax: " +fedTax);
        System.out.println("social sec. deduction: " +socsecDed);
        System.out.println("city tax: " +cityTax);
        System.out.println("union dues: " +unionDues);
        System.out.println("net pay: " +netPay);
        
        firstName = kbd.nextLine();
    }
    }
}

Thank you
Jihwan Kim

[Greg Brannon]

Here's the input and resulting output from running your program:

greg
brannon
12345678
officetype
non
1.95
12
5.5
Please pay name :   gregbrannon
Social Security number: 12345678
regular pay: 0.0
overtime pay: 16.0875
gross pay: 16.0875
federal tax: -19.58775
social sec. deduction: 0.8365499999999999
city tax: 0.0
union dues: 0.0
net pay: 34.838699999999996

So your program is doing something, or at least waiting for the user to do something, but it's hard to tell without prompts. Adding prompts is the first change I would suggest, if they're allowed. Until you can get the program running in your environment and make some of your own improvements, I don't see much point in offering more suggestions. Let us know when you've gotten it running and ask any additional questions that come from that.

[jihwan kim]

Thank you for the reply Greg

I was surprised that the program ran at all for you considering it didnt work for me.

I've been working on this all day, and although it isnt perfect I think its pretty good so far.

import java.util.Scanner;
import java.util.*;
import java.text.*; // Necessary for date format
public class testingPage {
    public static void main(String[] args) {
        DateFormat fmt = DateFormat.getDateInstance();
        Scanner kbd = new Scanner (System.in);
        int regHour, numDependent; 
        double overTime, payRate,regPay, overtimePay, grossPay, fedTax, socsecDed, cityTax = 0, unionDues = 0, netPay; 
            //Initialized cityTax and unionDues equal to zero, but understand why.
        String firstName, lastName, socSec,officeType, unionType;
        
        
        System.out.print("Employee first Name:  ");
        firstName = kbd.next();
        

        while (!(firstName.equals("DONE"))) { //End sentinel to stop the program when the first name equals DONE.
          
            //Answer prompts asking for personal information
            System.out.print("Employee last name:  ");
            lastName = kbd.next();         
            System.out.print("Employee social security number:  ");
            socSec = kbd.next();
            System.out.print("The character 'c' for city office or 's' for suburban office:  ");
            officeType = kbd.next();
            System.out.print("The character 'u' for union or 'n' for non union member:  ");
            unionType = kbd.next();
            System.out.print("Number of regular hours:   ");
            regHour = kbd.nextInt();
            System.out.print("Hourly pay rate:  ");
            payRate = kbd.nextDouble();
            System.out.print("Number of dependents:  ");
            numDependent = kbd.nextInt();
            System.out.print("Number of overtime hours:  ");
            overTime = kbd.nextDouble();
            System.out.print('\n');
            System.out.println("" +firstName);
            System.out.print("" +lastName);            
            System.out.printf("%s %s %s %d %.2f %d %.1f \n"  ,socSec ,officeType ,unionType ,regHour ,payRate ,numDependent ,overTime); 
                //This is specific for the assignment, Prof wants this format before the pay check is created.
            System.out.print('\n');
                  
            
            //Calculations for employee pay check payment. Check stub.
            regPay = (regHour * payRate);
            overtimePay = (1.5) * payRate * overTime;
            grossPay = (regPay) + (overtimePay);
            fedTax = (.14) * (grossPay - (13 * numDependent));
            socsecDed = (.052 * grossPay);
            if(officeType.equalsIgnoreCase("c")) {
                cityTax = (.04) * grossPay;
            }
            else if(officeType.equalsIgnoreCase("s")) {
                cityTax = (0) * grossPay;
            }
            if(unionType.equalsIgnoreCase("u")) {
                unionDues = (.0475) * grossPay;
            }
            else if(unionType.equalsIgnoreCase("n")) {
                unionDues = (0) * grossPay;
            }
            netPay = (grossPay)-(fedTax)-(socsecDed)-(cityTax)-(unionDues);
            
            //Start of the for loop to ensure astrix (*) formatting, outlining the printed pay check.
            // line 1
            for(int i = 0; i < 79; i++)
				System.out.print("*");
			System.out.print("\n");
            // line 2
			System.out.print("** ");
			System.out.print("xyz corporation");
			for(int i = 0; i < 41; i++)
				System.out.print(" ");
			System.out.print("date: "+fmt.format(new Date()));
			System.out.print(" **\n");
            // line 3
			System.out.print("** ");
			System.out.print("999 john doe street");
			for(int i = 0; i < 54; i++)
				System.out.print(" ");
			System.out.print(" **\n");
            // line 4
			System.out.print("** ");
			System.out.print("ypsilanti, mi. 48197.");
			for(int i = 0; i < 52; i++)
				System.out.print(" ");
			System.out.print(" **\n");
            // line 5
			System.out.print("** ");
			for(int i = 0; i < 73; i++)
				System.out.print(" ");
			System.out.print(" **\n");
            // line 6
			System.out.print("** ");
            System.out.print("Please pay name: " + firstName + " " + lastName);
			for(int i = 0; i < 55-firstName.length()-lastName.length(); i++)  
                            //space adjustment to align with the *, because name lengths can vary.
				System.out.print(" ");
			System.out.print(" **\n");
            // line 7
			System.out.print("** ");
            System.out.print("The amount of: " + (int)(payRate+1.5*payRate) + " dollars, and  0 cents");
			for(int i = 0; i < 36 - String.valueOf((int)(payRate+1.5*payRate)).trim().length(); i++)
				System.out.print(" ");
			System.out.print(" **\n");
            // line 8
			System.out.print("** ");
			for(int i = 0; i < 73; i++)
			     System.out.print(" ");  
			System.out.print(" **\n");
			// line 9
			System.out.print("** ");
			for(int i = 0; i < 32; i++)
				System.out.print(" ");
			System.out.print("signed: ");
			for(int i = 0; i < 33; i++)
				System.out.print(" ");
			System.out.print(" **\n");
			// line 10
			System.out.print("** ");
			for(int i = 0; i < 40; i++)
				System.out.print(" ");
			System.out.print("xyz corp. president");
			for(int i = 0; i < 14; i++)
				System.out.print(" ");
			System.out.print(" **\n");
			// line 11
			System.out.print("** ");
			for(int i = 0; i < 73; i++)
			     System.out.print(" ");  
			System.out.print(" **\n");
			// line 12
			System.out.print("**");
			for(int i = 0; i < 74; i++)
			     System.out.print("-");
			System.out.print(" **\n");
			// line 13
			System.out.print("** ");
			for(int i = 0; i < 73; i++)
			     System.out.print(" ");  
			System.out.print(" **\n");
			// line 14
			System.out.print("** ");
			System.out.print("Social security number:     " +socSec);
			for(int i = 0; i < 36; i++)
			     System.out.print(" ");
			System.out.print(" **\n");
			// line 15
			System.out.print("** ");
			System.out.printf("regular pay:              $    %.2f", +regPay); 
                            //printf to give proper decimal placements, and to keep the remainders.
			for(int i = 0; i < 36; i++)
			     System.out.print(" ");
			System.out.print(" **\n");
			// line 16
			System.out.print("** ");
			System.out.printf("overtime pay:             $    %.2f", +overtimePay);
			for(int i = 0; i < 36; i++)
			     System.out.print(" ");
			System.out.print(" **\n");
			// line 17
			System.out.print("** ");
			System.out.printf("gross pay:                $    %.2f", +grossPay);
			for(int i = 0; i < 36; i++)
			     System.out.print(" ");
			System.out.print(" **\n");
			// line 18
			System.out.print("** ");
			System.out.printf("federal tax:              $    %.2f", +fedTax);
			for(int i = 0; i < 36; i++)
			     System.out.print(" ");
			System.out.print(" **\n");
			// line 19
			System.out.print("** ");
			System.out.printf("social sec. deduction:    $     %.2f", +socsecDed);
			for(int i = 0; i < 36; i++)
			     System.out.print(" ");
			System.out.print(" **\n");
			// line 20
			System.out.print("** ");
			System.out.printf("city tax:                 $     %.2f", +cityTax);
			for(int i = 0; i < 36; i++)
			     System.out.print(" ");
			System.out.print(" **\n");
			// line 21
			System.out.print("** ");
			System.out.printf("union dues:               $     %.2f", +unionDues);
			for(int i = 0; i < 36; i++)
			     System.out.print(" ");
			System.out.print(" **\n");
			// line 22
			System.out.print("** ");
			System.out.printf("net pay:                  $    %.2f", +netPay);
			for(int i = 0; i < 36; i++)
			     System.out.print(" ");
			System.out.print(" **\n");
			// line 23
			System.out.print("** ");
			for(int i = 0; i < 73; i++)
			     System.out.print(" ");  
			System.out.print(" **\n");
			// line 24
			for(int i = 0; i < 79; i++)
				System.out.print("*");
			System.out.print("\n");
			
			
			
			
		            
  
        System.out.print("Please Enter first name:  "); 
            //start of second employees personal information, and pay check sequence. 
        firstName = kbd.next();
        
    }
        if(firstName.equals("DONE")) { //if first name is equal to DONE, then end program.
           System.exit(0);
           System.out.print('\n');
     
    }
}
}

Its pretty messy, and I used the for loops because I didn't know how to insert those *. Thinking back now, I should have just used left/right justifications with printf, but I am not too familiar.

The problem I am encountering now is that when I input a last name with a possible suffix (i.e., Oconnor the 3rd, or, davis III) the program jumps/prints 3 lines, and goes to the unionType prompt.

Employee first Name: John
Employee last name: David the Third
Employee social security numer: The character 'c' for city office or 's' for suburban office: The character 'u' for union or 'n' for non union member:


Is this occurring because of my first printf statement, the fact that its correlating my input space/white space with (%s %s %s)?

 System.out.printf("%s %s %s %d %.2f %d %.1f \n"  ,socSec ,officeType ,unionType ,regHour ,payRate ,numDependent ,overTime); 
//This is specific for the assignment, Prof wants this format before the pay check is created.

Thank you
Jihwan Kim

[Campbell Ritchie]

Welcome to the Ranch

I dislike BlueJ myself, but Notepad++ is an excellent editor.
I have removed some blank lines from your code, and changed all the text to black, because some people find coloured text difficult to read.
I agree about prompts:

System.out.print("Enter name and \u21a9: ");
name = myScanner.nextLine();

\u21a9 looks like this: ↩. If you get strange results with the nextLine method, read this.

But I have the problem with your code that it isn’t object‑oriented. You ought to have a PayCheck class, and probably PaySystem, too. Your main method should be one line long:-

public static void main(String[] args)
{
   new PaySystem(...).start();
}

I think you should start by creating those classes, and working out how to pass information to them.

I would suggest your union field should be boolean, and you can get a boolean directly from the keyboard with a Scanner and one of its methods, but you would have to write true or false.

[fred rosenberger]

In my not so humble opinion, you have too much code here for the state you are in.

When I write code, I NEVER write more than 2-3 lines at a time before I compile/debug/test. And I test it thoroughly. And when I think I"m done testing, i test it more. I make sure what I just wrote works before I do anything else. I try and write lots of methods that each to one thing, and one thing only. Any time you write a program with more than about 10 lines in your main() method, you are doing something wrong.

You really should try and break down your requirements into discrete components. For example, I would write a method that prompts for and gets the input ONE time (and probably exits if the firstname is "done"). I would have a separate method that calls the getInput() method over and over, until the getInput method returns some sentinel value saying "don't call me any more". Another method would print the data out.

The idea is that getting the data once is completely separate from how many times you need to get the data. If I write them as separate methods, if my specs change later (i.e. I need to get a dog's name, age, and breed), I could write a new getInput() method. I don't need to worry about anything else, since the code is compartmentalized.