Parsing file and displaying grouped content

[Kiki Thomas]

I have been working on this stupid code for days. I cannot figure out why I am not getting the correct output. The input file contains:

110001 commercial 500000.00 101
110223 residential 100000.00 101
110020 commercial 1000000.00 107
110333 land 30000.00 105
110442 farm 200000.00 106
110421 land 40000.00 107
112352 residential 250000.00 110

The output should be:



COMMERICAL
FARM
LAND
RESIDENTIAL

101 600000.00
105 30000.00
106 200000.00
107 1040000.00
110 250000.00

BUT all I get is:

COMMERCIAL
FARM
LAND
RESIDENTIAL

package realtor;

		


    import java.io.BufferedWriter;
    import java.io.PrintWriter;
    import java.io.FileWriter;
    import java.io.File;
    import java.io.FileNotFoundException;
    import java.io.IOException;
    import java.text.DecimalFormat;
    import java.util.Scanner;
    import java.util.Set;
    import java.util.TreeSet;
    import java.util.SortedMap;
    import java.util.TreeMap;
  
    /**
     *
     * @author Thomas
     */

    public class Realtor {
        
    DecimalFormat pValue = new DecimalFormat("0.00");
        /**
         * @param args the command line arguments
         */
        public static void main(String[] args)
                throws FileNotFoundException
        {
        // Prompt for the input file name
            Scanner console = new Scanner(System.in);
            System.out.print("Input file: ");
            String inputFileName = console.next();
            BufferedWriter pwfo = null;
      try {
            pwfo = new BufferedWriter(new FileWriter("C:\\Users\\Thomas\\Desktop\\agentReport.txt", true));
            } catch (IOException e) {
            }
            PrintWriter pwo = new PrintWriter(pwfo);
       //Construct property type treeSet
            Set<String> propertyTypes = pTypes(inputFileName);
         // Print property types from treeSet
          for (String type : propertyTypes)
             {
              System.out.println(type);
              pwo.println(type);
         }
          
         //Construct agent ids and values treeSet
               Set<String> agentRpt = agentValue(inputFileName);
       // Print agent Ids and values from key set
            for (String tail: agentRpt)
            {
               {
               System.out.println(tail);
               pwo.println(tail);
               }
            }
             pwo.flush();
             pwo.close();
            }

         /**
            Reads the input file.
            @param inputFileName
            @return the alphabetized property types in uppercase.
         */
         public static Set<String> pTypes(String inputFileName)
            throws FileNotFoundException
            //Construct a tree set to return property types
          {
            Set<String> type = new TreeSet<String>();
            Scanner in = new Scanner(new File(inputFileName));
            // Use delimiters to select specific chars for set
            in.useDelimiter("[1234567890. ]");
            while (in.hasNext())
            {
              type.add(in.next().toUpperCase());
            }
            in.close();
            return type;
          }
         /**
            Reads the input file.
            @param inputFileName
            @returns the Agent id's and corresponding property values.
         */
         public static Set<String> agentValue(String inputFileName)
            throws FileNotFoundException
         {
              TreeSet<String> tail = new TreeSet<String>();
             SortedMap<String, Number> agentValues = new TreeMap<String, Number>();
             Scanner in = new Scanner(new File(inputFileName));
                 String line = inputFileName;
           while (in.hasNextLine())
           {
               try {
             line = in.nextLine();
             String[] fields = line.split("[\\s}]");
             String agentId = (fields [3]);
             Double pValue = Double.parseDouble(fields [2]);
                 if (agentValues.containsKey(agentId))
                {
             pValue += agentValues.get(agentId).doubleValue();
                }
                 agentValues.put(agentId, pValue);
              }catch  (Exception e) {
                                  }
         // Create keyMap with all keys and values
                Set<String> keySet = agentValues.keySet();
                for (String key : keySet)
                    {
                Number value = agentValues.get(key);
                    tail.add(key + ":" + value);
                    }
               }
           return tail;
           }
    }

[John Jai]

Welcome to Javaranch, Kiki Thomas.

When I execute your code I get the below output.

Input file: C:\test\agentReport.txt



COMMERCIAL
FARM
LAND
RESIDENTIAL
101:500000.0
101:600000.0
105:30000.0
106:200000.0
107:1000000.0
107:1040000.0
110:250000.0

But you have mentioned that you see only the property types printed. Could you please verify it again?

The catch block in the code is blank without printing any necessary information on the Exception like below.

catch  (Exception e) {
}

Never have a catch block as blank, else you would never know if the Exception ever occurred. At least print the Exception trace using getStackTrace() method.

Please UseAMeaningfulSubjectLine next time other than "Please HELP". I have fixed it this time for you.

[Kiki Thomas]

Sorry for the post title. I have been very frustrated. I will correct that in the future.

I just re-ran the code and received the same output as previously posted (only titles.) I did add

 StackTraceElement[] trace=e.getStackTrace();
      System.err.println(trace[0].toString());

to the IOException catch. To be clear, I am reading the information from a file called listings.txt then outputting to the agentReport.txt. Both the on screen display and output file both contain the same (lack of) information. I am writing and running this in Netbeans.

[Paul Clapham]

Just put

e.printStackTrace();

in your catch-block. There's no need to do something more complicated which throws away potentially useful information.

[Kiki Thomas]

No errors print when outputting the file, just the incomplete information. I am still only getting:

COMMERCIAL
FARM
LAND
RESIDENTIAL

I have packaged and ran as a jar file in the cmd prompt to eliminate Netbeans.

[Panagiotis Kalogeropoulos]

You should take the following code fragment that exists in agentValue method

// Create keyMap with all keys and values  
            Set<String> keySet = agentValues.keySet();
            for (String key : keySet) {
                Number value = agentValues.get(key);
                tail.add(key + ":" + value);
            }

and put it outside the loop that reads the file (in our case, outside the "while (in.hasNextLine())"). As you can see, you are putting the keys and values correctly into your Map, but every time you read a new line, you add a new value to the tail Set (thus getting duplicate values). By putting it outside the loop, you put in the tail Set the correct values.

I hope this helped you a little bit.

[John Jai]

Kiki,

If you still haven't got the desired output, I advise you to post your modified code, contents of the input file again.