Method not working or operating in program

[Sam Thompson]

Hi everyone

As of right now I am writing a program that will allow me to store data from an event (you will see it is by looking at the code) ino a file.

However, I am having trouble with certain parts of the program. Here is the code below for perusal. In order to help you find and pinpoint the problem, I have posted t0he program along with the Exception class and other class along with it after this posting. I tried to attach them to the Forum but it won't let anything with the .java extension to be uploaded and attached.

What I am having difficulty in particular with is the gameState() method. How I know it isn't working is because it is supposed to ask you for more input as soon as it is called, but it doesn't. It seems as if the main() method just skips it and moves on.

Is there anything I am doing wrong here?

What do I need to do for the gameState() method to be called and run properly?

Whatever help you can provide would be greatly appreciated.

Thank you in advance everyone.

Hope to hear from you soon.

S.T.

PS: If it helps make things easier the gameState() method is on lins 106 - 185 in PokerGenerator and where it is called, is line 230, PokerGenerator also. Thank you so much in advance.

[Sam Thompson]

Poker Player class

package Poker;

import java.util.*;

public class Poker_Player extends PokerGenerator
{
    private int numberOfHands = 0, winCounts = 0, lossCounts = 0, splitPotCounts = 0, buyIns = 0;
    public double bets, rewards, bankRoll = 5.0, smallBlind = 5.0, bigBlind = 10.0;
    
    public boolean involved;
    
    char[] cardRank = {'2','3','4','5','6','7','8','9','0','J','Q','K','A'};
    String[] aces = {"Ace-High", "Ace-Low"};
    String[] suite = {"spades", "hearts", "diamonds", "clubs"};
    
    ArrayList hand = new ArrayList();
    ArrayList winningHands = new ArrayList();
    ArrayList losingHands = new ArrayList();
    String name = null;
    
    public String namePlayer()
    {
        name = rawInput.next();
        return name;
    }
    
    private void setUpHand()
    {
        hand.add(0, suite);
        hand.add(1, cardRank);
        hand.add(2, suite);
        hand.add(3, cardRank);
    }
    
    public ArrayList getHand()
    {
        return hand;
    }
    
    public boolean FOLD()
    {
        System.out.println("Did player fold? y for yes, n for no.");
        String inOrOut = rawInput.next();
        
        if(inOrOut.equals("y"))
            involved = false;
        else
            involved = true;
        
        return involved;
    }

    public double raise(double amount)
    {
        bankRoll = bankRoll - amount;
        return bankRoll;
    }
    
    public double call(double amount)
    {
        double moneyPutIn = this.raise(amount);
        return moneyPutIn;
    }
    
    public double adjustBankRoll(double change)
    {
        boolean win = this.gameResult();
        
        if (win == true)
            bankRoll = bankRoll + change;
        else if (win == false)
            bankRoll = bankRoll - change;
        
        return bankRoll;
    }
    
    private boolean gameResult()
    {
        boolean endResult;
        int state;
        String played;
        
        System.out.println("Did player win or lose?");
        state = rawInput.nextInt();
        if (state == 1)
        {
            endResult = true;
            winCounts++;
            
            System.out.println("What was the winning hand?");
            played = (String) hand.get(0)+(String) hand.get(1) + ","
                    + (String) hand.get(2)+(String) hand.get(3);
            winningHands.add(played);
        }
        else
        {
            endResult = false;
            lossCounts++;
            
            System.out.println("What was the losing hand?");
            played = (String) hand.get(0)+(String) hand.get(1) + ","
                    + (String) hand.get(2)+(String) hand.get(3);
            losingHands.add(played);
        }
        
        return endResult;
    }   
        
    public boolean hasRaised(int verdict)
    {
        boolean yes;
        verdict = rawInput.nextInt();

        if (verdict == 1)
            yes = true;
        else
            yes = false;

        return yes;
    }
    
    public boolean riskItAll(int verdict)
    {
        boolean yes;
        verdict = rawInput.nextInt();
        if (verdict == 1)
            yes = true;
        else
            yes = false;
        
        return yes;
    }

    public boolean hasFolded(int verdict)
    {
        boolean yes;
        verdict = rawInput.nextInt();
        
        if (verdict == 1)
            yes = true;
        else
            yes = false;
        return yes;
    }
    
    public boolean hasCalled(int verdict)
    {
        boolean yes;
        verdict = rawInput.nextInt();
        
        if (verdict == 1)
            yes = true;
        else
            yes = false;
        return yes;
    }
    
    public double resetBankroll()
    {
        bankRoll = 5.0;
        return bankRoll;
    }
    
    public boolean anotherRound(int verdict)
    {
        boolean yes;
        if (verdict == 1)
        {
            yes = true;
        }
        else
        {
            yes = false;
        }
        return yes;
    }

    public int handsDealt(int hands)
    {
        numberOfHands = numberOfHands + hands;
        return numberOfHands;
    }

    public int wins(int victories)
    {
        winCounts = winCounts + victories;
        return winCounts;
    }

    public int losses(int fails)
    {
        lossCounts = lossCounts + fails;
        return lossCounts;
    }

    public int involvement(int plays)
    {
        buyIns = buyIns + plays;
        return buyIns;
    }
}

[Sam Thompson]

Main() method

package Poker;

import java.io.*;
import java.util.*;

public class PokerGenerator
{
    Scanner rawInput = new Scanner(System.in);
    
    public PokerGenerator()
    {
        int i, players = 0;
        double pot;
        pot = 0.0;

        ArrayList table = new ArrayList<Poker_Player>(players);
    }
    
      public ArrayList<Poker_Player> setUpPlayers(int participants)
      {
          int i;
          ArrayList<Poker_Player> table = new ArrayList<Poker_Player>(participants);
          System.out.println("Enter names of all players");
          for (i = 0; i < participants; i++)
          {
                String enterName = rawInput.next();
                Poker_Player currentPlayer = new Poker_Player();
                currentPlayer.name = enterName;
                table.add(currentPlayer);
          }
          
          return table;  
       }
    
    public static ArrayList FLOP()
    {
        Scanner rawInput = new Scanner(System.in);
        
        int i;
        ArrayList initial = new ArrayList();
        System.out.println("Enter the cards on the flop");
        
        for (i = 0; i < 3; i++)
        {
            initial.add(rawInput.next());
        }
        return initial;
    }
    
    public ArrayList nextFLOP(ArrayList initial)
    {
        Scanner rawInput = new Scanner(System.in);
        
        System.out.println("Enter next card flopped");
        String nextCard = rawInput.next();
        initial.add(nextCard);
        
        return initial;
    } //will be used twice after FLOP()
    
    private double adjustPot(double pot, double amount)
    {
        pot = pot + amount;        
        return pot;
    }

    private boolean raiseAction(int verdict, Poker_Player player, double bet, double bankroll,
            double pot)
    {
        boolean raiseIt = false, allIn = false, confirmFold = false;
        boolean raiseConfirmed = true;
        
        try
        {
            final double deductFromBankroll = bet;
            pot = this.adjustPot(pot,deductFromBankroll);
            if (player.bankRoll > 0)
            {
                player.adjustBankRoll(deductFromBankroll);
            }
            else 
            {
                throw new Poker_Exceptions("Out of funds.");
            }
        }
        catch (Poker_Exceptions issue)
        {
                issue.emptyBankroll();
                if (allIn == true)
                {
                    player.riskItAll(1);
                }
                else if (confirmFold == true)
                {
                    player.hasFolded(1);
                    //dataExporter should report this to file
                }
                else
                {
                    System.out.println("Unknown error.");
                }            
        }
        return raiseConfirmed;
    }
    
    public void gameState(ArrayList<Poker_Player> table, 
            int playerInQuestion, double pot, double bet)
    {
        int i, verdict;
        boolean raiseIt = false, calledIt = true, gaveUp = false, allIn = false;
        Poker_Player playerAction;
        playerAction = new Poker_Player();

        for (i = playerInQuestion; i < i%table.size(); i++)
        {
            playerAction = (Poker_Player) table.get(i);
            
            System.out.println("Did " + playerAction.name + " raise? " 
                    + "1 for YES. 2 for NO.");
            int verdictRaise = rawInput.nextInt();
            raiseIt = playerAction.hasRaised(verdictRaise);
            
            System.out.println("Did " + playerAction.name + " call? " +
                    " 1 for YES, 2 for NO.");
            int verdictCall = rawInput.nextInt();
            calledIt = playerAction.hasCalled(verdictCall);
            
            gaveUp = playerAction.FOLD();
            
            if (raiseIt == true)
            {
                boolean raiseOccurred;
                raiseOccurred = this.raiseAction(1, playerAction, bet, playerAction.bankRoll, pot);
                int answer;
                if (raiseOccurred == true)
                {
                    do
                    {
                        i = (i%table.size())+1;
                        Poker_Player nextPlayer = new Poker_Player();
                        nextPlayer = (Poker_Player) table.get(i);
                        
                        System.out.println("Did " + nextPlayer.name + " raise?");
                        System.out.println("Enter 1 for YES, 2 for NO.");
                        answer = rawInput.nextInt();                       
                    }
                    while (i < (i-1)%table.size() && answer == 1);
                }
            }
            
            try
            {
                System.out.println("Player " + playerAction.name + " has called bet of " +
                        bet);
                final double deductFromBankroll = bet;
                pot = this.adjustPot(pot,deductFromBankroll);

                if (playerAction.bankRoll > 0)
                {
                    playerAction.adjustBankRoll(deductFromBankroll);
                }
                else
                {
                    throw new Poker_Exceptions("Out of funds.");
                }
            }
            catch (Poker_Exceptions issue)
            {
                issue.emptyBankroll();
                if (allIn == true)
                {
                    playerAction.riskItAll(1);
                }
                else if (gaveUp == true)
                {
                    playerAction.hasFolded(1);
                    //dataExporter should report this to file
                }
                else
                {
                    System.out.println("Unknown error.");
                }
            }
        }
    }
    
    public static void main(String[] args) throws IOException
    {
        Scanner userEntry = new Scanner(System.in);
        
        System.out.println("How many players are there in the initial game?");
        int peopleInvolved = userEntry.nextInt();
        PokerGenerator recorder = new PokerGenerator();
        ArrayList<Poker_Player> table = new ArrayList<Poker_Player>();
        table = recorder.setUpPlayers(peopleInvolved);
        
        Calendar timekeeper = Calendar.getInstance();
        timekeeper.setTime(timekeeper.getTime());
        int month = timekeeper.get(Calendar.MONTH) + 1;
        int date = timekeeper.get(Calendar.DATE);
        int year = timekeeper.get(Calendar.YEAR);
        String timeStamp = month + "-" + date + "-" + year;
        String fileLocation = "C://Users/sdl36/Desktop/PD_" + timeStamp + ".txt";
        FileWriter dataWriter = new FileWriter(fileLocation);
        
        String sentence = "Game data as of " + month + "/" + date + "/" + year;
        dataWriter.append(sentence + "\r\n");
        dataWriter.append("\t" + "\t" + "\t" + "\t" + "Begin" + "\r\n");
        
        System.out.println(fileLocation);
        ArrayList<String> cardsUp;
        cardsUp = new ArrayList<String>();
        
        boolean gameOngoing;
        gameOngoing = true;
        int boolVal, numberOfPlays = 0;
        double pot = 0.0, bet = 0.0;       
        cardsUp = PokerGenerator.FLOP();
        
        do
        {
            numberOfPlays++;
            dataWriter.append(numberOfPlays + "\t" + "\t" + "\r\n");
            dataWriter.append("Card on the flop" + "\t" + "\t" + "\t" + "\r\n");
            
            System.out.println("Which player is starting the cycle?");
            int i, beginningPlayer = userEntry.nextInt();
            //cycle will move around clockwise starting with player after Big Blind player
            
            recorder.gameState(table, beginningPlayer, pot, bet);
            
            dataWriter.append((String) cardsUp.get(0) + "\t");
            dataWriter.append((String) cardsUp.get(1) + "\t");            
            dataWriter.append((String) cardsUp.get(2) + "\r\n");
            
            recorder.nextFLOP(cardsUp);
            System.out.println(pot);

            System.out.println("Is the poker series over for this date?");
            System.out.println("Press 1 for no, any other number for yes.");

            boolVal = userEntry.nextInt();    

            if (boolVal == 1)
            {
                gameOngoing = true;
            }
            else
            {
                gameOngoing = false;
            }
        }
        while (gameOngoing == true);

        dataWriter.flush();
        dataWriter.close();
    }
}

[Sam Thompson]

Exception class

package Poker;

public class Poker_Exceptions extends Exception
{
    public Poker_Exceptions(String message)
    {
        super(message);
    }
    
    public void emptyBankroll()
    {
        System.out.println("Player has no money left in bankroll. They are either "
                + "already all in or out of the game.");
    }
}

[Campbell Ritchie]

Please check about naming conventions; you should only use _ in package names or CONSTANT_NAMES in upper‑case.
Several of your methods should be tidied up. For example this:-

    private double adjustPot(double pot, double amount)  
    {  
        pot = pot + amount;          
        return pot;  
    }

…appears to do two things. It alters the pot and returns it. A method should do one thing. So this method should have a void return type and should simply alter the amount of the pot. If you need access to the pot amount, use a getPot method.

    private double adjustPot(double pot, double amount)  
    {  
        pot = pot + amount;
    }

    public double getPot()
    {          
        return pot;  
    }

Never use == true, which is error‑prone. Not if (b == true)... nor if (b == false)..., but if (b)... and if (!b)... The versions without the ! are to be encouraged if possible as being easier to read.
You appear to be throwing an Exception and catching it in the same method. That is simply a very inefficient way of executing an if (...)...else..., so you should replace it with an if-else. Your Exception class appears to have a new method. Why? You should probably delete that method and simply give that class constructors and use methods inherited from Exception.
Also get rid of those if (...)b = true; else b = false; blocks.
Maybe you should get the user to enter true or false and use nextBoolean(); then your loop will continue only on true (or TRUE, etc) in line 242.
that main method is much much too long. The ideal length for a main method is one line. You should move 99% of that code out of it into other methods.

[James Boswell]

Sam

Given that the gameState() method contains a lengthy for loop, I would debug your program and confirm what values are being passed into this method. It is likely that the loop is not being executed at all.

I second what Campbell says btw. You should read up on standard Java conventions for naming methods, variables etc.

[Sam Thompson]

Campbell and James:

Thanks for the tips. I do have to brush up on some things I have to admit.

James:

How would I confirm what values are and are not being passed into the gameState() method exactly? Heck, it asks for user input as soon as the for loop starts. To be perfectly honest, I have been having problems with coding this process for the past two weeks and so far this is the closest and best thing I have come up with so far?

What I want to do is to have the user manually enter poker game data into the program to be stored into a .csv or .txt file for later use. However, the conundrum that I have been confounded with is how exactly do you account or program or tell or whatever the computer when players are consecutively raising. That is why I have the do-while loop IN the for loop.

Like example if you have Moe, Larry, Curly and Shemp play poker, and Moe decides to raise by $a. How exactly do you tell the computer if Larry raises after Moe by $b, then Curly by $c? Players could keep raising until FINALLY someone calls and ends the process.

Do you have any suggestions. Code examples would be of great help.

Thank you so much for the input and for the future input I hope to get from you (and anyone else daring enough to tackle this challenge with me haha.)

S.T.

[Stuart A. Burkett]

Sam Thompson wrote:How would I confirm what values are and are not being passed into the gameState() method exactly?

Add these two lines (plus ones to print out any other values you think might be useful) before the loop

System.out.println("playerInQuestion value is " + playerInQuestion);
System.out.println("table.size is " + table.size();  

[Sam Thompson]

I got that now ... and I managed to find the solutions to some problems.

But the for loop still isn't working. Where am I going wrong? I want the program to start at the player the user says.

S.T.

[Stuart A. Burkett]

Sam Thompson wrote:But the for loop still isn't working.

In what way is it 'not working' ?
If it never enters the for loop then the values I suggested you print should tell you why. Once you've worked that out, you will need to either change the values you are passing to the method or change the for loop initialisation and/or condition check.
If it is entering the for loop but not doing what you expect, then you need to tell TellTheDetails.