Convert array to array of arrays

[Sudhir Srinivasan]

My program takes from the user the upper bound (of the primes to be displayed finally) to be the size of the array. The isPrime(int[]) method is called by passing the array containing the primes and non-primes. The method
Original code:

package testEvenMore.myPrograms;

import java.util.Scanner;

public class Prime {

	private static void isPrime(int[] arrayPrime) {
		boolean prime = false;
		boolean result = true;
		
         for (int i = 0; i < arrayPrime.length; i++)
         //loop thru the entire array 
          {
              for(int j = 2; j < i; j++)
              //within the array, traverse to identify the primes 
         	{
                 if (i % j == 0)
                    {
                      prime = false;
                      break;
                   }else {
            	 prime = true;
                   }
                 }
        	 if(result = ((i % 2 != 0 && prime && i > 2) || i == 2))
                 //evaluate, assign and print prime numbers from 2
        	 {
        		 int primes = (result) ? i:0;
        		 System.out.print(primes+ " "); 
        	 } 
             }       
        	    System.out.println("");  
    }
	
	public static void main(String[] args) {
		// TODO Auto-generated method stub
		
		int row = 0;
		int col = 0;
		int maxNum = 0;
		
System.out.println("Enter value upto which prime numbers are displayed: ");
Scanner scan = new Scanner(System.in);
maxNum = scan.nextInt();

int[] array1d = new int[maxNum];
for(int i = 0; i < maxNum; i++)
{
	array1d[i] = i;
}
isPrime(array1d);
	}
}

prints out the primes from this array as shown in the output.
Output:

Enter value upto which prime numbers are displayed: 
100
2 3 5 7 11 13 17 19 23 29 31 37 41 43 47 53 59 61 67 71 73 79 83 89 97 

Continuing with the above example, I modified the program to display the results as an array of arrays (row * col matrix i.e 5 * 5 as the count of primes below 100 is 25). Array of arrays hereafter called 2d array and the array 'array1d' as 1d array for the sake of brevity. The modifications include:

the program takes from the user the number of rows and columns for displaying the primes in 5 * 5 matrix, besides the upper bound

the isPrime method takes in two additional parameters defining the rows and columns i.e isPrime(int[], int, int)

within the method, creating a 2d array 'array2d' of appropriate size

assign each element of the 1d array (containing the prime) to the 2d array by looping thru the same and print the result

The isPrime method modified

package testEvenMore.myPrograms;

import java.util.Scanner;

public class Prime {

	private static void isPrime(int[] arrayPrime,int row,int col) {
		int[][] array2d = new int[row][col];
		boolean prime = false;
		boolean result = true;
/*
 nested for loop to traverse an array of 'row' ints with
 each array containing 'col' ints( i.e 5 rows of 5 column values for each row)
 and display primes in this matrix 
 */
 for(int x = 0; x < row; x++)
  {
       for(int y = 0; y < col; y++)
         {
		
            for (int i = 0; i < arrayPrime.length; i++)
            //for loop to traverse the 1d array
               {
        	 for(int j = 2; j < i; j++) 
         	{
                    if (i % j == 0) 
                     {
                       prime = false;
                       break;
                     }else {
            	 prime = true;
                    }
                  }
        	 if(result = ((i % 2 != 0 && prime && i > 2) || i == 2))
               //to check for primes starting with 2 and assiging to boolean variable 'result'
        	 {
        	      arrayPrime[i] = (result) ? i:0;
/*
 if true, each prime assigned to 1d array element
 each value in the 1d array to go into the 2d array
 */
                         arrayPrime[(x * row) + y] = arrayPrime[i];
                         array2d[x][y] = arrayPrime[(x * row) + y];
        	  } 
                }       
            System.out.print(array2d[x][y]+ " ");
//printing the result as row * col matrix         
           }
	    System.out.println("");
      }
        
  }

and its (wrong) output

Enter value upto which prime numbers are displayed: 
100
Enter no. of rows to display prime numbers: 
5
Enter no. of columns to display prime numbers: 
5
Prime numbers displayed in 5 rows and 5 columns: 
------------------------------------------------------------- 
97 97 97 97 97 
97 97 97 97 97 
97 97 97 97 97 
97 97 97 97 97 
97 97 97 97 97 

Whereas my objective is to print them as

2   3   5  7   11 
13 17 19 23 29
31 37 41 43 47
53 59 61 67 71
73 79 83 89 97 

Could the problem be

my looping structure vis-a-vis 1d array to 2d array and / or

ternary operator in line no.32 of the modified code (I'm aware that java has boolean true or false values only and does not support implicit casting to int values like 1 or 0)

Could any of the forum expert(s) help in resolving this.

Thanks,

Sudhir

[R. Jain]

**** Nested Loop upto 4 levels??? [DANGER]

The code that assigns the prime number to your 2-D array is inside the nested for-loop for iterating the array...
If your :-

array2d[x][y] = someValue;

is inside your loop: -

for(int x = 0; x < row; x++) {
      for(int y = 0; y < col; y++) {
              array2d[x][y] = someValues;
      }
}

You will get the same value for all the cells..

*PS: - Your one method isPrime() is doing so many of task..
1). It is iterating over the array,
2). It is finding which number are primes among them,
3). plus it is creating new 2D array for those prime numbers
4). Finally it is printing the array..

Ideally a single method should do a single job...

Try to separate your task this way.. Life would be comparatively easy..

* Advice : - Before getting onto writing a code on the computer, you should first spend few minutes with pencil and paper..
Bullet down the things you need to do, in a particular order.. And also write how would you do it generally out of the code..
Them, convert those steps into program one step at a time..

[Winston Gutkowski]

Sudhir Srinivasan wrote:Whereas my objective is to print them as
...
Could the problem be...

Actually, the basic problem is that you don't need to convert the array in order to print it out the way you want. So I guess the next question is:
Do you want to know how to convert a simple array to a matrix, or do you simply want to print it out like one?

BTW, could you please edit your post to remove all those enormous lines? It makes your Thread very hard to read; and it's also bad coding practise.
I'd do it for you, but there are tons of them.

I suggest you re-read the UseCodeTags (←click) page. Thoroughly.

Winston

[R. Jain]

Did you read my last post in this topic?? I think I have stated the problem with your code there..

Still, I'll try to help you again.. Look at your 4 level nested for loop..
1). The 2 outer loop is iterating over rows and columns (Generally done to access each cell of a matrix)
2). The inner two for loops is iterating over a 1-D array to find out what numbers are prime..

Problem # 1: - You are running Step#2 completely for each cell.. So, every time you do step#2, you will get the same value.. (The last prime number in your array)
Problem # 2: - Every time you find a Prime number in step#2, you are assigning it to the current cell in the matrix : - array2D[x][y]
But, ultimately, only the last value will be stored in the cell (Since you are running this loop completely for each cell)

What exactly is happening here: - For each cell, you are iterating over the 1D array, and assigning the last prime number to that cell (So, the same value 97).

arrayPrime[(x * row) + y] = arrayPrime[i];  
array2d[x][y] = arrayPrime[(x * row) + y];     /* This is the PROBLEM */ /* It should not be inside your innermost for loop.. */

Now, try to simplify your approach (Preferably, reduce the level of nesting you have for that loop)..
Try to come up with some modification, then see how it works..

[Sudhir Srinivasan]

At the outset, thank you for your response and suggestions.

R. Jain wrote:The code that assigns the prime number to your 2-D array is inside the nested for-loop for iterating the array...
If your :-

array2d[x][y] = someValue;

is inside your loop: -

for(int x = 0; x < row; x++) {
      for(int y = 0; y < col; y++) {
              array2d[x][y] = someValues;
      }
}

You will get the same value for all the cells..

I'm not sure I understand. I need to assign each array element (containing the prime)

array2d[0][0] = 2 array2d[0][1] = 3 array2d[0][2] = 5 array2d[0][3] = 7 array2d[0][4] = 11
-
-
-
-
array2d[5][0] = 73 array2d[5][1] = 79 array2d[5][2] = 83 array2d[5][3] = 89 array2d[5][4] = 97

to the 2d array and print the same in the matrix. Without the nested for loop how do I traverse the columns within each row and
populate with values? Please explain with sample code.

R. Jain wrote:
*PS: - Your one method isPrime() is doing so many of task..
1). It is iterating over the array,
2). It is finding which number are primes among them,
3). plus it is creating new 2D array for those prime numbers
4). Finally it is printing the array..

Ideally a single method should do a single job...

Try to separate your task this way.. Life would be comparatively easy..

You are right. I did do the separation of concerns -

One method to determine whether the number is a prime(from the array of primes and non-primes)

Another method to iterate through the array, call the boolean method with each number
(from the source array) and print the values for which the method returns true

- initially as the code below depicts

//method which calls the boolean isPrimeNum, for each
//number in the source array
private static void isPrime(int[] tab,int rows,int cols) {
		int[][] array2d = new int[rows][cols];
		
         for (int i = 0; i < tab.length; i++) 
          {
            if (isPrimeNum(tab[i], tab)) 
            {      
                System.out.print(tab[i]+" "); 
            }
          }
            	
     }         

//boolean method which returns primes when called by isPrime method
    private static boolean isPrimeNum(int n, int[] numbers) {
        boolean prime = false;
        boolean result = true;
        int i = n;
        for ( ; i < numbers.length; i++) 
        {
          for(int j = 2; j < i; j++) 
        	{
              if (i % j == 0) 
               {
                prime = false;
                break;
               }else {
            	prime = true;
              }
            }
        	if (result = (i % 2 != 0 && prime && i > 2 || i == 2)) 
        	{
             return true;
            }else
            {
             return false;
            }
        }
        return result;     
    }

and its successful output(without the matrix).

Enter value upto which prime numbers are displayed: 
50
Enter no. of rows to display prime numbers: 
5
Enter no. of columns to display prime numbers: 
5
Prime numbers displayed in 5 rows and 5 columns: 
------------------------------------------------------------- 
2 3 5 7 11 13 17 19 23 29 31 37 41 43 47 

I was stuck in the line of code (line no.8)where the boolean method isPrimeNum is called (from the isPrime method), and
not sure how to go about printing the boolean 'true' values as primes in the matrix. So, ended up combining
the lot and net result
How can this be resolved? Much appreciate your suggestions in this regard.

[Sudhir Srinivasan]

R. Jain wrote:Did you read my last post in this topic?? I think I have stated the problem with your code there..

Still, I'll try to help you again..

I was busy replying to your earlier post and with slow internet connection got to see your current post only after I uploaded my response. Will certainly work around my original code as suggested and get back to you.

Many Thanks,

Sudhir

[R. Jain]

Sudhir Srinivasan wrote:

One method to determine whether the number is a prime(from the array of primes and non-primes)

Why you need to pass array the again into the method whose sole purpose is to find whether the passed number is prime or not??

Sudhir Srinivasan wrote:

    if (isPrimeNum(tab[i], tab)) { /* Some Code */ }      

    private static boolean isPrimeNum(int n, int[] numbers);    /* No need to pass the array as a parameter*/

So, ended up combining the lot and net result

You should call your isPrimeNum() method with only one argument (i.e. the number itself which your checking for Prime)..
What you are doing is, iterating over the array (in isPrime() method) and for each number, you are calling the isPrimeNum() method,
and there also, I don't know why, you are iterating over the passed array again..

Your isPrimeNum() should look like this: -

public boolean isPrimeNum(int number) {
          for (int i = 2; i < number; i++) {
                 if (number % 2 == 0) {             /* If the number is divisible by any number between 2 and num - 1, then it is not prime.. */
                        return false;                     /* No need to iterate further.. Just return false */
                 }
          }
           return true;   /* If it reached here. It is prime.. Return true */
}

And call this method from your isPrime() like this: -

public void isPrime(int[] arr, int row, int col) {
        // iterate over arr
        // For each number call ->  isPrimeNum(num);
         if (isPrimeNum(num)) {
                // Add as a next element in matrix..
         }
}

[R. Jain]

Winston Gutkowski wrote:

Sudhir Srinivasan wrote:Whereas my objective is to print them as
...
Could the problem be...

So I guess the next question is:
Do you want to know how to convert a simple array to a matrix, or do you simply want to print it out like one?
Winston

Also Sudhir, consider answering the question earlier asked by Winston..

[Sudhir Srinivasan]

Winston Gutkowski wrote:
Actually, the basic problem is that you don't need to convert the array in order to print it out the way you want. So I guess the next question is:
Do you want to know how to convert a simple array to a matrix, or do you simply want to print it out like one?

It would be of great help if you could explain both concepts.

Winston Gutkowski wrote:
BTW, could you please edit your post to remove all those enormous lines? It makes your Thread very hard to read; and it's also bad coding practise.
I'd do it for you, but there are tons of them.

I suggest you re-read the UseCodeTags (←click) page. Thoroughly.

Winston

I'd uploaded in a hurry and therefore my post ended up with long lines. Sorry. I've trimmed the same and posted again. Hope this enhances the readability for other forum members.

Thanks,
Sudhir

[Campbell Ritchie]

Sudhir Srinivasan wrote: . . . Sorry. I've trimmed the same and posted again. Hope this enhances the readability for other forum members.

Thanks,
Sudhir

Apologoies accepted (). I am afraid reposting does not enhance readability, and reposting different code inside quote tags simply causes confusion. People expect what is in quote tags to be exactly what was posted before.

I think, to recognise your effort, I shall tidy up the code. I shall delete the unnecessary duplications and go back and edit your code to what it ought to have looked like.

[Sudhir Srinivasan]

R. Jain wrote:
You should call your isPrimeNum() method with only one argument (i.e. the number itself which your checking for Prime)..

While you are right about passing just each number, your suggested code vis-a-vis isPrimeNum(int n) method

R. Jain wrote:

private static boolean isPrimeNum(int number) {
        for (int i = 2 ; i < number; i++) 
        {
              if (number % 2 == 0) 
               {
            	  return false;
               }
        }       
        return true;
    }

returns

Enter value upto which prime numbers are displayed: 
50

0 1 2 3 5 7 9 11 13 15 17 19 21 23 25 27 29 31 33 35 37 39 41 43 45 47 49

where, as you're aware, the nos. 0,1,9,15......etc. to name a few are not primes
This could be due to

a) Array passed to isPrime(int[], int, int) contains array elements & their values sequentially i.e from 0 to upperbound-1
b) isPrimeNum(int) when called then checks and returns true for those values that are prime
c) In the for loop i is evaluated against 1st array element value 0. As the condiiton is false, straightaway exits the for loop and
returns true. This is the same when evaluated against 2nd array element value 1.
d) In the case of other array element values, the if construct checks for their divisibility by 2 only (which requires an inner
for loop to check for divisibility by numbers between 2 and arraysize-1......as provided for in my original code).

R. Jain wrote:
Still, I'll try to help you again..
---
---

arrayPrime[(x * row) + y] = arrayPrime[i];    
array2d[x][y] = arrayPrime[(x * row) + y];     /* This is the PROBLEM */ /* It should not be inside your innermost for loop.. */  

Now, try to simplify your approach (Preferably, reduce the level of nesting you have for that loop)..
Try to come up with some modification, then see how it works..

I'm working on modifying the problem area as suggested and get back to you once resolved OR where I'm stuck.

Thank you for your time and patience.

Sudhir

[Sudhir Srinivasan]

Sudhir Srinivasan wrote:

Winston Gutkowski wrote:
Actually, the basic problem is that you don't need to convert the array in order to print it out the way you want. So I guess the next question is:
Do you want to know how to convert a simple array to a matrix, or do you simply want to print it out like one?

It would be of great help if you could explain both concepts.

Winston - Could you please show how to convert a simple array to a matrix.

Thanks,
Sudhir

[R. Jain]

Sudhir Srinivasan wrote:
0 1 2 3 5 7 9 11 13 15 17 19 21 23 25 27 29 31 33 35 37 39 41 43 45 47 49
where, as you're aware, the nos. 0,1,9,15......etc. to name a few are not primes

Ah!! I'm sorry..
Change the (number % 2 == 0) to (number % i == 0) in the for loop.. Then it would work..

[Campbell Ritchie]

Have you come across the Sieve of Eratosthenes for finding prime numbers?

[R. Jain]

Campbell Ritchie wrote:Have you come across the Sieve of Eratosthenes for finding prime numbers?

That was something worth knowing... thanks Campbell

[Campbell Ritchie]

You’re welcome The Sieve is in many of the basic programming books.

[Sudhir Srinivasan]

Sudhir Srinivasan wrote:

R. Jain wrote:
What exactly is happening here: - For each cell, you are iterating over the 1D array, and assigning the last prime
number to that cell (So, the same value 97).


arrayPrime[(x * row) + y] = arrayPrime[i];
array2d[x][y] = arrayPrime[(x * row) + y]; /* This is the PROBLEM */ /* It should not be inside your innermost for loop.. */



Now, try to simplify your approach (Preferably, reduce the level of nesting you have for that loop)..
Try to come up with some modification, then see how it works..

I'm working on modifying the problem area as suggested and get back to you once resolved.......

Success! I've got the desired output by using the

isPrimeNum(int) method to determine the number is prime........refer my previous post

isPrime(int[], int, int) method to iterate over the source array, call the boolean method with each number
(from the source array)........refer my previous post

and

assign the next element, for which the method returns true, to each cell of the matrix.

[sidebar]break the innermost loop after primality is established. Each element to be stored as 1d array
elements of the 2d array within the outer nested loop[/sidebar]

Finally, use the outer nested loop (the loop used to iterate over the rows and columns) again to initialize each
2d array element by the 1d array elements (of the 2d array) and print the primes stored thereof........by setting the
loop structure properly, the results can be displayed for 'n' rows * columns and not restricted to the 5 * 5 I had
started out with.

I know the last 2 points seem confusing given the level of nesting but can be overcome [by modifying the loop
structure thru trial & error as I'd done and] as shown by the sample outputs

2 * 2 and 10 * 10 matrices:

Enter value upto which prime numbers are displayed - Enter 0 to exit: 
10
Enter no. of rows to display prime numbers: 
2
Enter no. of columns to display prime numbers: 
2
Prime numbers displayed in 2 rows and 2 columns: 
----------------------------------------------------------------------- 
2 3 
5 7 

Enter value upto which prime numbers are displayed - Enter 0 to exit: 
545
Enter no. of rows to display prime numbers: 
10
Enter no. of columns to display prime numbers: 
10
Prime numbers displayed in 10 rows and 10 columns: 
---------------------------------------------------------------------------
2 3 5 7 11 13 17 19 23 29 
31 37 41 43 47 53 59 61 67 71 
73 79 83 89 97 101 103 107 109 113 
127 131 137 139 149 151 157 163 167 173 
179 181 191 193 197 199 211 223 227 229 
233 239 241 251 257 263 269 271 277 281 
283 293 307 311 313 317 331 337 347 349 
353 359 367 373 379 383 389 397 401 409 
419 421 431 433 439 443 449 457 461 463 
467 479 487 491 499 503 509 521 523 541 
Enter value upto which prime numbers are displayed - Enter 0 to exit: 
0
 

Regards,

Sudhir

[R. Jain]

That's good.. Nice to see that you were working on that code for so long..
Normally I forget about a code that old..