saved records in a database from servlet.

[Ritesh raushan]

i am beginner .

1-i have created servlet program which takes username,password,hobby,gender and saved in a database .
but except username all saved(username column is blank for every entry and all other column filled).

2-i have commented on the statement of(if(password.equals("cnfrmPassword")) and at last i wrote a else statement) matching password and conform password and when i uncommented then always output come that (password and confrmpassword didn't match)even i give same password..
please help me.
thanks

import javax.servlet.*;
import java.io.*;
import java.sql.*;
public class RegisterUser extends GenericServlet
{String gender;
String hobby,hobb;
public void service(ServletRequest req,ServletResponse resp)throws ServletException,IOException{
String username=req.getParameter("uname");
String password=req.getParameter("pwd");
String cnfrmPassword=req.getParameter("pwd1");
String toSubmit=req.getParameter("s");
String gend=req.getParameter("gnd");
if(gend.equals("M"))
gender="Male";
else
gender="Female";
String hobbies[]=req.getParameterValues("cbx");
if(hobbies[0].equals("cb"))
hobby="Reading,";
else
hobb=hobbies[1];
hobby+="Playing";
//if(password.equals("cnfrmPassword")){
if(toSubmit.equals("submit")){
try{
Class.forName("oracle.jdbc.driver.OracleDriver");
Connection con=DriverManager.getConnection("jdbc:oracle:thin:@localhost:1521:orcl","scott","tiger");
PreparedStatement pstmt=con.prepareStatement("insert into register values(?,?,?,?)");
pstmt.setString(1,username);
pstmt.setString(2,password);
pstmt.setString(3,gender);
pstmt.setString(4,hobby);
pstmt.executeUpdate();}
catch(Exception e){
e.printStackTrace();}
}//if tosubmit
//}//if password
/*else{
PrintWriter ps=resp.getWriter();
ps.println("password and conformpassword did n't match");}*/
}}

[nir sharma]

post your jsp file also.

(if(password.equals("cnfrmPassword"))

here cnfrmPassword is treated as a string and not a variable.
this should be :

(if(password.equals(cnfrmPassword))

Also try to debug and check whether you are getting username value in servlet from jsp or not.

[Saket Kumar Sinha]

Just a suggestion
setting DataSource in web.xml and then using getDataSource method for javax.sql.DataSource is better way for connecting to DataBase

[Ashwin Sridhar]

Probably the name of the username field and the one you are using in the getParameter may be different. Try debugging by using System.out after you receive the parameters in your servlet.

[Ashwin Sridhar]

 

Just a suggestion
setting DataSource in web.xml and then using getDataSource method for javax.sql.DataSource is better way for connecting to DataBase

Using a datasource would be efficient in case of multiple connections. in the sense when you have a pool of connections and want them to be used judiciously.

In case of single connection, I would connect using DriverManager.

Correct me if am wrong.

[Ritesh raushan]

thank you so much its working...