How many prime Exist between two numbers?

[Niloo Rad]

I have to count, how many prime numbers exist, but it give me wrong answer: Exactly 1254 prime numbers exist between 1 and 10,000.

can you tell me why? Thank you!

public class test {
	
	// Global Constants
    final static int MIN_NUMBER = 1;
    final static int MAX_PRIME = 10000;
    final static int MAX_FACTORIAL = 12;
    final static int MAX_LEAPYEAR = 4000;
  
    //Global Variable
    static int a,b,c;
	//static String []myNumbers = new String[3];
	
public static void main (String[] args) {
	//String []myNumbers = {args[0],args[1],args[2]};
		
		for(int i =0; i< args.length; i++){}
			if(validateInput(args[0],args[1],args[2])){
			countPrimes(a);
			
			}
	}
			
					
//Validate User Input
	public static boolean validateInput(String value1,String value2,String value3){
		boolean isValid = false;
				
		try{
			try{
				try{
			a = Integer.parseInt(value1);
				if(!withinRange(a,MIN_NUMBER, MAX_PRIME)) {
					 System.out.println("The entered value " + value1 +" is out of range [1 TO 10000].");
			}
				isValid = true; 		
				
			}
			catch(Exception ex) { 
				 System.out.println("The entered value " + value1 + " is not a valid integer.  Please try again.");
					}	
		
			b = Integer.parseInt(value2);
				if(!withinRange(b,MIN_NUMBER, MAX_FACTORIAL)) {
					System.out.println("The entered value " + value2 +" is out of range [1 TO 12].");
		}
				isValid = true;	
			}
	catch(Exception ex) { 
				System.out.println("The entered value " + value2 + " is not a valid integer.  Please try again.");
}
		
			c = Integer.parseInt(value3);
			if(!withinRange(c,MIN_NUMBER, MAX_LEAPYEAR)) {
				System.out.println("The entered value " + value3 +" is out of range [1 TO 4000].");
	}
			isValid = true;	
		}
catch(Exception ex) { 
			System.out.println("The entered value " + value3 + " is not a valid integer.  Please try again.");
}	
			
	        return isValid;     
	}
	

		
//Check the value within the specified range
		private static boolean withinRange(int value ,int min, int max){
		boolean isInRange = true; 
	    			    
	     if(value < min || value > max){
	         isInRange = false; 
	       }
		return isInRange;
		}
		
		
				
		
		// Verify Prime Number
					private static boolean isPrime(int prime) {
						for(int i = 2; i < Math.sqrt(prime) ; i++) {
				            if ((prime % i) == 0) {
				            	return false;
				             }
							  
				           }
						return true;
				     }
				    
						
					// Calculate Prime
					private static int countPrimes(int number){
						int count =0;
												
						for(int i=2; i<=MAX_PRIME; i++)	{
							if(isPrime(i)){
							count++;
							}
										
					}
					System.out.println("Exactly "+  count + " prime numbers exist between "+number + " and 10,000.");
					return count;	
									
					}
		
		
}
			
		

Result:

Exactly 1254 prime numbers exist between 1 and 10,000.

[Winston Gutkowski]

Niloo Rad wrote:something is wrong with my code and i can't figure it out! will you help me to find it?

Well, you haven't given us all of it. Where is MAX_PRIME defined? Without that and your isPrime() method, it's a bit tough to work out exactly what's wrong.

However, there is one simple optimization: you DON'T have to check every number.
In fact, (tip) ALL primes greater than 3 are equal to 6k ± 1, where k is a positive integer.

Winston

[Niloo Rad]

JUST UPDATED MY CODE

[Campbell Ritchie]

Niloo Rad wrote:JUST UPDATED MY CODE

Don’t That makes Winston’s reply look nonsense. It means nobody can work out the changes. Please repost the original code and a new post with the changes. And read this.

[Roger Wolfenden]

How about this...

[complete solution removed]

[Winston Gutkowski]

Niloo Rad wrote:JUST UPDATED MY CODE

And I'm afraid it's still wrong. What does isPrime(49), or indeed isPrime(9), return?

Winston

[Roger Wolfenden]

@Winston would you like to elaborate on what is wrong with the code?

isPrime(9) = 29

isPrime(49) = 229

Interesting too, I notice that my code has been removed by @Winston. I'm just wondering why. Have I broken some code of etiquette?

[Edit by Winston] See below.

[Winston Gutkowski]

Roger Wolfenden wrote:How about this...

Hi Roger.

I'm sure your motives were great, but we don't like people to post ready-made solutions here - particularly in the 'Beginners' forum.
It's much better to guide someone to their own solution. Please read the NotACodeMill (←click) page.

I've kept your original post, and if my colleagues ask me to, I'll restore it.

Thanks.

Winston

[Winston Gutkowski]

Roger Wolfenden wrote:@Winston would you like to elaborate on what is wrong with the code?

isPrime(9) = 29

isPrime(49) = 229

I was referring to Niloo's code, not yours, and specifically to his isPrime() method.

Winston

[Roger Wolfenden]

OK @Winston understand and accept your logic.

FYI, I too am a newbie but quite liked the, "Let's find all the primes between 0 and 1000 challenge." Hence my code.

[Winston Gutkowski]

Roger Wolfenden wrote:OK @Winston understand and accept your logic.

No probs. And please, feel free to help. We just don't like beginners to be spoon-fed.

Winston

[Wendy Gibbons]

so you pass in 3 numbers assign them to variables with very bad names a,b,c so we have no idea what you intended to do with them, you then do nothing with them.

the controlling loop in countPrimes always goes from 2 to MAX_PRIME.

this is just a nice layout thing...
you do not need to indent the validation try catch blocks within each other

// this is just code like, not actual code

try{
   a = parseInt(input1);
catch(numberformatexception e){
  e.printStackTrace();
  output nice user friendly message
}

try{
  b = parseInt(input2);
catch(numberformatexception e){
  e.printStackTrace();
  output nice user friendly message
}

try{
  c = parseInt(input3);
catch(numberformatexception e){
  e.printStackTrace();
  output nice user friendly message
}

[Campbell Ritchie]

This sounds like a project Euler question. Is it?
I would suggest you create an array and use a sieve of Eratosthenes to work out whether each number is prime. Then count the primes. 0 and 1 don’t count. Much more effecient than an isPrime method.