Struts 2 addActionError problem

[shashi wagh]

In my struts 2 application when I set any action error in interceptor Like this

ValidationAware action = (ValidationAware)invocation.getAction();
action.getActionErrors().clear();
action.addActionError( errorMsg );

for next onward All request goes to Input result and not for searches for success or even not goes into Action class


I m using Struts 2, Tiles

[Nishan Patel]

HI..

I am not sure about this but you can invoke addAction error in Action class and set error message there.

Thanks,
Nishan Patel.

[Tom Rispoli]

I'm not sure what you mean by this:

for next onward All request goes to Input result and not for searches for success or even not goes into Action class

Since you're saying you aren't getting to your action class I'm wondering if you are not calling invocation.invoke(); or are calling it conditionaly.

[shashi wagh]

Thanks for the reply.

Steps I m folloeing
1. When first time I hit Login page
(It does not thro' inteceptor direct action class) it works fine.
2. For validating user I have written Interceptor. If invalid login then I am setting actionError message and redirect to Login page with action error. It also works fine.
3. But after I set action error If any other user tries to login page It does not hit my action class and Looks for result name=input in my struts.xml file

  
<interceptors>
<interceptor name="LoginInterceptor" class="LoginInterceptor"/>
</interceptors>

<action name="Login" class="LoginAction">
<param name="actionPerformed">getUserType</param>
    <result type="tiles" >Login</result>
    <result type="tiles" name="input">Login</result>
    <result type="tiles" name="error">ErrorPage</result>
        </action>
        
        
        <action name="ValidateUser" class="LoginAction">
        <param name="actionPerformed">getTopMenu</param>
        <interceptor-ref name="defaultStack" />
        <interceptor-ref name="LoginInterceptor"></interceptor-ref>
        <result name="login" type="redirect-action">
<param name="actionName">Login</param>
           </result>
<result type="redirect-action" name="CORP">
<param name="actionName">FindBooking</param>
</result>
<result type="redirect-action" name="JF">
<param name="actionName">raSearch</param>
<param name="menuId">11</param>
</result>
    <result type="tiles">Home</result>
    <result type="tiles" name="error">ErrorPage</result>
        </action>

Even I m setting actionError in Action facing the same problem.

[Tom Rispoli]

Do you have any class level data members definded for your interceptor? Seeing the code for the interceptor might help. particulary how it decides if it should return a result itself or continue on to the next interceptor.

[shashi wagh]

Hi Tom, Thnaks for replya

Didn't get U but I have the My interceptor like This

  
 
public class LoginInterceptor implements Interceptor, StrutsStatics
{
 
private static final long serialVersionUID = 1L;
 
private ICRMWFacade commonFacade;
private String actionPerformed;
 
Logger logger = Logger.getLogger( CrmwConstant.LOGGER_CONSTANT );
 
String menuId;
 
String username = "";
String password = "";
String roletype = "";
 
Map< String, String > mapUser;
List< ? > userProfileList;

UserProfileVO userProfileVO;
 

List< String > menuRights;
 

int intLoginAttempts = 1;
 
public void init()
{
}
 
public void destroy()
{
}
 
/***
 *  Validates the user Id and password
 *  also check the User role
 *  and store user data and rights into Session 
 */
public String intercept( ActionInvocation invocation ) throws Exception
{
 
logger.info( "Login Interceptor Start" );
 
final ActionContext context = invocation.getInvocationContext();
HttpServletRequest request = (HttpServletRequest)context.get( HTTP_REQUEST );
 
username = request.getParameter( CrmwConstant.USERNAME );
password = request.getParameter( CrmwConstant.PASSWORD );
roletype = request.getParameter( CrmwConstant.ROLETYPE );
 
HttpSession session = request.getSession( true );
 
userProfileVO = (UserProfileVO)session.getAttribute( CrmwConstant.USER_PROFILE );
 
String strLoginAttempts = (String)session.getAttribute( CrmwConstant.LOGIN_ATTEMPT );
strLoginAttempts = strLoginAttempts == null ? "1" : strLoginAttempts;
 
intLoginAttempts = Integer.parseInt( strLoginAttempts );
 
mapUser = new HashMap< String, String >();
mapUser.put( CrmwConstant.USERNAME, username );
mapUser.put( CrmwConstant.PASSWORD, password );
mapUser.put( CrmwConstant.ROLETYPE, roletype );
mapUser.put( CrmwConstant.LOGIN_ATTEMPT, ( "" + intLoginAttempts ) );
 
username = username == null ? "" : username;
password = password == null ? "" : password;
roletype = roletype == null ? "" : roletype;
 
if ( !username.equals( "" ) && !password.equals( "" ) && !roletype.equals( "" ) )
userProfileVO = null;
 
if ( userProfileVO == null )
{
 
if ( !username.equals( "" ) )
{
// The user has not logged in yet.
// Is the user attempting to log in right now?
if ( intLoginAttempts > 0 )
{
//Validating User
Map mapLogin = (Map)getCommonFacade().callService( mapUser, getActionPerformed() );
 
String errorMsg = (String)mapLogin.get( CrmwConstant.LOGIN_ERROR_MSG );
 
errorMsg = errorMsg == null ? "" : errorMsg;
 
if ( errorMsg.equals( "" ) )
{
userProfileVO = (UserProfileVO)mapLogin.get( CrmwConstant.USER_PROFILE );
menuRights = (List< String > :wink: mapLogin.get( CrmwConstant.USER_RIGHTS );
 
session.setAttribute( CrmwConstant.USER_PROFILE, userProfileVO );
session.setAttribute( CrmwConstant.USER_RIGHTS, menuRights );
 
return invocation.invoke();
}
else
{
session.setAttribute( CrmwConstant.LOGIN_ATTEMPT, ( "" + ( ++intLoginAttempts ) ) );
session.setAttribute( CrmwConstant.LOGIN_ERROR_MSG, errorMsg );
 
/*ValidationAware action = (ValidationAware)invocation.getAction();
 
action.getActionErrors().clear();
 
action.addActionError( errorMsg );*/
return Action.LOGIN;
}
}
logger.info( "Login Interceptor End" );
return Action.LOGIN;
}
else
{
session.setAttribute( CrmwConstant.LOGIN_ERROR_MSG, CRMWUtility.getMessage( "SESSION_TIME_OUT" ) );
return CrmwConstant.SESSION_TIME_OUT_RESULT;
}
}
else
{
 
/*boolean haveRights = false;
String menuId = request.getParameter(CrmwConstant.MENU_ID);

List<String> userRights = (ArrayList<String> :wink:  session.getAttribute(CrmwConstant.USER_RIGHTS);

for (Iterator<String> iterator = userRights.iterator(); iterator.hasNext() :wink:  {
String right = (String) iterator.next();


if(CRMWUtility.getMenuId(right).equals( menuId )){
haveRights = true;
break;
}

}

logger.info("Login Interceptor End");

if(haveRights){
return invocation.invoke();
}else{
return Action.LOGIN;
}*/
 
return invocation.invoke();
 
}
 
}
 

 
}