Row Selection isn't that slick? Why?

[Jacky Luk]

When I click on a row, it doesn't respond, I have to click it twice to activate that row. Why? how come row selection is that slow reflex?

 jTable1.setCellSelectionEnabled(false);
         jTable1.setRowSelectionAllowed(true);
         jTextID.setEnabled(false);
         jTable1.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
         header = jTable1.getTableHeader();
         header.setUpdateTableInRealTime(true);
         header.setReorderingAllowed(true);
         jTable1.setAutoCreateRowSorter(true);
         jTextAge.setEnabled(false);
         jTable1.setFillsViewportHeight(true);
         
        

Is that the jTable can't distinguish between row and cell selections?

Thanks
Jack

[Michael Dunn]

that snippet works OK for me - clicking a cell highlights the row, and puts focus border around cell.

unless you're talking about edit mode - that requires the extra click.

[Jacky Luk]

Michael Dunn wrote:that snippet works OK for me - clicking a cell highlights the row, and puts focus border around cell.

unless you're talking about edit mode - that requires the extra click.

http://youtu.be/zrhJWoKtOs4

The mouse clicks don't work well....
Thanks
Jack

[Michael Dunn]

sorry, but I'll read it here, not at youtube.

i.e. post the code here

[Jacky Luk]

Michael Dunn wrote:sorry, but I'll read it here, not at youtube.

i.e. post the code here

I've got something additionally to that
Somethimes the table requires a double click to select it
Sometimes the mouse event just got eaten

jTable1.addMouseListener(new MouseAdapter() {

            @Override
            public void mouseClicked(MouseEvent e) {
                 int row = jTable1.getSelectedRow();               
                    if (row >= 0)
                    {
                         if (jTable1.getValueAt(row, 0) != null)
                         {
                             jTextID.setText(jTable1.getValueAt(row, 0).toString().trim());
                         }
                         else
                         {
                             jTextID.setText("".trim());
                         }
                         if (jTable1.getValueAt(row, 1) != null)
                         {
                             jTextFirstName.setText(jTable1.getValueAt(row, 1).toString().trim());
                         }
                         else
                         {
                             jTextFirstName.setText("".trim());
                         }

                         if (jTable1.getValueAt(row, 2) != null)
                         {
                             jTextLastName.setText(jTable1.getValueAt(row,2).toString().trim());
                         }
                         else
                         {
                             jTextLastName.setText("".trim());
                         }

                         if (jTable1.getValueAt(row, 3) != null)
                         {
                             jTextHKID.setText(jTable1.getValueAt(row,3).toString().trim());
                         }
                         else
                         {
                             jTextHKID.setText("".trim());
                         }

                         if (jTable1.getValueAt(row, 4) != null)
                         {
                             jTextPhone.setText(jTable1.getValueAt(row,4).toString().trim());
                         }
                         else
                         {
                             jTextPhone.setText("".trim());
                         }

                         if (jTable1.getValueAt(row, 5) != null)
                         {
                             jTextAddress.setText(jTable1.getValueAt(row,5).toString().trim());
                         }
                         else
                         {
                             jTextAddress.setText("".trim());
                         }

                         if (jTable1.getValueAt(row, 6) != null)
                         {
                             jComboDistrict.setSelectedItem(jTable1.getValueAt(row,6).toString().trim());
                         }
                         else
                         {
                             jComboDistrict.setSelectedIndex(0);
                         }

                         if (jTable1.getValueAt(row, 7) != null)
                         {
                             jFormattedDOB.setText(jTable1.getValueAt(row,7).toString().trim());
                         }
                         else
                         {
                             jFormattedDOB.setText("".trim());
                         }

                         if (jTable1.getValueAt(row, 8) != null)
                         {
                             jTextAge.setText(jTable1.getValueAt(row, 8).toString().trim());
                         }
                         else
                         {
                             jTextAge.setText("".trim());
                         }

                         if (jTable1.getValueAt(row, 9) != null)
                         {
                             jComboSex.setSelectedItem(jTable1.getValueAt(row, 9).toString().trim());
                         }
                         else
                         {
                             // Set nothing instead of defaulting any sex
                             jComboSex.setSelectedIndex(0);
                         }

                         if (jTable1.getValueAt(row, 10) != null)
                         {
                             jTextQualification.setText(jTable1.getValueAt(row, 10).toString().trim());
                         }
                         else
                         {
                             jTextQualification.setText("".trim());
                         }

                         if (jTable1.getValueAt(row, 11) != null)
                         {
                             jTextEmail.setText(jTable1.getValueAt(row, 11).toString().trim());
                         }
                         else
                         {
                             jTextEmail.setText("".trim());
                         }

                         if (jTable1.getValueAt(row, 12) != null)
                         {
                             jComboHospName.setSelectedItem(jTable1.getValueAt(row, 12).toString().trim());
                         }
                         else
                         {
                             jComboHospName.setSelectedIndex(0);
                         }
                    }
                 try {
                     String age =  updateAge();
                     jTable1.setValueAt(age, row, 8);
                 } catch (ParseException ex) {
                     Logger.getLogger(bokss_patient_frame.class.getName()).log(Level.SEVERE, null, ex);
                 }

                 refresh();
            }
        });
 

Thanks
Jack

[Michael Dunn]

before you go any further, dump mouseClicked() - it doesn't always fire.

run this demo, click anywhere on the panel, and you should see this printed out
pressed
released
clicked

note the order

now press and hold the left mouse button (anywhere), drag the mouse a few pixels left right up or down,
now release the left mouse button, and you'll notice mouseClicked() will not fire.

import javax.swing.*;
import java.awt.*;
import java.awt.event.*;

class Testing
{
  public void buildGUI()
  {
    JPanel p = new JPanel();
    JFrame f = new JFrame();
    f.getContentPane().add(p);
    f.setSize(600,400);
    f.setLocationRelativeTo(null);
    f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    f.setVisible(true);
    p.addMouseListener(new MouseAdapter(){
      public void mousePressed(MouseEvent me){
        System.out.println("pressed");
      }
      public void mouseReleased(MouseEvent me){
        System.out.println("released");
      }
      public void mouseClicked(MouseEvent me){
        System.out.println("clicked");
      }
    });
  }
  public static void main(String[] args)
  {
    SwingUtilities.invokeLater(new Runnable(){
      public void run(){
        new Testing().buildGUI();
      }
    });
  }
}

[Jacky Luk]

Michael Dunn wrote:before you go any further, dump mouseClicked() - it doesn't always fire.

Yes, like what you said, mouseClicked didn't fire, what do I do? Do I enter all the logics into the mousePressed Event handler?
Thanks
Jack

[Michael Dunn]

> Do I enter all the logics into the mousePressed Event handler?

most times mousePressed() is the best choice, however, there are times
when mouseReleased() will be better - just a matter of testing.

[Jacky Luk]

Michael Dunn wrote:> Do I enter all the logics into the mousePressed Event handler?

most times mousePressed() is the best choice, however, there are times
when mouseReleased() will be better - just a matter of testing.

Thanks Mike, I am done with it.
Jack

[Tony Docherty]

Micheal is correct in saying the mouseClicked event doesn't always fire but there good reasons for that, ie a mouse click is generally considered to have occurred when the user has pressed and released the mouse button (or pressed and released a touch screen etc) within 'n' pixels of each other within the same component.

Be careful before ditching mouseClicked, there are potential problems with just using mousePressed or mouseReleased. For example if using just mousePressed you can't drag the mouse over several cells of a JTable to highlight multiple cells, users can be surprised when something happens before they have released the mouse button etc. If using just mouseReleased does the user really want the program respond to the event if say they have pressed the mouse button on another component, decided they didn't want to click there so moved the mouse over the JTable and released the button.

[Darryl Burke]

From glancing through the 135 lines of code, it rather looks like you want to respond to a selection change. If that's so, a MouseListener is not the appropriate listener; use a ListSelectionListener instead.

[Darryl Burke]

Tony Docherty wrote:If using just mouseReleased does the user really want the program respond to the event if say they have pressed the mouse button on another component, decided they didn't want to click there so moved the mouse over the JTable and released the button.

That doesn't trigger a MouseListener added to the table. mouseReleased events are generated for the component over which the mouse was pressed.

[Tony Docherty]

Darryl Burke wrote:

Tony Docherty wrote:If using just mouseReleased does the user really want the program respond to the event if say they have pressed the mouse button on another component, decided they didn't want to click there so moved the mouse over the JTable and released the button.

That doesn't trigger a MouseListener added to the table. mouseReleased events are generated for the component over which the mouse was pressed.

Good point. Yes that part of my statement was wrong.
Although the essence of what I was saying still applies, in that by checking for mouseReleased rather than mouseClicked if the mouse is dragged away from the component an event will be handled that the user possibly wouldn't expect.