cards game

[Mona Alsh]

Hi There ,,
I'm trying to solve one of the cards exercise questions using arrays and linkedList.
The question goes like this. modify the program to deal five- cards poker hand.
I'm try to store every 5 cards in an array and then add this array to the ArrayList.
when I print the list to check if it is correctly storing every 5 elements. I found that it just repeating
the same five cards from every ArrayList element

Card Class

public class Card
        {
        private String face;
        private String suit;

        public Card(String cardFace,String cardSuit)
        {
                face = cardFace;
                suit = cardSuit;
        }

        public String toString()
        {
                return face + " of "+suit;
        }

        public String getFace()
        {
                return face;
        }

        public String getSuit()
        {
                return suit;
        }
}

DeckOfCardsClass

import java.util.Random;

public class DeckOfCards
        {
        private Card[] deck;
        private int currentCard;
        private static final int NUMBER_OF_CARDS = 52;

        private static final Random randomNumbers = new Random();

        public DeckOfCards()
        {
                String[] faces = {"Ace", "Deuce","Three","Four","Five","Six"
                ,"Seven","Eight","Nine","Ten","Jack","Queen","King"};
                String[] suits = {"Hearts","Dimonds","Clubs","Spades"};

                deck = new Card[NUMBER_OF_CARDS];
                currentCard = 0;

                //populate deck with cards objects

                for (int count=0; count < deck.length;count++)
                deck[count] = new Card(faces[count % 13],suits[count/13]);
        }

        public void shuffle()
        {
                currentCard = 0;
                //for each card pick another random card and swap them

                for(int first=0; first < deck.length; first++)
                {
                        //select a random numeber between 0-51
                   int second = randomNumbers.nextInt(NUMBER_OF_CARDS);

                   //swap currentcard with randomly selected card
                Card temp = deck[first];
                deck[first] = deck[second];
                deck[second] = temp;
                }
        }

        public Card dealCard()
        {
                if (currentCard < deck.length)
                return deck[currentCard++]; //return current card in the array
                else
                return null; //return null to indicate that all of teh cards were dealt
        }

}

DeckOfCardsTest class

import java.util.*;
public class DeckOfCardsTest
{
        public static void main(String[] args)
        {
                ArrayList<Card[]> handList = new ArrayList<Card[]>();
                DeckOfCards myDeckOfCards = new DeckOfCards();
                myDeckOfCards.shuffle();

         for(int i = 1; i <= 52; i++)
                {
                 System.out.printf("%-19s",myDeckOfCards.dealCard());
                  if (i % 4 == 0)
                        System.out.println();
                }

        myDeckOfCards.shuffle();
        Card[] hand = new Card[5];
        Card[] temp = new Card[52];

        int countEl =0, listCount=0;
           for(int i = 0; i < 52; i++)
                {
                temp[i] = myDeckOfCards.dealCard();
                hand[countEl] = temp[i];
                countEl++;

                if (countEl == hand.length)
                        {
                        handList.add(listCount,hand);
                        listCount++;
                        countEl =0;
                        continue;
                        }
                }      
         
        System.out.println(handList.size());
        System.out.println();
        System.out.println();
        for (int i=0 ; i < handList.size(); i++)
                {
                    Card[] handF = handList.get(i);
                        for (int j = 0; j < handF.length; j++ )
                        System.out.println(handF[j]+" ");
                System.out.println();
                } 
                
        }
}   

I'm concerned with the last class in which I should make the 5 cards in every ArrayList element!!

[Carey Brown]

You need to add a *new* hand array each time to the ArrayList. As it is you keep adding a reference to the same hand array each time.