I am just starting to write Java programs. I wanted to know if there are websites where people reviews each others code and comment about do's and donts ... Books may help but I believe to master a skill you need to practice and get hands dirty. Help will be appreciated.
Thanks in advance.
I wrote a Money Dispenser program
I wanted to know if my approach is correct.
My idea was to write a code that will generate change dispensed for a given amount of money.
ChangeComputer.java - This is where logic resides which decides how much money in what unit is dispensed
I wish I was smart enough to understand your code the moment I saw it. Please describe your code in detail with comments. Nobody has the time to go through lots of code.
To see what it feels like if you were in our position, please describe the code below and tell me if there is a problem in it.
Makes sense ?
Java Newbie with 72% in OCJP/SCJP - Super Confused Jobless Programmer.
I am a "newbie" too. Please verify my answers before you accept them.
I have seen a code review website (sorry I don't remember its name). I think there are such sites out there. And I agree with other buddies, the most important in code review is making it easy to review. Don't post bulky code.
I have a couple questions about the datatypes you've used in your code.
1. What is the reason behind choosing BigDecimal as the object to do the calculations from in ChangeComputer?
2. Why do you declare constants HUNDREDVALUE (etc) as a BigDecimal than use it as an Integer?
I think HUNDREDVALUE should be HUNDRED_VALUE to split the words out so it's readable. Not so bad in this case but imagine if a word could be interpreted two different ways with and without the space.
You are using int in DispenseAmount but BigDecimal in ChangeComputer - this is inconsistent.
I don't see any comments in the code at the beginning of this post. Maybe what you meant is that you put them in your local copy? If so, can you either update or post your changes(I kind of prefer updating since it means less to scroll through but could also be confusing since a lot of the posts that follow are about no-comments) so that we can see what you see?
At work, I put a comment above every method to describe what that method does. I don't think that's necessarily required for getter/setter methods but it should be done for methods that do any logic. Then I can skim code and see at-a-glance what this method is supposed to do, rather than figuring it out every time. Picture yourself six months in the future. If you needed to tell someone what this code does and you had only 3 minutes to look at the code before describing it to them, would you be able to do it? Would you be able to make changes to the code easily? Use these as a guideline for how many comments to put in. For a beginning programmer, that's usually a lot of comments (at least it was for me).
Everything is theoretically impossible, until it is done. ~Robert A. Heinlein
All of the world's problems can be solved in a garden - Geoff Lawton. Tiny ad:
RavenDB is an Open Source NoSQL Database that’s fully transactional (ACID) across your database