Tic Tac Toe - Checking for a winner

[Frederik Bolding]

Hello!

I am currently developing a little Tic Tac Toe game in Java (For Android)
And i am stuck, i want to "CheckForWinner();" but i can't really figure out how...

I am thinking something like: "foreach(Field in Fields)" and then check which has value of 1 and which has a value of 2 :-)


Full game sourcecode:

package com.jc.tictactoe;

import android.app.Activity;
import android.content.Context;
import android.content.res.Resources;
import android.graphics.drawable.Drawable;
import android.os.Bundle;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.ImageView;
import android.widget.Toast;

public class GameP1VSP2 extends Activity {

	// Game
	Boolean gameDone = false;

	// Player
	int curPlayer = 1;

	// Clickable Images
	ImageView row1_field1_img;
	ImageView row1_field2_img;
	ImageView row1_field3_img;
	ImageView row2_field1_img;
	ImageView row2_field2_img;
	ImageView row2_field3_img;
	ImageView row3_field1_img;
	ImageView row3_field2_img;
	ImageView row3_field3_img;

	// FIELDS
	Field row1_field1 = new Field(1, false);
	Field row1_field2 = new Field(2, false);
	Field row1_field3 = new Field(3, false);
	Field row2_field1 = new Field(1, false);
	Field row2_field2 = new Field(2, false);
	Field row2_field3 = new Field(3, false);
	Field row3_field1 = new Field(1, false);
	Field row3_field2 = new Field(2, false);
	Field row3_field3 = new Field(3, false);

	@Override
	protected void onCreate(Bundle savedInstanceState) {
		super.onCreate(savedInstanceState);
		setContentView(R.layout.game);

		row1_field1_img = (ImageView) findViewById(R.id.row1field1);
		row1_field2_img = (ImageView) findViewById(R.id.row1field2);
		row1_field3_img = (ImageView) findViewById(R.id.row1field3);
		row2_field1_img = (ImageView) findViewById(R.id.row2field1);
		row2_field2_img = (ImageView) findViewById(R.id.row2field2);
		row2_field3_img = (ImageView) findViewById(R.id.row2field3);
		row3_field1_img = (ImageView) findViewById(R.id.row3field1);
		row3_field2_img = (ImageView) findViewById(R.id.row3field2);
		row3_field3_img = (ImageView) findViewById(R.id.row3field3);

		BindClickables();
	}

	private void BindClickables() {

		row1_field1_img.setOnClickListener(new OnClickListener() {
			public void onClick(View v) {

				ClickField(1, 1);

			}
		});

		row1_field2_img.setOnClickListener(new OnClickListener() {
			public void onClick(View v) {

				ClickField(1, 2);

			}
		});

		row1_field3_img.setOnClickListener(new OnClickListener() {
			public void onClick(View v) {

				ClickField(1, 3);

			}
		});

		row2_field1_img.setOnClickListener(new OnClickListener() {
			public void onClick(View v) {

				ClickField(2, 1);

			}
		});

		row2_field2_img.setOnClickListener(new OnClickListener() {
			public void onClick(View v) {

				ClickField(2, 2);

			}
		});

		row2_field3_img.setOnClickListener(new OnClickListener() {
			public void onClick(View v) {

				ClickField(2, 3);

			}
		});

		row3_field1_img.setOnClickListener(new OnClickListener() {
			public void onClick(View v) {

				ClickField(3, 1);

			}
		});

		row3_field2_img.setOnClickListener(new OnClickListener() {
			public void onClick(View v) {

				ClickField(3, 2);

			}
		});

		row3_field3_img.setOnClickListener(new OnClickListener() {
			public void onClick(View v) {

				ClickField(3, 3);

			}
		});

	}

	private void ChangePlayer() {
		if (curPlayer == 1) {
			curPlayer = 2;
		}

		else if (curPlayer == 2) {
			curPlayer = 1;
		}

		Context context = getApplicationContext();
		CharSequence text = "Its Player" + curPlayer + "'s turn!";
		int duration = Toast.LENGTH_SHORT;

		Toast toast = Toast.makeText(context, text, duration);
		toast.show();

	}

	private void CheckForWinner() {

		if (gameDone == false) {

			if (row1_field1.getPressed() == true
					&& row1_field2.getPressed() == true
					&& row1_field3.getPressed() == true
					&& row2_field1.getPressed() == true
					&& row2_field2.getPressed() == true
					&& row2_field3.getPressed() == true
					&& row3_field1.getPressed() == true
					&& row3_field2.getPressed() == true
					&& row3_field3.getPressed() == true) {

			}
		}
	}

	private void IllegalMove() {

		Context context = getApplicationContext();
		CharSequence text = "The move cannot be done!";
		int duration = Toast.LENGTH_SHORT;

		Toast toast = Toast.makeText(context, text, duration);
		toast.show();

	}

	private Drawable GetPlayer() {
		Resources res = this.getResources();
		if (curPlayer == 1) {
			Drawable player1 = res.getDrawable(R.drawable.x);
			return player1;
		}

		if (curPlayer == 2) {
			Drawable player2 = res.getDrawable(R.drawable.o);
			return player2;
		}

		return null;
	}

	private void ClickField(int row, int field) {

		if (row == 1) {
			if (field == 1) {
				if (row1_field1.getPressed() == false) {
					row1_field1_img.setImageDrawable(GetPlayer());
					row1_field1.setPressed(true);

					if (curPlayer == 1) {
						row1_field1.setValue(1);
					} else if (curPlayer == 2) {
						row1_field1.setValue(2);
					}

					ChangePlayer();
				} else {
					IllegalMove();
				}

			}

			if (field == 2) {

				if (row1_field2.getPressed() == false) {
					row1_field2_img.setImageDrawable(GetPlayer());
					row1_field2.setPressed(true);

					if (curPlayer == 1) {
						row1_field2.setValue(1);
					} else if (curPlayer == 2) {
						row1_field2.setValue(2);
					}

					ChangePlayer();
				} else {
					IllegalMove();
				}

			}

			if (field == 3) {

				if (row1_field3.getPressed() == false) {
					row1_field3_img.setImageDrawable(GetPlayer());
					row1_field3.setPressed(true);

					if (curPlayer == 1) {
						row1_field3.setValue(1);
					} else if (curPlayer == 2) {
						row1_field3.setValue(2);
					}

					ChangePlayer();
				} else {
					IllegalMove();
				}
			}

		}

		if (row == 2) {
			if (field == 1) {

				if (row2_field1.getPressed() == false) {
					row2_field1_img.setImageDrawable(GetPlayer());
					row2_field1.setPressed(true);

					if (curPlayer == 1) {
						row2_field1.setValue(1);
					} else if (curPlayer == 2) {
						row2_field1.setValue(2);
					}

					ChangePlayer();
				} else {
					IllegalMove();
				}
			}

			if (field == 2) {

				if (row2_field2.getPressed() == false) {
					row2_field2_img.setImageDrawable(GetPlayer());
					row2_field2.setPressed(true);

					if (curPlayer == 1) {
						row2_field2.setValue(1);
					} else if (curPlayer == 2) {
						row2_field2.setValue(2);
					}

					ChangePlayer();
				} else {
					IllegalMove();
				}
			}

			if (field == 3) {

				if (row2_field3.getPressed() == false) {
					row2_field3_img.setImageDrawable(GetPlayer());
					row2_field3.setPressed(true);

					if (curPlayer == 1) {
						row2_field3.setValue(1);
					} else if (curPlayer == 2) {
						row2_field3.setValue(2);
					}

					ChangePlayer();
				} else {
					IllegalMove();
				}
			}
		}

		if (row == 3) {
			if (field == 1) {

				if (row3_field1.getPressed() == false) {
					row3_field1_img.setImageDrawable(GetPlayer());
					row3_field1.setPressed(true);

					if (curPlayer == 1) {
						row3_field1.setValue(1);
					} else if (curPlayer == 2) {
						row3_field1.setValue(2);
					}

					ChangePlayer();
				} else {
					IllegalMove();
				}
			}

			if (field == 2) {

				if (row3_field2.getPressed() == false) {
					row3_field2_img.setImageDrawable(GetPlayer());
					row3_field2.setPressed(true);

					if (curPlayer == 1) {
						row3_field2.setValue(1);
					} else if (curPlayer == 2) {
						row3_field2.setValue(2);
					}

					ChangePlayer();
				} else {
					IllegalMove();
				}
			}

			if (field == 3) {

				if (row3_field3.getPressed() == false) {
					row3_field3_img.setImageDrawable(GetPlayer());
					row3_field3.setPressed(true);

					if (curPlayer == 1) {
						row3_field3.setValue(1);
					} else if (curPlayer == 2) {
						row3_field3.setValue(2);
					}

					ChangePlayer();
				} else {
					IllegalMove();
				}
			}

		}
		CheckForWinner();
	}
}

Pastebin: Clicky

Thanks in advance!

- Frederik

[Mikcha Makkes]

you can either make an algorithm or >>just check the rows<<