File Upload using SPRING REST API

[Vinay Dinakar]

Hi,

I am trying to upload file using POSTMAN REST client. i have configured Content-Type=multipart/form-data;boundary=---------------------------sdjkahdj294919323195 and file=<file.txt>

This is my controller.

@RequestMapping(value = "/uploadfile", method = RequestMethod.POST)
    public @ResponseBody String upload(@RequestParam("file") MultipartFile file) {
		//@RequestParam("file") MultipartFile
	//	MultipartFile file = null;
		//System.out.println("GetPageDetail.upload():"+name);
		System.out.println("GetPageDetail.upload():"+file.getOriginalFilename());
		InputStream is = null;
		OutputStream out = null; 
		try {
			
			System.out.println("GetPageDetail.upload() 12");
			if (!file.isEmpty()) {
                byte[] bytes = file.getBytes();
                System.out.println("GetPageDetail.upload() size: "+bytes.length);
			}
			/*if (request instanceof MultipartHttpServletRequest)
		       {
		           MultipartHttpServletRequest multipartRequest =
		                        (MultipartHttpServletRequest) request;
		           MultipartFile file = multipartRequest.getFile("file");
		           InputStream input = file.getInputStream();
		           // do the input processing
		         
		        }*/
			//is = request.getInputStream();
			/*is = file.getInputStream();
			byte[] b = new byte[1024];
			out = new FileOutputStream(new File("C:\\tmp\\upload.txt"));
			//out.write(b);
			int read = 0;            
            while ((read = is.read(b)) != -1) {
                out.write(b, 0, read);
            }*/
            
			
		} catch (IOException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} finally{
			
			try{
				if(out != null){
					out.close();
				}
				if(is != null){
					is.close();
				}
			}catch(IOException io){
				io.printStackTrace();
			}
			
		}
		
		
		return null;
    }

Added this in spring.xml

<bean id="multipartResolver"
    class="org.springframework.web.multipart.commons.CommonsMultipartResolver">

    
    <property name="maxUploadSize" value="10000000"/>
    
    </bean>

But when i send url http://localhost:8080/myapp/rest/uploadfile.json , i am getting HTTP Status 400 - The request sent by the client was syntactically incorrect ().

Can anyone help in finding the mistake.

Thanks in advance
Vinay

[bala nannaka]

I think the issue is with the URL. Please check once as this bean cannot be identied with the given URL.

And one more thing the way you are handling the file stream would be problem for huge files.we need to take help of disk file to store it temporarly
please see below code if it is useful for you or not
boolean isMultipart = ServletFileUpload.isMultipartContent(request);


if (isMultipart) {

FileItemFactory factory = new DiskFileItemFactory();
ServletFileUpload servletFileUpload = new ServletFileUpload(factory);
servletFileUpload.setSizeMax(-1);

try {

List items = servletFileUpload.parseRequest(request);
Iterator iter = items.iterator();
while (iter.hasNext()) {
FileItem item = (FileItem) iter.next();
if (!item.isFormField()) {
String fileName = item.getName();
long fileSize = item.getSize();
String contentType = item.getContentType();
InputStream is = item.getInputStream();