not able to implement Clone

[amit cha]

I have 4 classes....given below

public class Linked implements Cloneable {
	Node head;
	Node tail;
Vehicle v=null;
	Node a;
	public boolean isEmpty()
	{
		return head==null;
	}
	public void insert(Vehicle veh)
	{
		Node newnode=new Node(veh);
		if(isEmpty())
			{
			head=newnode;
			tail=newnode;
			}
			else
			{
			tail.next=newnode;
			tail=newnode;
			}
		} 
	public Object clone()
	{
		Vehicle v=new Vehicle();
		Linked obj=new Linked();
		while(head!=null)
		{
			v=(Vehicle) head.data;
			Node node=new Node(v);
			
		}
		
		
		
	}
	public Object clone()	
		try {
			
			Linked nObj= (Linked) super.clone();
			nObj.data =()head.clone();
			return nobj;
		} catch (CloneNotSupportedException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		
		}
		public Node delete()
	{
		
		if(head==null)
			tail=null;
		else
		head=head.next;
		return head; 
	       }
	      public void display()
	       {
		Node currentNode=head;
		while(currentNode != null)
		{
		currentNode.display();
		currentNode=currentNode.next;
		
		}
		}
		}

public class Node
{
	Object data;
	Node next;
	Node accept;
	Node(Vehicle veh)
	{
		data=veh;
		next=null;
	}
	public void display() {
		
		System.out.println(data);
	}
	}

public class Test
	{
	public static void main(String[] args) {
	Vehicle car1=new Vehicle("nano",123.132,143.5);
	Vehicle car2=new Vehicle("tata",3434.23,4342.34);	
	Vehicle car3=new Vehicle("maruti",342.45,67.67);	
	Linked list= new Linked();
	list.insert(car1);
	list.insert(car2);
	list.insert(car3);
	list.display();
	System.out.println(list);	
	Linked list1=(Linked)list.clone();
	System.out.println("copied list is=");
	list1.display();

public class Vehicle {
	String owner;
	double changeInSpeed;
	double directionOfSpeed;
	Vehicle(String owner,double changeInSpeed,double directionOfSpeed)
	{
		this.owner=owner;
		this.changeInSpeed=changeInSpeed;
		this.directionOfSpeed=directionOfSpeed;
	}
	Vehicle()
	{
		
	}
	@Override
	public String toString() {
		return "Vehicle [owner=" + owner + ", changeInSpeed=" + changeInSpeed
				+ ", directionOfSpeed=" + directionOfSpeed + "]";
	}
	
}

[Added code tags - see UseCodeTags for details]

how can i apply clone to this...

[Campbell Ritchie]

That code is difficult to understand because you have not indented it consistently. Please post it correctly indented and spaced, so we can all see where one method ends and the next begins. It looks as if you have two clone() methods in the same class the way you have written it.
You also need to consider what sort of fields your classes have:

1: All primitives or immutable reference types, or

2: Some fields are mutable reference types

In case 1 you can use a shallow clone, but in case 2 you need a deep clone.

[Matthew Brown]

Hi Amit. Welcome to the Ranch!

I've added code tags to your code to make it easier to read (see UseCodeTags for instructions on how to do that) - but it still really needs formatting properly.

Anyway, can you give more detail about what your problem is? The first thing you need to decide is how you want cloning to behave. Do you want a shallow clone (meaning you keep the same Node/Vehicle objects)? If so then super.clone() does just what you want, and all you need to do is implement Cloneable and override clone() to make it coderanch. Or do you want it to be a deep clone? In that case, the first thing you need to do is make each of those Cloneable (or provide some other way of making a copy).

Once you've worked out how you want it to behave, the general approach is:

- Implement Cloneable
- Override clone() to make it public
- In clone(), call super.clone(), then manually perform any additional copying you've decided you need.

(Or ignore Cloneable completely and provide another way of copying, like a copy constructor. A lot of people prefer to do it that way.)


You've also got two clone() methods in your Linked class for some reason.

[amit cha]

public class Linked implements Cloneable
{
Node head;
Node tail;
public boolean isEmpty()
{
return head==null;
}
public void insert(Vehicle veh)
{
Node newnode=new Node(veh);
if(isEmpty())
{
head=newnode;
tail=newnode;
}
else
{
tail.next=newnode;
tail=newnode;
}
}
public Object clone()
{
Vehicle v=new Vehicle();
Linked obj=new Linked();
while(head!=null)
{
v=(Vehicle) head.data;
Node node=new Node(v);
}
}



public Object clone()
try
{

Linked nObj= (Linked) super.clone();
nObj.data =()head.clone();
return nobj;
} catch (CloneNotSupportedException e) {
// TODO Auto-generated catch block
e.printStackTrace();

}

public Node delete()
{

if(head==null)
{
tail=null;
}
else
head=head.next;
return head;
}

public void display()
{
Node currentNode=head;
while(currentNode != null)
{
currentNode.display();
currentNode=currentNode.next;

}
}

}







public class Node
{
Object data;
Node next;
Node accept;
Node(Vehicle veh)
{
data=veh;
next=null;
}
public void display() {

System.out.println(data);
}
}







public class Vehicle
{
String owner;
double changeInSpeed;
double directionOfSpeed;
Vehicle(String owner,double changeInSpeed,double directionOfSpeed)
{
this.owner=owner;
this.changeInSpeed=changeInSpeed;
this.directionOfSpeed=directionOfSpeed;
}
@Override
public String toString() {
return "Vehicle [owner=" + owner + ", changeInSpeed=" + changeInSpeed
+ ", directionOfSpeed=" + directionOfSpeed + "]";
}

}



public class Test
{
public static void main(String[] args)
{
Vehicle car1=new Vehicle("nano",123.132,143.5);
Vehicle car2=new Vehicle("tata",3434.23,4342.34);
Vehicle car3=new Vehicle("maruti",342.45,67.67);
Linked list= new Linked();
list.insert(car1);
list.insert(car2);
list.insert(car3);
list.display();

System.out.println(list);
Linked list1=(Linked)list.clone();
System.out.println("copied list is=");
list1.display();
list.display();
list.delete();
list.display();

}

}


I tried my object list in Test class but it is giving error..

[amit cha]

The class Node , Linked and Test are used for linked list...
Vehicle class object reference is passed to the list.
now all i want is to clone the object..which i have tried...but it is not working ..giving error.
I want shallow clone on the object...

[Winston Gutkowski]

amit cha wrote:The class Node , Linked and Test are used for linked list...
Vehicle class object reference is passed to the list.
now all i want is to clone the object..which i have tried...but it is not working ..giving error.
I want shallow clone on the object...

What...Vehicle? Why?

You said above that you wanted a shallow clone; and in most cases, you achieve that by copying references, not whole objects.
However, I'm still not exactly sure what you want or why you want it, so perhaps you could elaborate.

Winston

[Matthew Brown]

If all you want is a shallow clone, all you need is one clone() method that looks like this:

public Linked clone() {
    return (Linked)super.clone();
}

[amit cha]

@Winston Gutkowski -- vehicle class is just for creating objects ... and those objects are passes to the list..
yes i want shallow clone.. but the problem is when i am trying to clone it

public Object clone()
try
{

Linked nObj= (Linked) super.clone();
nObj.data =()head.clone();
return nobj;
} catch (CloneNotSupportedException e) {
// TODO Auto-generated catch block
e.printStackTrace();

}


is is giving me error...
i know there is something wrong with the above code..i just want to know"What is wrong in the code"

[amit cha]

Sorry Vehicle class initializes the value of the object ... passed from the test class

[Matthew Brown]

amit cha wrote:is is giving me error...
i know there is something wrong with the above code..i just want to know"What is wrong in the code"

You still haven't told us what error you are getting. The error message gives you (and us) a lot of information.

[Campbell Ritchie]

amit cha wrote:Sorry Vehicle class initializes the value of the object ... passed from the test class

What on earth does that mean?

[drac yang]

amit cha wrote:@Winston Gutkowski -- vehicle class is just for creating objects ... and those objects are passes to the list..
yes i want shallow clone.. but the problem is when i am trying to clone it

public Object clone()
try
{

Linked nObj= (Linked) super.clone();
nObj.data =()head.clone();
return nobj;
} catch (CloneNotSupportedException e) {
// TODO Auto-generated catch block
e.printStackTrace();

}



is is giving me error...
i know there is something wrong with the above code..i just want to know"What is wrong in the code"

it's hard to see something from this given snippet especially without exception stack trace.

maybe the following small demo would help a little

public class CloneDemo {
	public static void main(String args[]) {
		TestClone x1 = new TestClone();
		TestClone x2;

		x1.a = 10;
		x1.b = 20.98;

		x2 = x1.cloneTest(); // clone x1

		System.out.println("x1: " + x1.a + " " + x1.b);
		System.out.println("x2: " + x2.a + " " + x2.b);
	}
}

class TestClone implements Cloneable {
	int a;

	double b;

	TestClone cloneTest() {
		try {
			return (TestClone) super.clone();
		} catch (CloneNotSupportedException e) {
			System.out.println("Cloning not allowed.");
			return this;
		}
	}
}