Swing Animation....

[paul beppe]

Hello to all! I have a problem with the animation .... in my program I have 4 images at their speed ... if the first image is scrolling and I click on another image ... does not respect the speed increases ... the speed ... but if before clicking on another image I click "stop" then meets the speed ...

this is code:

Image animation; 
Immagine currentAnimation = new Immagine();
ImageIcon ball_IMG_ICON;
Timer timer2 =  null;
int vel;

JPanel pa = new JPanel() {
	    public void paint(Graphics g) {
			super.paint(g);
			Graphics2D g2d = (Graphics2D) g;
			g.setColor(Color.WHITE);
			g.fillRect(0, 0, 6500, 6500);
			g2d.drawImage(animation, currentAnimation.getX(), currentAnimation.getY(), this); 
			Toolkit.getDefaultToolkit().sync(); 
			g.dispose();

		}
		};
		// in quale direzione inviare l'immagine
		Action paintTimer = new AbstractAction() { 
			public void actionPerformed(ActionEvent e) {			
				currentAnimation.setY(currentAnimation.getY() - 1);
				scrollPA.repaint();
			}
		};
private void Animation(){

if (substring.equals("jpg")) {

timer2 = new Timer(200,paintTimer);

timer2.restart();	
buttonPlay.setVisible(false);
buttonPause.setVisible(true);

buttonPlay.setIcon(imgPlay);
							buttonPlay.addActionListener(new ActionListener() {					
								public void actionPerformed(ActionEvent evt) {
									timer2.start();
									buttonPause.setVisible(true);
									buttonPlay.setVisible(false);
								}
							});
							buttonPause.setIcon(imgPause);
							buttonPause.addActionListener(new ActionListener() {					
								public void actionPerformed(ActionEvent evt) {	
									timer2.stop();							
									buttonPlay.setVisible(true);
									buttonPause.setVisible(false);
									
								}
							});

}

}


class Immagine {

	private int x;
	private int y;

	Immagine() {
		;
	} 

	public int getX() { 
		return x;
	}

	public void setX(int x2) {
		x = x2;
	}

	public int getY() {
		return y;
	}

	public void setY(int y2) {
		y = y2;
	}
	public void moveReset(int value) {  
        y = value;  
    } 
}

where is the error???

Sorry for my English ... I hope I was clear

[Piet Souris]

Hi Paul,

I'm afraid your question is not very clear, no.

There are many remarks to be made, bu first and most important: get your indentation correct!
Without this, it is nearly impossible to follow what is going on. Just look at your code snippet: what do you think it looks like?
I learned myself the following trick, to be applied when a class or method ends in a lot of braces:

public void subroutine() {
   {   // start of brace 1
      .....
      {  // start of brace 2
         ........
       }  // end of brace 2
      .....
   }  // end of brace 1
   ....
} // end of subroutine

Now, for your question about speed. Many things could be wrong here, but the first thing I noticed is this:

See line 30: timer2 has a fixed time interval of 200 ms. In the action there seems to be a constant decrease of the Y value of 1. So where's any speed change supposed to come from?

Well, much more could be said about the code, but I hope you have some clues to get you going.

Greetings,
Piet

[paul beppe]

i write you all code...so you can understand my problem....

import java.awt.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.image.ImageObserver;

import javax.swing.*;

public class GifAnimata extends JFrame  {

	Image animation; 
	Immagine currentAnimation = new Immagine();
	JFrame frame = new JFrame("prova Animazione");
	JButton buttonPause = new JButton("Pause");
	JButton buttonPlay = new JButton("Play");
	JButton buttonImage1 = new JButton("Image1");
	JButton buttonImage2 = new JButton("Image2");
	Timer timer;
	JScrollPane scroll = new JScrollPane();

	
	public GifAnimata() {	
		prova();
		
	}
	public void prova()  {
		ImageIcon img = null;
		/*ImageIcon img = new ImageIcon("c://db/testi/moda.jpg");
		//scroll = new JScrollPane(new JLabel(ball_IMG_ICON));	
		animation = img.getImage();								
		prepareImage(animation, this);
		currentAnimation.setX(10);
		currentAnimation.setY(+250); 		
		prepareImage(animation, this);
		timer = new Timer(100, paintTimer);*/
		
		JPanel p = new JPanel();

		p.add(buttonPlay);
		/*buttonPlay.addActionListener(new ActionListener() {					
			public void actionPerformed(ActionEvent evt) {
				//buttonImage1.addActionListener(this);
				timer.start();
			}
		});*/
		p.add(buttonPause);
		/*buttonPause.addActionListener(new ActionListener() {					
			public void actionPerformed(ActionEvent evt) {
				//buttonImage1.addActionListener(this);
				timer.stop();
			}
		});*/
		p.add(buttonImage1);
		buttonImage1.addActionListener(new ActionListener() {					
			public void actionPerformed(ActionEvent evt) {
				ImageIcon img = new ImageIcon("c://db/testi/moda.jpg");
				animation = img.getImage();								
				prepareImage(animation, this);
				currentAnimation.setX(10);
				currentAnimation.setY(+250); 		
				timer = new Timer(50, new ActionListener() {  				             
		            public void actionPerformed(ActionEvent ae) { 
		            	currentAnimation.setY(currentAnimation.getY() - 1);	
		                frame.repaint(); 
		            } 
		        });
				timer.restart();
				buttonPlay.addActionListener(new ActionListener() {					
					public void actionPerformed(ActionEvent evt) {
						//buttonImage1.addActionListener(this);
						timer.start();
					}
				});
				buttonPause.addActionListener(new ActionListener() {					
					public void actionPerformed(ActionEvent evt) {
						//buttonImage1.addActionListener(this);
						timer.stop();
					}
				});
			}

			private void prepareImage(Image animation,
					ActionListener actionListener) {
				// TODO Auto-generated method stub
				currentAnimation.setY(currentAnimation.getY() - 1);
				frame.repaint();
			}
		});
		p.add(buttonImage2);
		buttonImage2.addActionListener(new ActionListener() {					
			public void actionPerformed(ActionEvent evt) {
				ImageIcon img = new ImageIcon("c://db/testi/grignani.jpg");
				animation = img.getImage();								
				prepareImage(animation, this);
				currentAnimation.setX(10);
				currentAnimation.setY(+250); 		
				timer = new Timer(200, new ActionListener() {  				             
		            public void actionPerformed(ActionEvent ae) { 
		            	currentAnimation.setY(currentAnimation.getY() - 1);	
		                frame.repaint(); 
		            } 
		        });
				timer.restart();
				buttonPlay.addActionListener(new ActionListener() {					
					public void actionPerformed(ActionEvent evt) {
						//buttonImage1.addActionListener(this);
						timer.start();
					}
				});
				buttonPause.addActionListener(new ActionListener() {					
					public void actionPerformed(ActionEvent evt) {
						//buttonImage1.addActionListener(this);
						timer.stop();
					}
				});
			}

			private void prepareImage(Image animation,
					ActionListener actionListener) {
				// TODO Auto-generated method stub
				currentAnimation.setY(currentAnimation.getY() - 1);
				frame.repaint();
			}
		});
		frame.setTitle("Gif Animata");
		frame.setSize(1100, 720);   
		panel.add(new JLabel(img));
        JScrollPane scrollPane = new JScrollPane(panel);
        frame.getContentPane().add(scrollPane, BorderLayout.CENTER);
		frame.add(p, BorderLayout.NORTH);
		frame.setLocationRelativeTo( null );
		frame.setDefaultCloseOperation( JFrame.EXIT_ON_CLOSE );
		frame.setVisible( true );
	}

	JPanel panel = new JPanel() {	
    public void paint(Graphics g) {
		super.paint(g);
		Graphics2D g2d = (Graphics2D) g;
		g.setColor(Color.WHITE);
		g.fillRect(0, 0, 1100, 720);
		g2d.drawImage(animation, currentAnimation.getX(), currentAnimation.getY(), this);
		
		Toolkit.getDefaultToolkit().sync(); 
		g.dispose();

	}
	};
	// in quale direzione inviare l'immagine
	Action paintTimer = new AbstractAction() { 
		public void actionPerformed(ActionEvent e) {			
			//currentBall.setX(currentBall.getX() + 5);
			currentAnimation.setY(currentAnimation.getY() - 1);
			frame.repaint();
		}
	};
	   
   public static void main(String[] args) {
	   GifAnimata ga = new GifAnimata();
   }
}
class Immagine {
	/*
	 * Simple Object class to store the ball's co-ordinates.
	 */
	private int x;
	private int y;

	Immagine() {
		;
	} 

	public int getX() { 
		return x;
	}

	public void setX(int x2) {
		x = x2;
	}

	public int getY() {
		return y;
	}

	public void setY(int y2) {
		y = y2;
	}
}

Example: i click to "buttomImage1" and start animation....if i click to "buttonImage2" when the image is in scroolling i can't to "stop" or "restart" the second animation...whay??? i haven't control on button "pause" and "play"...

this is problem...

[Piet Souris]

Hi Paul,

well, indentation is now a lot better!

I find your code a bit hard to follow, because it is not very well structured. What I suspect to be the trouble is the following:

when you press buttonImage1, then you add anonymous actionlisteners to the pause and play buttons. The same happens when you press buttonImage2.
That means (I think, I have no experience with this) that you now have TWO actionlisteners for both the play and pause buttons.
Adding an actionlistener does just that: add a new actionlistener to whatever was there before. It does not replace the old one(s).
The next thing is that in the AL's you simply redefine a timer by: timer = new(...). I think that the old timer just goes on throwing its old action events, picked
up by the old actionlisteners! Of course, causing a lot of unexpected outcomes.

As I said: since I have never programmed things this way, I can't be sure of my answers. But I should try this:

1) define two actionlisteners for the play and the pause buttons and add these to the two buttons.
2) when pause is clicked, then stop the timer; when play is clicked, restart the timer.
3) in the actionlistener for the two image buttons, first stop the timer, then redefine the timer depending on which button is clicked. Still, maybe it is a lot easier
to define two timers, making sure that at most only one at the time is running

Well, enough for now. Let us know if this was indeed the problem, and whether you got it working. Success!

Piet