Not able to Insert data in SQLite

[udaya krishna]

Hi ,

I have the following code ,but when the method insertLabel() is called from MainActivity ,Logcat throws an exception saying tabel labels has no column named name , eventhough i am creating the column ,please let me know if anything is missing :

import java.util.ArrayList;
import java.util.List;
 
import android.content.ContentValues;
import android.content.Context;
import android.database.Cursor;
import android.database.sqlite.SQLiteDatabase;
import android.database.sqlite.SQLiteOpenHelper;
 
public class DatabaseHandler extends SQLiteOpenHelper {
    // Database Version
    private static final int DATABASE_VERSION = 1;
  
    // Database Name
    private static final String DATABASE_NAME = "spinnerExample";
  
    // Labels table name
    private static final String TABLE_LABELS = "labels";
  
    // Labels Table Columns names
    private static final String KEY_ID = "id";
    private static final String KEY_NAME = "name";
  
    public DatabaseHandler(Context context) {
        super(context, DATABASE_NAME, null, DATABASE_VERSION);
    }
  
    // Creating Tables
    @Override
    public void onCreate(SQLiteDatabase db) {
        // Category table create query
        String CREATE_CATEGORIES_TABLE = "CREATE TABLE " + TABLE_LABELS + "("
                + KEY_ID + " INTEGER PRIMARY KEY," + KEY_NAME + " TEXT)";
        db.execSQL(CREATE_CATEGORIES_TABLE);
    }
  
    // Upgrading database
    @Override
    public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
        // Drop older table if existed
        db.execSQL("DROP TABLE IF EXISTS " + TABLE_LABELS);
  
        // Create tables again
        onCreate(db);
    }
     
    /**
     * Inserting new lable into lables table
     * */
    public void insertLabel(String label){
        SQLiteDatabase db = this.getWritableDatabase();
         
        ContentValues values = new ContentValues();
        values.put(KEY_NAME, label);
          
        // Inserting Row
        db.insert(TABLE_LABELS, null, values);
        db.close(); // Closing database connection
    }
     
    /**
     * Getting all labels
     * returns list of labels
     * */
    public List<String> getAllLabels(){
        List<String> labels = new ArrayList<String>();
         
        // Select All Query
        String selectQuery = "SELECT  * FROM " + TABLE_LABELS;
      
        SQLiteDatabase db = this.getReadableDatabase();
        Cursor cursor = db.rawQuery(selectQuery, null);
      
        // looping through all rows and adding to list
        if (cursor.moveToFirst()) {
            do {
                labels.add(cursor.getString(1));
            } while (cursor.moveToNext());
        }
         
        // closing connection
        cursor.close();
        db.close();
         
        // returning lables
        return labels;
    }
}

[udaya krishna]

Not able to figure out what is the problem here , I am creating a columns called 'name' right? I dont know why it is not able to insert data.

[Swastik Dey]

Use an exception handler for the insertion code, and see if you are getting any exception.

[udaya krishna]

Hi Swastik ,

Its throwing android.database.sqlite.SQLiteException : table labels has no column named nmes(code 1).Still unable to figure out why!!

[udaya krishna]

udaya krishna wrote:Hi Swastik , actual error

Its throwing android.database.sqlite.SQLiteException : table labels has no column named names(code 1).Still unable to figure out why!!

And in getAllLables()

if (cursor.moveToFirst())

is always false when i run in debug mode , so

 labels.add(cursor.getString(1));

is never executed..

[Steve Luke]

udaya krishna wrote:Hi Swastik ,

Its throwing android.database.sqlite.SQLiteException : table labels has no column named nmes(code 1).Still unable to figure out why!!

Is that the exact error message, copy and pasted? Is the code you posted the exact code? Why is the column being used in the error message as nmes and not name like the constant in your code? Note that there are two differences: a missing a and an added s.

If both the code and the error message are correct, then un-install the app and try re-installing it. It could be that the application did not properly close at one point and was left in memory. You make changes but those changes may not be properly reflected in the app that runs. If you are using Eclipse to compile the code, it won't hurt to do a clean build as well - I have seen the build not finish completely but not provide errors either, allowing a bad mix of code to reach the phone which caused 'impossible' errors.

[udaya krishna]

Hi Steve,

Sorry , the exception was a typo as i did not know how to copy and paste from Logcat, but the column names are indeed correct , and yes i have tried building it several times.still no luck