Going from implements Controller to @Controller injection problem

[karl czukoski]

If I have
<bean id="employee" class="springapp.domain.Employee"> <property name="employeeName" value="George"></property> </bean> <bean id="employeeManager" class="springapp.service.SimpleEmployeeManager"> <property name="employee" ref="employee"></property> </bean> <bean name="/hello.htm" class="springapp.web.EmployeeController"> <property name="employeeManager" ref="employeeManager"></property> </bean>

and

public class EmployeeController implements Controller {

	private EmployeeManager employeeManager;
	 
	public ModelAndView handleRequest(HttpServletRequest request,
			HttpServletResponse response) throws Exception {
		
		String modelObject = "model object";
	
		 Map<String, Object> myModel = new HashMap<String, Object>();
		 myModel.put("localStringModelObject", modelObject);

		 employeeManager = this.employeeManager;    
		 employee = employeeManager.getEmployee();  
		  System.out.println("employee " + employee); //prints  employee Employee name: George
		 myModel.put("employeeModelObject", employee);  

	  return new ModelAndView("hello", "modelName", myModel);
	 }

	 //dependency injection to member variable (employeeManager)
	 public void setEmployeeManager(EmployeeManager employeeManager) {
		 this.employeeManager = employeeManager;
	 }
}

the employee property gets set from employeeManager reference

however when I try to use @Controller

<bean id="employee" class="springapp.domain.Employee"> <property name="employeeName" value="George"></property> </bean> <bean id="employeeManager" class="springapp.service.SimpleEmployeeManager"> <property name="employee" ref="employee"></property> </bean> <context:component-scan base-package="springapp.web" /> <!-- <bean name="/hello.htm" class="springapp.web.EmployeeController"> <property name="employeeManager" ref="employeeManager"></property> </bean> -->

and

@Controller
public class EmployeeController /*implements Controller*/ {

	 private EmployeeManager employeeManager;
	 
	@RequestMapping(value="hello.htm")
 	public ModelAndView handleRequest(HttpServletRequest request,
			 HttpServletResponse response) throws Exception {
		
		 String modelObject = "model object";
	
		Map<String, Object> myModel = new HashMap<String, Object>();
		myModel.put("localStringModelObject", modelObject);

		employeeManager = this.employeeManager;    
		employee = employeeManager.getEmployee();  
		 System.out.println("employee " + employee); //prints  employee null
		myModel.put("employeeModelObject", employee);  

	 return new ModelAndView("hello", "modelName", myModel);
	}

	//dependency injection to member variable (employeeManager)
	public void setEmployeeManager(EmployeeManager employeeManager) {
		this.employeeManager = employeeManager;
	}
}

why doesn't the employee property still get set (instead a null pointer exception occurs)?

[H Paul]

1. For @Controller
Would that imply ?
EmployeeController obj=new EmployeeController ();
There is no setEmployeeManager.

2. You need

@Autowired
private EmployeeManager employeeManager;

[karl czukoski]

Put @Autowired at method

	@Autowired
	public void setEmployeeManager(EmployeeManager employeeManager) {
		this.employeeManager = employeeManager;
	}

and seems to be working good now.

If I understand correctly since employeeManager property
<!-- <bean name="/hello.htm" class="springapp.web.EmployeeController"> --> <!-- <property name="employeeManager" ref="employeeManager"></property> @Autowired setEmployeeManager method in EmployeeController --> <!-- </bean> -->
was removed from dispatcher servlet
employeeManager needs to be autowired?

[narendra bhattacharya]

@Autowired will inject the bean instance in the controller. hence removes Null Pointer Exception.