activity doesn't wait untill alertdialog completes

[shawn peter]

I have a main activity.In that activity i called to alertdialog activity.On that alert dialog i give the users to select one from two option.

package com.connection.phonedetails;

import android.app.Activity;
import android.content.Intent;
import android.os.Bundle;
import android.widget.Toast;

public class Test extends Activity {

	private static final int REQUEST_CODE = 10;
	
	 @Override
	    public void onCreate(Bundle savedInstanceState) {
	        super.onCreate(savedInstanceState);
	        //setContentView(R.layout.alert);
	        
	        DatabaseHandler db = new DatabaseHandler(this);
	        
	        Intent intent = new Intent(this,AlertDialogExample.class);
			startActivityForResult(intent,REQUEST_CODE);
			
			
	 }
	
	 @Override
	 protected void onActivityResult(int requestCode, int resultCode, Intent data) {
		
		if (requestCode == 10) {

		     if(resultCode == RESULT_OK){      
		         String result=data.getStringExtra("TYPE");
		         Toast.makeText(getApplicationContext(),"Your sim type iss POST paidddddddddd", Toast.LENGTH_LONG).show();
		     }
		     if (resultCode == RESULT_CANCELED) {    
		    	 Toast.makeText(getApplicationContext(),"Your sim type iss PREEEEE paidddddddddd", Toast.LENGTH_LONG).show();
		     }
		  }
		
		    
		  }
	 
	
}

this is alert dialog activity.

package com.connection.phonedetails;

import android.app.Activity;
import android.app.AlertDialog;
import android.content.Context;
import android.content.DialogInterface;
import android.content.Intent;
import android.os.Bundle;
import android.view.View;
import android.widget.Button;
import android.widget.Toast;

public class AlertDialogExample extends Activity {

	
	// this context will use when we work with Alert Dialog
    final Context context = this;
 
    // just for test, when we click this button, we will see the alert dialog.
    private Button button;
 
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        //setContentView(R.layout.alert);
 
        

        
        /* Alert Dialog Code Start*/     
             AlertDialog.Builder alert = new AlertDialog.Builder(context);
             alert.setTitle("Select Your SIM Type"); //Set Alert dialog title here
             //alert.setMessage("Enter your Name Here"); //Message here
  
             alert.setPositiveButton("Post Paid", new DialogInterface.OnClickListener() {
             public void onClick(DialogInterface dialog, int whichButton) {
              // String value = input.getText().toString();
               // Do something with value!
                 //You will get input data in this variable. 
             	
            	 Toast.makeText(getApplicationContext(),"Post Paid", Toast.LENGTH_LONG).show();
                 //db.addContact(new SimDetails( telephonyManager.getSimSerialNumber(), telephonyManager.getNetworkOperatorName(),"Post"));
                
             	
            	 Intent returnIntent = new Intent();
            	 returnIntent.putExtra("TYPE","POST Paid");
            	 setResult(RESULT_OK,returnIntent);     
            	 finish();
               }
             });
  
             alert.setNegativeButton("Pre Paid", new DialogInterface.OnClickListener() {
               public void onClick(DialogInterface dialog, int whichButton) {
                 // Canceled.
            	   Toast.makeText(getApplicationContext(),"Pre Paid", Toast.LENGTH_LONG).show();
            	  Intent returnIntent = new Intent();
              	 returnIntent.putExtra("TYPE","PRE Paid");
              	 setResult(RESULT_CANCELED,returnIntent);     
              	 finish();
               }
             });
             AlertDialog alertDialog = alert.create();
             alertDialog.show();
        /* Alert Dialog Code End*/        
         
        
       

    }
	/*
    @Override
    public void finish() {
      Intent data = new Intent();
      // Return some hard-coded values
      data.putExtra("TYPE", "Swinging on a star. ");
      data.putExtra("returnKey2", "You could be better then you are. ");
      setResult(RESULT_OK, data);
      super.finish();
    }*/
    
}

this is working fine.Anyway if added the below two line end Oncreate method of the main activity it doesn't wait untill the alert dialog finishes.it goes to contact activity .So i don't have chance to select option from alert dialog.how to avoid this situation?

Intent contact = new Intent(getApplicationContext(),Contacts.class);
			startActivity(contact);

[Ulf Dittmer]

Right: dialogs in Android are asynchronous, they don't stop further code execution. You need to move that code into a separate method that is called only after the user has made her choice.

[shawn peter]

I change the class as below.But it doesn't go to Conatct.xml even i select POST in alert dialog .That mean when control goes to onActivityResult() method it doesn't come to the oncreate method ?I need to know why ?I used debug also ,it doesn't come to the oncreate method.

package com.connection.phonedetails;

import android.app.Activity;
import android.content.Intent;
import android.os.Bundle;
import android.widget.Toast;

public class Test extends Activity {

	private static final int REQUEST_CODE = 10;
	private static  String TYPE = "NONE";
	
	 @Override
	    public void onCreate(Bundle savedInstanceState) {
	        super.onCreate(savedInstanceState);
	        //setContentView(R.layout.alert);
	        
	        DatabaseHandler db = new DatabaseHandler(this);
	        
	        Intent intent = new Intent(this,AlertDialogExample.class);
			startActivityForResult(intent,REQUEST_CODE);
			
			if(TYPE=="POST"){
			Intent contact = new Intent(getApplicationContext(),Contacts.class);
			startActivity(contact);
			}
	 }
	
	 @Override
	 protected void onActivityResult(int requestCode, int resultCode, Intent data) {
		
		if (requestCode == 10) {

		     if(resultCode == RESULT_OK){      
		         String result=data.getStringExtra("TYPE");
		         TYPE="POST";
		         Toast.makeText(getApplicationContext(),"Your sim type iss POST paidddddddddd", Toast.LENGTH_LONG).show();
		     }
		     if (resultCode == RESULT_CANCELED) {  
		    	 TYPE="PRE";
		    	 Toast.makeText(getApplicationContext(),"Your sim type iss PREEEEE paidddddddddd", Toast.LENGTH_LONG).show();
		     }
		  }
		
		    
		  }
	 
	
}

[Ulf Dittmer]

For starters, strings are compared using the "equals" method, not with the "==" operator.

When I said "separate method", I meant exactly that - not the onCreate method.

And when I said "... that is called only after the user made her choice", I meant exactly that. How do you imagine a variable that is set long after onCreate has run could in any way influence the execution of onCreate (even if that were the right thing to do, which it is not)?

[shawn peter]

I have activity A which runs main method.I nned give user to selection.So i used radion buttin with separate activity.I use intent to call that activity.I assign user selection to global varible.The n i need to resumethe first activity .I change my code.So my first activity is this.

public class Test extends Activity implements OnItemSelectedListener{

	private static final int REQUEST_CODE = 10;
	 private Spinner spinner1, spinner2;
	
	@Override
	public void onCreate(Bundle savedInstanceState) {
		super.onCreate(savedInstanceState);
		try{
		setContentView(R.layout.activity_main);
		
		//spinner1 = (Spinner) findViewById(R.id.spinner1);
		//spinner2.setOnItemSelectedListener(this);
		
		Intent intent = new Intent(this, Settings.class);
		startActivity(intent);
		
		Toast.makeText(getApplicationContext(), "TESTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTTT",
				Toast.LENGTH_LONG).show();
		//startActivityForResult(intent, REQUEST_CODE);
		
		}catch(Exception e){
			e.printStackTrace();
		}
	}
	
	

htis is my second activity

package com.example.twotext;

import android.app.Activity;
import android.content.Intent;
import android.os.Bundle;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.RadioButton;
import android.widget.RadioGroup;
import android.widget.Toast;

public class Settings extends Activity  implements OnClickListener{

	private RadioGroup radioSexGroup;
	private RadioButton radioSexButton;
	private Button btnDisplay;

	@Override
	public void onCreate(Bundle savedInstanceState) {
		super.onCreate(savedInstanceState);
		setContentView(R.layout.settings);
		try {
			addListenerOnButton();
			
			
		} catch (Exception e) {
			e.printStackTrace();
		}
	}

	public void addListenerOnButton() {
		//try {
			radioSexGroup = (RadioGroup) findViewById(R.id.radioSex);
			btnDisplay = (Button) findViewById(R.id.btnDisplay);

			btnDisplay.setOnClickListener(this);

	}

	@Override
	public void onClick(View v) {
		int selectedId = radioSexGroup.getCheckedRadioButtonId();

		// find the radiobutton by returned id
		radioSexButton = (RadioButton) findViewById(selectedId);

		
		MyApplication my = (MyApplication)getApplication();
		my.setGlobals(radioSexButton.getText().toString());
		
		Toast.makeText(Settings.this,
				radioSexButton.getText(), Toast.LENGTH_SHORT)
				.show();
		
		Intent intent = new Intent(this, Test.class);
		startActivity(intent);
		
	}
}

but it doesn't work as expected.first activity doesn't wait until second one finished.So what need to change in this code.please help.

[Ulf Dittmer]

If Test expects a result back from Settings, then it should start Settings not with startActivity, but with startActivityForResult - that will allow Settings to pass data back to Test. And then that callback method should do whatever needs doing after the user has made her choice. That way there is also no need to use an Application class for passing around data.

[shawn peter]

its ok.but when the second activity returns values to first activity .then control goes to onActivityResult method.cann't we get control to the again oncreate method after finishing the onActivityResult method on first activity?

[Steve Luke]

sameera liyanage wrote:its ok.but when the second activity returns values to first activity .then control goes to onActivityResult method.cann't we get control to the again oncreate method after finishing the onActivityResult method on first activity?

No.

[Ulf Dittmer]

... and the fact that you're asking the question indicates that you're not yet fully acquainted with the Android Activity lifecycle. I suggest you read through the javadocs of the android.app.Activity class, several times if need be - it explains all this in detail, particularly when the onCreate method will be called (and when it won't).

[shawn peter]

Thanks Ulf and Steve.Actually my problem is like this.I have develop mobile application.There are several network providers.So when the app runs i chcecked the network provider type in oncreate method.I used TelephonyManager->getNetworkOperatorName() to get network operator.Depend on that i used if else to select network operator.

If(A){

}else if(B){

}else if{

....

the problem is my now is ,i need to get the sim type.So i give user to chance select their sim type whether its Pre paid or Post paid.When user select the sim type i saved it .So my problem is now when i used above code it doesn't wait until user selection.I need a way to wait the code runnng until user select his choise.User choise must select only first time.Then i update the database.
If there is a better way to impliment this code please let me know.

[Ulf Dittmer]

Isn't that what this entire topic is about? Please reread my posts carefully, and take the time to consider how you need to change your code in order to incorporate my suggestions.

[shawn peter]

I found this way.I moved all the other codes to another activity and call that activity onActivityResult method.is it correct ?

[Ulf Dittmer]

Sounds way more complicated than it needs to be.

[shawn peter]

anyway we can't spot oncreate methos ,
So first i check the whether user already exist in DB.

if (No)
so inside oncreate i go to another methos and get user choise.

while doing that oncreate may finished.So i have to remove other part of code from oncreate ,because they need the user choise.I moved them to other method.After user selection it goes automatically to
onActivityResult method.So i call the my other part of code there.Isn't ok ?

Else
dirctly called the other method


is this ok?

[shawn peter]

Ulf and Steve ,please help me.

[Ulf Dittmer]

Sounds OK. What happened when you tried it?

[shawn peter]

Thanks Ulf and Steve.It seems working fine.Anyway can you please give me some points to improve my code with performance and standards.below is my maib class code.

package com.connection.phonedetails;

import android.app.Activity;
import android.content.Context;
import android.content.Intent;
import android.os.Bundle;
import android.telephony.TelephonyManager;
import android.widget.Toast;

public class Test extends Activity {

	private static final int REQUEST_CODE = 10;
	private static String TYPE = "NONE";
	TelephonyManager telephonyManager;
	DatabaseHandler db;

	@Override
	public void onCreate(Bundle savedInstanceState) {
		super.onCreate(savedInstanceState);
		// setContentView(R.layout.alert);
		telephonyManager = ((TelephonyManager) getSystemService(Context.TELEPHONY_SERVICE));
		try {
			db = new DatabaseHandler(this);
			SimDetails data = db.getContact(telephonyManager
					.getSimSerialNumber());

			if (data.get_sim_type() == null) {//Ckeck whether the sim is in sqlite database.if not give chance user to select the sim type.

				simType();

			} else {//if user is already in there calls the relavant method
				
				selctSim();

			}

			db.close();
		} catch (Exception e) {
			e.printStackTrace();
		}

	}

	private void selctSim() {

		telephonyManager = ((TelephonyManager) getSystemService(Context.TELEPHONY_SERVICE));
		String operatorName = telephonyManager.getNetworkOperatorName();

		if (operatorName.equalsIgnoreCase("x")) {

			try {

				Intent intent = new Intent(getApplicationContext(),
						X.class);
				startActivity(intent);
				finish();
			} catch (Exception e) {

				e.printStackTrace();
			}

		}else if{
..............................
.....................
                     }
	}

	private void simType() {
		Intent intent = new Intent(this, AlertDialogExample.class);
		startActivityForResult(intent, REQUEST_CODE);
	}

	@Override
	protected void onActivityResult(int requestCode, int resultCode, Intent data) {

		telephonyManager = ((TelephonyManager) getSystemService(Context.TELEPHONY_SERVICE));
		db = new DatabaseHandler(this);
		try {
			if (requestCode == 10) {

				if (resultCode == RESULT_OK) {
					String result = data.getStringExtra("TYPE");
					TYPE = "POST";

					SimDetails post = new SimDetails(
							telephonyManager.getSimSerialNumber(),
							telephonyManager.getSimOperatorName(), TYPE);
					db.addContact(post);
					selctSim();
					
				}
				if (resultCode == RESULT_CANCELED) {
					TYPE = "PRE";

					SimDetails post = new SimDetails(
							telephonyManager.getSimSerialNumber(),
							telephonyManager.getSimOperatorName(), TYPE);
					db.addContact(post);
					selctSim();
					
				}
			}

			
			db.close();
		} catch (Exception e) {
			e.printStackTrace();
		}
	}

}

[shawn peter]

Ulf please help.

[shawn peter]

this is working fine now.I need to know how to improve the code to increase performance and standards.please help me.

[Steve Luke]

Hi Sameera,

The forum isn't really the right place for code reviews. Doing so is time consuming and the people who post here are volunteers, and have their own jobs and projects to work on. You will be better off using the forum for specific questions and answers rather than getting code reviews.