Recursive Search not working

[Joel Keane]

Hi all,

I will start by saying my java is very basic. I have an Android app that is used to display the contents of a certain folder on the device. I have a problem when it comes to search functionality. Currently my user has to select manually which folder to search in so I have multiple activities to display results based on a search filter for each individual folder.

I am not sure why my code doesn't work recursively. When I run it, it just displays a blank screen.

It should show all the files in the folder and subfolders that match the search criteria. I have looked at numerous examples but can't find an answer. What it should do is return an array list of files and when the user clicks on the pdf it opens that file.

my code is:

package com.proceduresyncv2;

import java.io.File;
import java.io.FilenameFilter;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.List;

import com.proceduresyncv2.R;

import android.annotation.TargetApi;
import android.app.ActionBar;
import android.app.ListActivity;
import android.net.Uri;
import android.os.Bundle;
import android.os.Environment;
import android.content.ActivityNotFoundException;
import android.content.Context;
import android.content.Intent;
import android.os.Build;
import android.support.v4.app.Fragment;
import android.support.v4.app.FragmentActivity;
import android.support.v4.app.NavUtils;
import android.util.Log;
import android.view.Gravity;
import android.view.LayoutInflater;
import android.view.Menu;
import android.view.MenuItem;
import android.view.View;
import android.view.ViewGroup;
import android.widget.ArrayAdapter;
import android.widget.ListView;
import android.widget.TextView;
import android.widget.Toast;

public class OperatingProceduresSearch extends ListActivity  implements ActionBar.OnNavigationListener {

    /**
     * The serialization (saved instance state) Bundle key representing the
     * current dropdown position.
     */
	
	private File currentDir;
    private FileArrayAdapter adapter;

	
    private static final String STATE_SELECTED_NAVIGATION_ITEM = "selected_navigation_item";

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
      //  setContentView(R.layout.main);
        
         currentDir = new File(Environment.getExternalStorageDirectory() + "/RTIO");
         fill(currentDir);
        
      

        // Set up the action bar to show a dropdown list.
        final ActionBar actionBar = getActionBar();
        actionBar.setDisplayShowTitleEnabled(false);
        actionBar.setNavigationMode(ActionBar.NAVIGATION_MODE_LIST);
        actionBar.setTitle( "" );

        // Set up the dropdown list navigation in the action bar.
        actionBar.setListNavigationCallbacks(
                // Specify a SpinnerAdapter to populate the dropdown list.
                new ArrayAdapter<String>(
                        getActionBarThemedContextCompat(),
                        android.R.layout.simple_list_item_1,
                        android.R.id.text1,
                        new String[] {
                        	getString(R.string.title_section6),
                        	getString(R.string.title_section1),
                        	getString(R.string.title_section2),
                        	getString(R.string.title_section3),
                        	getString(R.string.title_section4),
                        	getString(R.string.title_section5),
                            getString(R.string.title_section7),
                            getString(R.string.title_section8),
                            getString(R.string.title_section10),

                            getString(R.string.title_section9),
                        }),
                this);
        
        
    }

    private void fill(File f)

    {
    	

     //This gets the searchname Global sting stored in searchname.java     
       File[]dirs = f.listFiles(new FilenameFilter() {
    	   
              	public boolean accept(File dir, String name) {
              		
              		//searchname.searchname = "response";
              		searchname.searchname = searchname.searchname.toUpperCase();
               return name.contains(searchname.searchname);
           	}
      	});

        
       

        this.setTitle(""+f.getName());
        
        
        //this.setTitle(""+f.getName());
        

         List<Option>dir = new ArrayList<Option>();

         List<Option>fls = new ArrayList<Option>();
         

         try{

             for(File ff: dirs)

             {

                if(ff.isDirectory())
                	fill(ff);

                else

                           {
                	SimpleDateFormat sdf = new SimpleDateFormat("dd MMM yyyy");                    // fls.add(new Option(ff.getName(),"Date Modified: "+ff.lastModified(),ff.getAbsolutePath()));
                    fls.add(new Option(ff.getName(),"Date Modified: "+sdf.format(ff.lastModified()), ff.getAbsolutePath()));
                    
                }

             }

         }catch(Exception e)

         {
              

         }
    

         dir.addAll(fls);
      //dir.addAll(dir);

         if(!f.getName().equalsIgnoreCase("sdcard"))

         //dir.add(0,new Option("..","Parent Directory",f.getParent()));

         adapter = new FileArrayAdapter(OperatingProceduresSearch.this,R.layout.file_view,dir);

         this.setListAdapter(adapter);

    }
    
    //****************************    END OF FILL   ***************************************

    


    
    private <T> List<Comparable<? super Comparable<? super T>>> lastModified() {
		// TODO Auto-generated method stub
		return null;
	}

	@Override

    protected void onListItemClick(ListView l, View v, int position, long id) {

        // TODO Auto-generated method stub

        super.onListItemClick(l, v, position, id);

        Option o = adapter.getItem(position);

        if(o.getData().equalsIgnoreCase("folder")||o.getData().equalsIgnoreCase("parent directory")){

      currentDir = new File(o.getPath());
  fill(currentDir);
               

        }

        else

        {

            onFileClick(o);

        }

    }

    private void onFileClick(Option o){

    File pdfFile = new File((o.getAbsolutePath())); 
    Log.w("Joel", "You can read and write to SDcard");
    if(pdfFile.exists()) 
    {
        Uri path = Uri.fromFile(pdfFile); 
        Intent pdfIntent = new Intent(Intent.ACTION_VIEW);
        pdfIntent.setDataAndType(path, "application/pdf");
        pdfIntent.setFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);

        try
        {
            startActivity(pdfIntent);
        }
        catch(ActivityNotFoundException e)
        {
            Toast.makeText(this, "No Application available to view pdf", Toast.LENGTH_LONG).show(); 
        }
    }

}
    
    
    
    /**
     * Backward-compatible version of {@link ActionBar#getThemedContext()} that
     * simply returns the {@link android.app.Activity} if
     * <code>getThemedContext</code> is unavailable.
     */
    
    
    
    @TargetApi(Build.VERSION_CODES.ICE_CREAM_SANDWICH)
    private Context getActionBarThemedContextCompat() {
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.ICE_CREAM_SANDWICH) {
            return getActionBar().getThemedContext();
        } else {
            return this;
        }
    }

    @Override
    public void onRestoreInstanceState(Bundle savedInstanceState) {
        // Restore the previously serialized current dropdown position.
        if (savedInstanceState.containsKey(STATE_SELECTED_NAVIGATION_ITEM)) {
            getActionBar().setSelectedNavigationItem(
                    savedInstanceState.getInt(STATE_SELECTED_NAVIGATION_ITEM));
        }
    }

    @Override
    public void onSaveInstanceState(Bundle outState) {
        // Serialize the current dropdown position.
        outState.putInt(STATE_SELECTED_NAVIGATION_ITEM,
                getActionBar().getSelectedNavigationIndex());
    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.main, menu);
        return true;
    }
    
    protected void launchActivity(int position) {
        switch (position) {
        case 1:
        	Intent intent = new Intent(this, MainActivity.class);
            startActivity(intent);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 2:
        	Intent intent1 = new Intent(this, OperatingProcedures.class);
            startActivity(intent1);
            finish();
              	Log.w("Joel", "Switch Case 2");
                break;
        case 3:
        	Intent intent11 = new Intent(this, OperatingNotices.class);
            startActivity(intent11);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 4:
        	Intent intent111 = new Intent(this, OperatingInstructions.class);
            startActivity(intent111);
            finish();
              	Log.w("Joel", "Switch Case 2");
                break;
        case 5:
        	Intent intent1111 = new Intent(this, GeneralOrders.class);
            startActivity(intent1111);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 6:
        	Intent intent11111 = new Intent(this, TrackCharts.class);
            startActivity(intent11111);
            finish();
              	Log.w("Joel", "Switch Case 2");
                break;
        case 7:
        	Intent intent111111 = new Intent(this, Manuals.class);
            startActivity(intent111111);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 8:
        	Intent intent1111111 = new Intent(this, OperatingStrategies.class);
            startActivity(intent1111111);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 9:
        	Intent intent11111111 = new Intent(this, SearchScreen.class);
            startActivity(intent11111111);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
           
        }
    }
    
    
    
    @Override
    public boolean onNavigationItemSelected(int position, long id) {
    	launchActivity(position);
        return true;
        }
    
    
    
}

I really appreciate any feedback as to why you think the recursion isn't working and how I can fix it please?

Thank you

[Karthik Shiraly]

The problem is in the file filter.

File[]dirs = f.listFiles(new FilenameFilter() {  
    public boolean accept(File dir, String name) {  

         searchname.searchname = searchname.searchname.toUpperCase();  
         return name.contains(searchname.searchname);  
    }  
}); 

searchname is being converted to uppercase, but name remains as it is (probably all lower case). contains() will fail because it does case-sensitive comparison.
Either both should be uppercase or both should be lowercase.

Also a small optimization: Uppercase conversion of searchname is repeated for each and every file in the hierarchy. It can be done just once, by taking it out of accept().

[Joel Keane]

Thank you for your reply.

I don't think that is the issue. Even taking out the filename filter it doesn't display files. If I change the path to search so that it is only searching one folder the search works fine.

For example:

I change:

         currentDir = new File(Environment.getExternalStorageDirectory() + "/RTIO");

to

         currentDir = new File(Environment.getExternalStorageDirectory() + "/RTIO/Operating Procedures");

I get results.

The screenshot for the "/RTIO/Operating Procedures" is:






The screenshot for the "/RTIO" path is:





Now if I add some code in to show the folder details to the .isDirectory() function, when I run the app with the "/RTIO" path it shows the folder names:



So it seems that the problem is with the recursion code - it seems to be finding and listing folders but not listing the files within.

Any suggestions?

Thank you very much

[Joel Keane]

The change you mentioned regarding the filenamefilter did correct one problem I was having. Previously my search results did not display any titles that were in lowercase, however by changing it to

File[]dirs = f.listFiles(new FilenameFilter() {
    	   
              	public boolean accept(File dir, String name) {
              		
              		//searchname.searchname = "response";
              		searchname.searchname = searchname.searchname.toUpperCase();
               return name.toUpperCase().contains(searchname.searchname);
           	}
      	});

now displays all results (both lower and uppercase)

Unfortunately it does not fix my recursion problem though.

[Karthik Shiraly]

Hi Joel, I took one more look and spot one more problem in the lines:

private void fill(File f)  {
   ...
   if(!f.getName().equalsIgnoreCase("sdcard"))  
         adapter = new FileArrayAdapter(OperatingProceduresSearch.this,R.layout.file_view,dir);  
   ...
}

The "adapter" member should ideally *accumulate* all the matches as the function recurses down the file hierarchy. That means "adapter" should be initialized only once before the recursion starts.
However, in this code, it's getting reset on every entry into fill() to a new FileArrayAdapter object.
For example, if the directory structure is

/mnt/sdcard/RTIO (D)
   /Operating Procedures (D)
      - PRC1.pdf (F)
      - PRC2.pdf (F)
   /General Orders (D)

the flow will be

1)   fill #1 ("\RTIO")
2)    dirs = ["Operating Procedures", "General Orders", ...]
3)    for each in dirs
3)      fill #2 ("Operating Procedures")
4)        fls & dir = ["PRC1.pdf", "PRC2.pdf"]
5)        "Operating Procedures" not equal to "sdcard". So "adapter" = new FileArrayAdapter. => adapter = ["PRC1.pdf", "PRC2.pdf"]. Let's call this object "adapter#1"
6)      come out of fill #2
7)      [back in fill #1]
8)      fill #3 ("General Orders")
9)        Note that again "adapter" = new FileArrayAdapter. => adapter = [children of "General Orders"]. Let's call this object "adapter#2"
10)     come out of fill #3
11)    [back in fill #1]
12)   end the for loop of step 3)
13)   fls & dir = empty (ie, "\RTIO has no files under it)
14)   But yet again "adapter" = new FileArrayAdapter. => adapter = [empty]. Let's call this object "adapter#3"
15)  come out of fill #1

So you can see from 5) 9) and 14) that adapter got reset multiple times to new FileArrayAdapter objects, but the last object it got reset to was the empty adapter#3. That is what the ListActivity is seeing, hence "\RTIO" is empty.
It's basically discarding all files in subfolders and showing only files under current folder.

When invoked on "RTIO\Operating Procedures", similarly it'll discard all files under subfolders of "RTIO\Operating Procedures" and show only files directly under it.

There are multiple ways of solving this. I've preferred to accumulate the matches in a List<File>. But you can also accumulate it in adapter itself. Just ensure the accumulating field is not initialized multiple times.
Suggested solution:

class OperatingProceduresSearch {
   /* Accumulate all the matching files in this member. */
   private List<File> allMatches;

   protected void onCreate(Bundle savedInstanceState) {  
     ..
     allMatches = new ArrayList<File>();
     fill("/RTIO");
     // Recursion would have ended now, and all matches are accumulated in "allMatches".
     List<Option> allMatchEntries = getOptionEntries(this.allMatches);
     adapter = new FileArrayAdapter(.., allMatchEntries);
     this.setListAdapter(adapter);
     ...
   }

   private void fill(File f) {
      ...
      allMatches.addAll(fls);
      // Don't do anything with adapter.
   }
}

[Joel Keane]

Hi Karthik,

Firstly let me say thank you very much for taking the time to go through my code and trouble shoot it - it is very much appreciated. Also, thank you for explaining a bit more on the logic of the Array. I have adapted your response to my code and am very close in having a solution. When I run my search code now and leave the search keyword blank it will now show the search results screen with all of all of the folders in the /RTIO folder. So you have helped me make it search recursively :-)

The only problem is that if I put a keyword in to search, the screen is blank - there are no results???

Here is my new adjusted code with the recursive search working. Can you please have a look and see why you think the filename filter might be causing problems when I put a search term in to check against file names?

package com.proceduresyncv2;

import java.io.File;
import java.io.FilenameFilter;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.List;

import com.proceduresyncv2.R;

import android.annotation.TargetApi;
import android.app.ActionBar;
import android.app.ListActivity;
import android.net.Uri;
import android.os.Bundle;
import android.os.Environment;
import android.content.ActivityNotFoundException;
import android.content.Context;
import android.content.Intent;
import android.os.Build;
import android.support.v4.app.Fragment;
import android.support.v4.app.FragmentActivity;
import android.support.v4.app.NavUtils;
import android.util.Log;
import android.view.Gravity;
import android.view.LayoutInflater;
import android.view.Menu;
import android.view.MenuItem;
import android.view.View;
import android.view.ViewGroup;
import android.widget.ArrayAdapter;
import android.widget.ListView;
import android.widget.TextView;
import android.widget.Toast;

public class OperatingProceduresSearch extends ListActivity  implements ActionBar.OnNavigationListener {

    /**
     * The serialization (saved instance state) Bundle key representing the
     * current dropdown position.
     */
	
	private File currentDir;
	
	 /* Accumulate all the matching files in this member. */
    private FileArrayAdapter adapter;

	
    private static final String STATE_SELECTED_NAVIGATION_ITEM = "selected_navigation_item";

     
    
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
      //  setContentView(R.layout.main);
        
           
        // Recursion would have ended now, and all matches are accumulated in "allMatches".  

        List<Option>dir = new ArrayList<Option>();
        List<Option>fls = new ArrayList<Option>();
        adapter = new FileArrayAdapter(OperatingProceduresSearch.this, R.layout.file_view, dir);  
        fill(new File(Environment.getExternalStorageDirectory() + "/RTIO"));
        this.setListAdapter(adapter);   
        
     
      

        // Set up the action bar to show a dropdown list.
        
        final ActionBar actionBar = getActionBar();
        actionBar.setDisplayShowTitleEnabled(false);
        actionBar.setNavigationMode(ActionBar.NAVIGATION_MODE_LIST);
        actionBar.setTitle( "" );

        // Set up the dropdown list navigation in the action bar.
        actionBar.setListNavigationCallbacks(
        		
                // Specify a SpinnerAdapter to populate the dropdown list.
                new ArrayAdapter<String>(
                        getActionBarThemedContextCompat(),
                        android.R.layout.simple_list_item_1,
                        android.R.id.text1,
                        new String[] {
                        	getString(R.string.title_section6),
                        	getString(R.string.title_section1),
                        	getString(R.string.title_section2),
                        	getString(R.string.title_section3),
                        	getString(R.string.title_section4),
                        	getString(R.string.title_section5),
                            getString(R.string.title_section7),
                            getString(R.string.title_section8),
                            getString(R.string.title_section10),

                            getString(R.string.title_section9),
                        }),
                this);
        
        
    }

    private void fill(File f)

    {
    	

     //This gets the searchname Global sting stored in searchname.java     
       File[]dirs = f.listFiles(new FilenameFilter() {
    	   
              	public boolean accept(File dir, String name) {
              		
              		//searchname.searchname = "response";
              		searchname.searchname = searchname.searchname.toUpperCase();
               return name.toUpperCase().contains(searchname.searchname);
           	}
      	});

        
       

        this.setTitle(""+f.getName());
        
        
      
        

         List<Option>dir = new ArrayList<Option>();

         List<Option>fls = new ArrayList<Option>();
         

         try{

             for(File ff: dirs)

             {

                if(ff.isDirectory())
                {	fill(ff);
            	
                }
                else

                           {
                	SimpleDateFormat sdf = new SimpleDateFormat("dd MMM yyyy");                    // fls.add(new Option(ff.getName(),"Date Modified: "+ff.lastModified(),ff.getAbsolutePath()));
                    fls.add(new Option(ff.getName(),"Date Modified: "+sdf.format(ff.lastModified()), ff.getAbsolutePath()));
                }

             }

         }catch(Exception e)

         {
              

         }
    
adapter.addAll(fls);
     

    }
    
    //****************************    END OF FILL   ***************************************

    


    
    private <T> List<Comparable<? super Comparable<? super T>>> lastModified() {
		// TODO Auto-generated method stub
		return null;
	}

	@Override

    protected void onListItemClick(ListView l, View v, int position, long id) {

        // TODO Auto-generated method stub

        super.onListItemClick(l, v, position, id);

        Option o = adapter.getItem(position);

        if(o.getData().equalsIgnoreCase("folder")||o.getData().equalsIgnoreCase("parent directory")){
        	currentDir = new File(o.getPath());
            fill(currentDir);

    }
    
        else

        {

            onFileClick(o);

        }
     

    }

    private void onFileClick(Option o){

    File pdfFile = new File((o.getAbsolutePath())); 
    Log.w("Joel", "You can read and write to SDcard");
    if(pdfFile.exists()) 
    {
        Uri path = Uri.fromFile(pdfFile); 
        Intent pdfIntent = new Intent(Intent.ACTION_VIEW);
        pdfIntent.setDataAndType(path, "application/pdf");
        pdfIntent.setFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);

        try
        {
            startActivity(pdfIntent);
        }
        catch(ActivityNotFoundException e)
        {
            Toast.makeText(this, "No Application available to view pdf", Toast.LENGTH_LONG).show(); 
        }
    }

}
    
    
    
    /**
     * Backward-compatible version of {@link ActionBar#getThemedContext()} that
     * simply returns the {@link android.app.Activity} if
     * <code>getThemedContext</code> is unavailable.
     */
    
    
    
    @TargetApi(Build.VERSION_CODES.ICE_CREAM_SANDWICH)
    private Context getActionBarThemedContextCompat() {
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.ICE_CREAM_SANDWICH) {
            return getActionBar().getThemedContext();
        } else {
            return this;
        }
    }

    @Override
    public void onRestoreInstanceState(Bundle savedInstanceState) {
        // Restore the previously serialized current dropdown position.
        if (savedInstanceState.containsKey(STATE_SELECTED_NAVIGATION_ITEM)) {
            getActionBar().setSelectedNavigationItem(
                    savedInstanceState.getInt(STATE_SELECTED_NAVIGATION_ITEM));
        }
    }

    @Override
    public void onSaveInstanceState(Bundle outState) {
        // Serialize the current dropdown position.
        outState.putInt(STATE_SELECTED_NAVIGATION_ITEM,
                getActionBar().getSelectedNavigationIndex());
    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.main, menu);
        return true;
    }
    
    protected void launchActivity(int position) {
        switch (position) {
        case 1:
        	Intent intent = new Intent(this, MainActivity.class);
            startActivity(intent);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 2:
        	Intent intent1 = new Intent(this, OperatingProcedures.class);
            startActivity(intent1);
            finish();
              	Log.w("Joel", "Switch Case 2");
                break;
        case 3:
        	Intent intent11 = new Intent(this, OperatingNotices.class);
            startActivity(intent11);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 4:
        	Intent intent111 = new Intent(this, OperatingInstructions.class);
            startActivity(intent111);
            finish();
              	Log.w("Joel", "Switch Case 2");
                break;
        case 5:
        	Intent intent1111 = new Intent(this, GeneralOrders.class);
            startActivity(intent1111);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 6:
        	Intent intent11111 = new Intent(this, TrackCharts.class);
            startActivity(intent11111);
            finish();
              	Log.w("Joel", "Switch Case 2");
                break;
        case 7:
        	Intent intent111111 = new Intent(this, Manuals.class);
            startActivity(intent111111);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 8:
        	Intent intent1111111 = new Intent(this, OperatingStrategies.class);
            startActivity(intent1111111);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 9:
        	Intent intent11111111 = new Intent(this, SearchScreen.class);
            startActivity(intent11111111);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
           
        }
    }
    
    
    
    @Override
    public boolean onNavigationItemSelected(int position, long id) {
    	launchActivity(position);
        return true;
        }
    
    
    
}



    

I am thinking it has something to do with this code:

 private void fill(File f)

    {
    	

     //This gets the searchname Global sting stored in searchname.java     
       File[]dirs = f.listFiles(new FilenameFilter() {
    	   
              	public boolean accept(File dir, String name) {
              		
              		//searchname.searchname = "response";
              		searchname.searchname = searchname.searchname.toUpperCase();
               return name.toUpperCase().contains(searchname.searchname);
           	}
      	});

That is my filename filter that takes the search term and is run in the private void fill(File f) section. Can you see any reason why the recursion is working with no search term, but when I have a search word put in it returns a blank screen?

Thank you very much for your continuing help.

Kind regards,
Joel

[Joel Keane]

After further investigation I have found out that the search does work for certain letters or words. If you put in an "a" it will work or some words that are contained in file names will work. So it seems to be having a problem with the logic in searching the titles. Just thought I would add that in case it helps with your reply.

[Joel Keane]

Also, here is the FileArrayAdapter.java file:

package com.proceduresyncv2;

import java.util.List;

import com.proceduresyncv2.R;

import android.content.Context;
import android.view.LayoutInflater;
import android.view.Menu;
import android.view.MenuInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.ArrayAdapter;
import android.widget.TextView;

 


public class FileArrayAdapter extends ArrayAdapter<Option>{

 

    private Context c;

    private int id;

    private List<Option>items;

     

    public FileArrayAdapter(Context context, int textViewResourceId,

            List<Option> objects) {

        super(context, textViewResourceId, objects);

        c = context;

        id = textViewResourceId;

        items = objects;

    }

    public Option getItem(int i)

     {

         return items.get(i);

     }


     @Override

       public View getView(int position, View convertView, ViewGroup parent) {

               View v = convertView;

               if (v == null) {

                   LayoutInflater vi = (LayoutInflater)c.getSystemService(Context.LAYOUT_INFLATER_SERVICE);

                   v = vi.inflate(id, null);

               }

               final Option o = items.get(position);

               if (o != null) {

                       TextView t1 = (TextView) v.findViewById(R.id.TextView01);

                       TextView t2 = (TextView) v.findViewById(R.id.TextView02);

                        

                       if(t1!=null)

                           t1.setText(o.getName());

                       if(t2!=null)

                           t2.setText(o.getData());

                        

               }

               return v;

       }

 

}
  

Perhaps I need to do the filtering in here???

[Karthik Shiraly]

Yes, you are probably right about the file filter.
It'll currently discard subdirectories too which don't contain the keyword. But if I understood your requirement right, you want the code to walk through *all* directories and subdirectories, and filter out only the files.
That is, the filter should apply only for files, not for directories.
So one option is:

public boolean accept(File f, String name) {  
    if f.isDirectory() {
        return true; // Don't discard any subdirectories
    } else {
        return name.toUpperCase().contains(searchname.searchname.toUpperCase());  
    }
}

[Joel Keane]

Thanks. Yes, I want the code to "walk" through all directories and sub directories and look for file names that contain the search term. I have changed my code to:

 public boolean accept(File f, String name) {    
    		    
    		   if (f.isDirectory()){   
    		        return true; // Don't discard any subdirectories  
    		   }
    		    else { 
    		    	searchname.searchname = searchname.searchname.toUpperCase();
    		        return name.toUpperCase().contains(searchname.searchname.toUpperCase());    
    		    }  
    	   }
      	});

However now it seems not to apply the search string at all. It lists every file in all the directories and sub directories - even if there is a search term entered.

Thank you

[Karthik Shiraly]

Hi Joel,
Oops, forgot my accept() API details. My mistake, sorry about that.
In accept(File dir, String name) -> the "dir" is always the parent directory path, not path of current file or subdirectory being evaluated. And "name" is the name of the child file or subdirectory under "dir" that's being evaluated by the filter.
So the full path of current file/subdirectory being evaluated is "dir/name", and this is the one we actually want to check for isDirectory().

public boolean accept(File dir, String name) {    
    File f = new File(dir, name); // Form the file path "dir/name".
    if (f.isDirectory()) {  
        return true; // Don't discard any subdirectories  
    } else {  
        return name.toUpperCase().contains(searchname.searchname.toUpperCase());    
    }  
}  

[Joel Keane]

Hi Karthik,

Thank you! Thank you! Thank you!

I appreciate all the time and effort you put in to help me fix my recursive/search problems. I have also learned quite a few things regarding arrays etc and the logic behind them also. I have attached my new working code in case it might help someone else at a later date with a similar problem.

Once again, I can't thank you enough and I wish you all the best :-)

Kind regards,
Joel

My corrected code:

package com.proceduresyncv2;

import java.io.File;
import java.io.FilenameFilter;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.List;

import com.proceduresyncv2.R;

import android.annotation.TargetApi;
import android.app.ActionBar;
import android.app.ListActivity;
import android.net.Uri;
import android.os.Bundle;
import android.os.Environment;
import android.content.ActivityNotFoundException;
import android.content.Context;
import android.content.Intent;
import android.os.Build;
import android.support.v4.app.Fragment;
import android.support.v4.app.FragmentActivity;
import android.support.v4.app.NavUtils;
import android.util.Log;
import android.view.Gravity;
import android.view.LayoutInflater;
import android.view.Menu;
import android.view.MenuItem;
import android.view.View;
import android.view.ViewGroup;
import android.widget.ArrayAdapter;
import android.widget.ListView;
import android.widget.TextView;
import android.widget.Toast;

public class OperatingProceduresSearch extends ListActivity  implements ActionBar.OnNavigationListener {

    /**
     * The serialization (saved instance state) Bundle key representing the
     * current dropdown position.
     */
	
	private File currentDir;
	
	 /* Accumulate all the matching files  */
    private FileArrayAdapter adapter;

	
    private static final String STATE_SELECTED_NAVIGATION_ITEM = "selected_navigation_item";
    
    
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
             
  // Recursion would have ended now, and all matches are accumulated in "adapter".  

        List<Option>dir = new ArrayList<Option>();
        adapter = new FileArrayAdapter(OperatingProceduresSearch.this, R.layout.file_view, dir);  
        fill(new File(Environment.getExternalStorageDirectory() + "/RTIO"));
        this.setListAdapter(adapter);   
        
   // Set up the action bar to show a dropdown list.
        
        final ActionBar actionBar = getActionBar();
        actionBar.setDisplayShowTitleEnabled(false);
        actionBar.setNavigationMode(ActionBar.NAVIGATION_MODE_LIST);
        actionBar.setTitle( "" );

   // Set up the dropdown list navigation in the action bar.
        actionBar.setListNavigationCallbacks(
        		
   // Specify a SpinnerAdapter to populate the dropdown list.
                new ArrayAdapter<String>(
                        getActionBarThemedContextCompat(),
                        android.R.layout.simple_list_item_1,
                        android.R.id.text1,
                        new String[] {
                        	getString(R.string.title_section6),
                        	getString(R.string.title_section1),
                        	getString(R.string.title_section2),
                        	getString(R.string.title_section3),
                        	getString(R.string.title_section4),
                        	getString(R.string.title_section5),
                            getString(R.string.title_section7),
                            getString(R.string.title_section8),
                            getString(R.string.title_section10),

                            getString(R.string.title_section9),
                        }),
                this);              
    }

    
    //****Recursively search through all the folders and find files that match the search query****
    //****This is done through the "fill"
    
    private void fill(File f)

    {
    	
     //This gets the searchname Global string stored in searchname.java     
       File[]dirs = f.listFiles(new FilenameFilter() {
    	   
    	   public boolean accept(File dir, String name) {    
    		   File f = new File(dir, name); // Form the file path "dir/name". 
    		   if (f.isDirectory()){   
    		 return true; // Don't discard any subdirectories  
    		          		   }    		   
    		    		    else { 
    		    	searchname.searchname = searchname.searchname.toUpperCase();
    		        return name.toUpperCase().contains(searchname.searchname.toUpperCase()); 
    		            		    }  
    	   }
      	});

           
        this.setTitle(""+f.getName());
             
         List<Option>dir = new ArrayList<Option>();
                

         try{

             for(File ff: dirs)
             {
       //***If fill comes across a directory "fill" it to look for files***
                if(ff.isDirectory()) {	
                	fill(ff);            	
                }
               
                else
                	
        //****It must be a file so add the modified date and the file data to the array***
                           {
                	SimpleDateFormat sdf = new SimpleDateFormat("dd MMM yyyy");                    
                    dir.add(new Option(ff.getName(),"Date Modified: "+sdf.format(ff.lastModified()), ff.getAbsolutePath()));
                }
            }

         }catch(Exception e)

         {        
         }
    
adapter.addAll(dir);
     
    }
    
    //****************************    END OF FILL   ***************************************

    


    
    private <T> List<Comparable<? super Comparable<? super T>>> lastModified() {
			return null;
	}

	
    
    //****What to do when a user clicks on the filename on the screen****
    
    @Override

    protected void onListItemClick(ListView l, View v, int position, long id) {
        super.onListItemClick(l, v, position, id);
        Option o = adapter.getItem(position);
        if(o.getData().equalsIgnoreCase("folder")||o.getData().equalsIgnoreCase("parent directory")){
        	currentDir = new File(o.getPath());
            fill(currentDir);
    }
    
        else

        {
            onFileClick(o);
        }
         }

    private void onFileClick(Option o){

    File pdfFile = new File((o.getAbsolutePath())); 
    Log.w("Joel", "You can read and write to SDcard");
    if(pdfFile.exists()) 
    {
        Uri path = Uri.fromFile(pdfFile); 
        Intent pdfIntent = new Intent(Intent.ACTION_VIEW);
        pdfIntent.setDataAndType(path, "application/pdf");
        pdfIntent.setFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);

        try
        {
            startActivity(pdfIntent);
        }
        catch(ActivityNotFoundException e)
        {
            Toast.makeText(this, "No Application available to view pdf", Toast.LENGTH_LONG).show(); 
        }
    }

}
    
//***End of handling of on screen click*****    
    
    /**
     * Backward-compatible version of {@link ActionBar#getThemedContext()} that
     * simply returns the {@link android.app.Activity} if
     * <code>getThemedContext</code> is unavailable.
     */
    
    
    
    @TargetApi(Build.VERSION_CODES.ICE_CREAM_SANDWICH)
    private Context getActionBarThemedContextCompat() {
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.ICE_CREAM_SANDWICH) {
            return getActionBar().getThemedContext();
        } else {
            return this;
        }
    }

    @Override
    public void onRestoreInstanceState(Bundle savedInstanceState) {
        // Restore the previously serialized current dropdown position.
        if (savedInstanceState.containsKey(STATE_SELECTED_NAVIGATION_ITEM)) {
            getActionBar().setSelectedNavigationItem(
                    savedInstanceState.getInt(STATE_SELECTED_NAVIGATION_ITEM));
        }
    }

    @Override
    public void onSaveInstanceState(Bundle outState) {
        // Serialize the current dropdown position.
        outState.putInt(STATE_SELECTED_NAVIGATION_ITEM,
                getActionBar().getSelectedNavigationIndex());
    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.main, menu);
        return true;
    }
    
    
 //****This tells the activity what to do when a different object is selected on the Actionbar***   
    
    protected void launchActivity(int position) {
        switch (position) {
        case 1:
        	Intent intent = new Intent(this, MainActivity.class);
            startActivity(intent);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 2:
        	Intent intent1 = new Intent(this, OperatingProcedures.class);
            startActivity(intent1);
            finish();
              	Log.w("Joel", "Switch Case 2");
                break;
        case 3:
        	Intent intent11 = new Intent(this, OperatingNotices.class);
            startActivity(intent11);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 4:
        	Intent intent111 = new Intent(this, OperatingInstructions.class);
            startActivity(intent111);
            finish();
              	Log.w("Joel", "Switch Case 2");
                break;
        case 5:
        	Intent intent1111 = new Intent(this, GeneralOrders.class);
            startActivity(intent1111);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 6:
        	Intent intent11111 = new Intent(this, TrackCharts.class);
            startActivity(intent11111);
            finish();
              	Log.w("Joel", "Switch Case 2");
                break;
        case 7:
        	Intent intent111111 = new Intent(this, Manuals.class);
            startActivity(intent111111);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 8:
        	Intent intent1111111 = new Intent(this, OperatingStrategies.class);
            startActivity(intent1111111);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
        case 9:
        	Intent intent11111111 = new Intent(this, SearchScreen.class);
            startActivity(intent11111111);
            finish();
        	Log.w("Joel", "Switch Case 1");
        	break;
           
        }
    }
    
    
    
    @Override
    public boolean onNavigationItemSelected(int position, long id) {
    	launchActivity(position);
        return true;
        }
    
    
    
}



    

[Karthik Shiraly]

You're welcome! Glad you got it working

[Joel Keane]

Hi Karthik,

There is one other feature I just thought of that you may be able to help me with. There is one sub directory that I do not wish to include in the file recursion. That is, I do not want any files from that sub directory to be included in the array.

The sub directory is: File(Environment.getExternalStorageDirectory() + "/RTIO/RecentFiles"));

I am thinking that I need to include something in this section of code:

for(File ff: dirs)
             {
       //***If fill comes across a directory "fill" it to look for files***
                if(ff.isDirectory()) {	
                	fill(ff);            	
                }
               
               
                else
                	
        //****It must be a file so add the modified date and the file data to the array***
                           {
                	SimpleDateFormat sdf = new SimpleDateFormat("dd MMM yyyy");                    
                    dir.add(new Option(ff.getName(),"Date Modified: "+sdf.format(ff.lastModified()), ff.getAbsolutePath()));
                }
            }

         }catch(Exception e)

         {        
         }

I have tried a few things but cannot seem to get it to work. Are you able to point me in the right direction please?

Thanks heaps.

[Joel Keane]

I have now solved my problem regarding how to exclude a directory and its files from the search results. FYI the folder that I wanted to exclude was called "Recent Files".

Here is my fixed code:

for(File ff: dirs)
             {
            	
       //***If fill comes across a directory "fill" it to look for files***
            	            	 
            	 if(ff.isDirectory()&& !ff.getCanonicalPath().contains("Recent Files")){ 
            	//If it is a directory and the path does not contain "Recent Files"	 
                     fill(ff);                 
                 }  
                  
            	 if(ff.isDirectory()&& ff.getCanonicalPath().contains("Recent Files")){    
            		  	//If it is a directory and the path does contain "Recent Files"	             
                 }  
            	                
                if (ff.isFile()&& !ff.getCanonicalPath().contains("Recent Files"))        
                  	//If it is a file and the path does not contain "Recent Files"	      
                {  
                     SimpleDateFormat sdf = new SimpleDateFormat("dd MMM yyyy");                      
                     dir.add(new Option(ff.getName(),"Date Modified: "+sdf.format(ff.lastModified()), ff.getAbsolutePath()));  
                 }  
             }  

         }catch(Exception e)

         {        
         }

Hope this helps someone else out.