getting message "get is not valid without active transaction" while trying to delete using Hibernate

[Monica Shiralkar]

I am trying to delete User based on userId but getting message "org.hibernate.HibernateException: get is not valid without active transaction"

error message:


org.hibernate.HibernateException: get is not valid without active transaction
org.hibernate.context.ThreadLocalSessionContext$TransactionProtectionWrapper.invoke(ThreadLocalSessionContext.java:297)
$Proxy6.get(Unknown Source)
com.dao.LoginHibernateDaoImpl.deleteUsersbyId(LoginHibernateDaoImpl.java:115)
com.web.DeleteUserAction.execute(DeleteUserAction.java:48)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)


The code which leads to this message is :

	@Override
	public void deleteUsersbyId(String userId) {
		 Session session = HibernateUtil.getSessionFactory().getCurrentSession();
	        Transaction tx=null;
	        
	     
		 Object o=session.load(User.class,Integer.parseInt(userId));
	        User u=(User)o;
	 
	         tx = session.beginTransaction();
	        session.delete(u);
	        System.out.println("Object Deleted successfully.....!!");
	        tx.commit();
	      
		
		System.out.println("userId"+userId);
		
	}

thanks

[Paul Clapham]

Why wait so long to start the transaction? Did you have a reason you wanted to get the User object outside the transaction?

And now you have an error message about exactly that. I suggest it shouldn't be too hard to fix the problem.

[Bin Smith]

Hello!

Monica, all methods of org.hibernate.Session should be called within active transaction.
You need to get current session then begin transaction only then use org.hibernate.Session then commit transaction then close session.
Probably all methods of org.hibernate.Session are not executed when you call them but WHEN transaction is committed (line 13 in your code).

[Monica Shiralkar]

Thanks. It worked.