• Post Reply Bookmark Topic Watch Topic
  • New Topic
programming forums Java Mobile Certification Databases Caching Books Engineering Micro Controllers OS Languages Paradigms IDEs Build Tools Frameworks Application Servers Open Source This Site Careers Other Pie Elite all forums
this forum made possible by our volunteer staff, including ...
Marshals:
  • Campbell Ritchie
  • Jeanne Boyarsky
  • Ron McLeod
  • Paul Clapham
  • Liutauras Vilda
Sheriffs:
  • paul wheaton
  • Rob Spoor
  • Devaka Cooray
Saloon Keepers:
  • Stephan van Hulst
  • Tim Holloway
  • Carey Brown
  • Frits Walraven
  • Tim Moores
Bartenders:
  • Mikalai Zaikin

How will you react?

 
Greenhorn
Posts: 3
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator
Hi Ranchers,

I need your help.My boss wants to implement some code which he wrote which is very very sloppy and has performance issues. Also maintenance and debugging issues. He doesn't like criticizing him. I have two choices, either obey, what he is asking for ( but I feel I am cheating myself) or tell him these are the issues in your code ( then he will bully me more). So tell me how to deal a situation like this.



 
Bartender
Posts: 3648
16
Android Mac OS X Firefox Browser Java
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator
Welcome to the Ranch.

First off, do you understand what your manager is trying to achieve? Look at the code, does it actually or seem to do what he wants? I assume you do.

Forget about performance. Forget about if the code is documented.

Writing correct functional code is key. If you understand the code as is and its purpose then you are in a position to criticize or nitpick it.

Now do you know a better approach to solve the same problem? This includes algorithm, syntax use (eg while vs for loop), API usage (don't reinvent the wheel) etc.

The last thing you should concern is performance. Of course unless your code is for those low latency stuff.

At the end of the day, KISS and don't complicate things more.
 
author & internet detective
Posts: 41860
908
Eclipse IDE VI Editor Java
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator
Marc,
Welcome to CodeRanch!

I don't understand what you mean by implement code that he wrote. If your boss wrote the code, you wouldn't be writing it. Can you elaborate?
 
Don't get me started about those stupid light bulbs.
reply
    Bookmark Topic Watch Topic
  • New Topic