JFreeChart problem (No axis label)

[Jacky Luk]

I have modified the source code of JFreeChart in the file called BarRenderer. In this file, I made the following change to it

   public void drawItem(Graphics2D g2,
                         CategoryItemRendererState state,
                         Rectangle2D dataArea,
                         CategoryPlot plot,
                         CategoryAxis domainAxis,
                         ValueAxis rangeAxis,
                         CategoryDataset dataset,
                         int row,
                         int column,
                         int pass) {

        // nothing is drawn for null values...
        Number dataValue = dataset.getValue(row, column);
        if (dataValue == null) {
            return;
        }
        
        double value = dataValue.doubleValue();
        
        PlotOrientation orientation = plot.getOrientation();
        double barW0 = calculateBarW0(plot, orientation, dataArea, domainAxis, 
                state, row, column);
        double[] barL0L1 = calculateBarL0L1(value);
        if (barL0L1 == null) {
            return;  // the bar is not visible
        }
        
        RectangleEdge edge = plot.getRangeAxisEdge();
        double transL0 = rangeAxis.valueToJava2D(barL0L1[0], dataArea, edge);
        double transL1 = rangeAxis.valueToJava2D(barL0L1[1], dataArea, edge);
        double barL0 = Math.min(transL0, transL1);
        double barLength = Math.max(Math.abs(transL1 - transL0), 
                getMinimumBarLength());

        // draw the bar...
        Rectangle2D bar = null;
        int i = 0;
        barW0 -= count;
        if (set && i < count)
        {
           
             if (orientation == PlotOrientation.HORIZONTAL) {
                bar = new Rectangle2D.Double(barL0, barW0, barLength, 
                    state.getBarWidth());
            }
            // Jacky Luk todo
            else {
                 System.out.println("total is: " + (barW0 + (double)x));
                 System.out.println("X is: " + (double)x);
                 
                bar = new Rectangle2D.Double((barW0+(double)x), barL0, state.getBarWidth(), 
                        barLength);
             }
            
            Paint itemPaint = getItemPaint(row, column);
            GradientPaintTransformer t = getGradientPaintTransformer();
            if (t != null && itemPaint instanceof GradientPaint) {
                itemPaint = t.transform((GradientPaint) itemPaint, bar);
            }
            g2.setPaint(itemPaint);
            g2.fill(bar);

            // draw the outline...
            if (isDrawBarOutline() 
                    && state.getBarWidth() > BAR_OUTLINE_WIDTH_THRESHOLD) {
                Stroke stroke = getItemOutlineStroke(row, column);
                Paint paint = getItemOutlinePaint(row, column);
                if (stroke != null && paint != null) {
                    g2.setStroke(stroke);
                    g2.setPaint(paint);
                    g2.draw(bar);
                    

                   }
                }
            i++;
            CategoryItemLabelGenerator generator 
            = getItemLabelGenerator(row, column);
            if (generator != null && isItemLabelVisible(row, column)) {
                drawItemLabel(g2, dataset, row, column, plot, generator, bar, 
                        (value < 0.0));
            }        

            // add an item entity, if this information is being collected
            EntityCollection entities = state.getEntityCollection();
            if (entities != null) {
                addItemEntity(entities, dataset, row, column, bar);
            }
        }
        else
        {
            if (orientation == PlotOrientation.HORIZONTAL) {
            bar = new Rectangle2D.Double(barL0, barW0, barLength, 
                    state.getBarWidth());
            }
             
            else {
                bar = new Rectangle2D.Double(barW0, barL0, state.getBarWidth(), 
                        barLength);
             }
            Paint itemPaint = getItemPaint(row, column);
            GradientPaintTransformer t = getGradientPaintTransformer();
            if (t != null && itemPaint instanceof GradientPaint) {
                itemPaint = t.transform((GradientPaint) itemPaint, bar);
            }
            g2.setPaint(itemPaint);
            g2.fill(bar);

            // draw the outline...
            if (isDrawBarOutline() 
                    && state.getBarWidth() > BAR_OUTLINE_WIDTH_THRESHOLD) {
                Stroke stroke = getItemOutlineStroke(row, column);
                Paint paint = getItemOutlinePaint(row, column);
                if (stroke != null && paint != null) {
                    g2.setStroke(stroke);
                    g2.setPaint(paint);
                    g2.draw(bar);
                }
            }
            CategoryItemLabelGenerator generator = getItemLabelGenerator(row, column);
            if (generator != null && isItemLabelVisible(row, column)) {
                drawItemLabel(g2, dataset, row, column, plot, generator, bar, 
                        (value < 0.0));
            }        

            // add an item entity, if this information is being collected
            EntityCollection entities = state.getEntityCollection();
            if (entities != null) {
                addItemEntity(entities, dataset, row, column, bar);
            }

        }
     }

So that it animates when the chart comes in (fly-in effect)
Here it how it is called.

 protected JFreeChart create2DBarChart(final CategoryDataset dataset) 
    {
        JFreeChart achart = ChartFactory.createBarChart(name, xaxisname, yaxisname, dataset, PlotOrientation.VERTICAL, true, true, false);
        //achart.getTitle().setFont(new Font("新細明體", Font.BOLD, 22));
        
        
       
        final CategoryPlot plot = achart.getCategoryPlot();
        plot.setBackgroundPaint(Color.lightGray);
        plot.setDomainGridlinePaint(Color.white);
        plot.setRangeGridlinePaint(Color.white);

        // set the range axis to display integers only...
        final NumberAxis rangeAxis = (NumberAxis) plot.getRangeAxis();
        rangeAxis.setStandardTickUnits(NumberAxis.createIntegerTickUnits());

        // disable bar outlines...
        final BarRenderer renderer = (BarRenderer) plot.getRenderer();
        renderer.setMove(100,true);
        renderer.setDrawBarOutline(false);
        
        
         
        
        // set up gradient paints for series...
        final GradientPaint gp0 = new GradientPaint(
            0.0f, 0.0f, Color.blue, 
            0.0f, 0.0f, Color.lightGray
        );
        final GradientPaint gp1 = new GradientPaint(
            0.0f, 0.0f, Color.green, 
            0.0f, 0.0f, Color.lightGray
        );
        final GradientPaint gp2 = new GradientPaint(
            0.0f, 0.0f, Color.red, 
            0.0f, 0.0f, Color.lightGray
        );
        renderer.setSeriesPaint(0, gp0);
        renderer.setSeriesPaint(1, gp1);
        renderer.setSeriesPaint(2, gp2);

        final CategoryAxis domainAxis = plot.getDomainAxis();
        domainAxis.setCategoryLabelPositions(
            CategoryLabelPositions.createUpRotationLabelPositions(Math.PI / 6.0)
        );
        // OPTIONAL CUSTOMISATION COMPLETED.
        
        return achart;
        
        // OPTIONAL CUSTOMISATION COMPLETED.
       //Tween.to(chart.getCategoryPlot(), tweenType, duration)
    
    }

However, I didn't know why the axis labels were gone
Here is how it looks on rendering


I wanna know why the labels were gone.

Thanks
Jack

[Richard Tookey]

I suspect you are going to have trouble getting a 'fix' for this problem. I for one am not going to go through all that code to try to understand it and I suspect most people here will feel the same. Also, I do not know which JFreeChart version you based this on to see what changes you made and though I use JFreeChart and have a version of the source code it may not be the version you started from. If there was an SSCCE then I might be inclined to run it and look for the obvious but I'm not willing to generate one for you.

[Jacky Luk]

Sorry, I didn't clarify this

The changes I have made were
1) adding a branch to the drawItem method, so that when it is "set" and a count has been added

 renderer.setMove(100,true);  

public void setMove(/*double _x, double _y,*/ int _count, boolean _set)
    {
        //x = _x;
        //y = _y;
        count = _count;
        set = _set;
    }
    
    public void Increment()
    {
        x+=10;
    }

    boolean set;
    int count;
    int x;

  if (set && i < count)  
        {  
             
             if (orientation == PlotOrientation.HORIZONTAL) {  
                bar = new Rectangle2D.Double(barL0, barW0, barLength,   
                    state.getBarWidth());  
            }  
//// ...

This will affect the g2.fill(bar) method, and there will be a repetition of g2.fill(bar) calls for i number of times.
which there was a pre-shift of location x for the bar, I didn't change the rest of the code.
The only I notice was

      CategoryItemLabelGenerator generator   
            = getItemLabelGenerator(row, column);  
            if (generator != null && isItemLabelVisible(row, column)) {  
                drawItemLabel(g2, dataset, row, column, plot, generator, bar,   
                        (value < 0.0));  
            }          
  
            // add an item entity, if this information is being collected  
            EntityCollection entities = state.getEntityCollection();  
            if (entities != null) {  
                addItemEntity(entities, dataset, row, column, bar);  
            } 

getItemLabelGenerator is using row and column parameters of drawItem method which shouldn't be affected by the
code preceding it. Here, when I set a breakpoint inside getItemLabelGenerator

 public CategoryItemLabelGenerator getSeriesItemLabelGenerator(int series) {

        // return the generator for ALL series, if there is one...
        if (this.itemLabelGenerator != null) {
            return this.itemLabelGenerator;
        }

        // otherwise look up the generator table
        CategoryItemLabelGenerator generator = (CategoryItemLabelGenerator) 
            this.itemLabelGeneratorList.get(series);
        if (generator == null) {
            generator = this.baseItemLabelGenerator;
        }
        return generator;

    }

I will get a null from the above method.
That's it. Hope you understand.
Thanks
Jack

[Richard Tookey]

Jacky Luk wrote:Sorry, I didn't clarify this

To my mind you still haven't clarified it! In fact, if anything I think you have added to my confusion. In your first post you did not post the code for setMove() or Increment() and I still can't see what they are supposed to do. Sorry but I think you need to post an SSCCE ( <- follow the link) to stand any chance.